You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/20 11:17:29 UTC

[GitHub] [shardingsphere] WEIZIBIN opened a new pull request #6954: using SPI to instantiate MasterSlaveRouteDecorator

WEIZIBIN opened a new pull request #6954:
URL: https://github.com/apache/shardingsphere/pull/6954


   Fixes #6879.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls commented on pull request #6954: using SPI to instantiate MasterSlaveRouteDecorator

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #6954:
URL: https://github.com/apache/shardingsphere/pull/6954#issuecomment-677696218


   ## Pull Request Test Coverage Report for [Build 13941](https://coveralls.io/builds/32886068)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.009%**) to **60.303%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32886068/badge)](https://coveralls.io/builds/32886068) |
   | :-- | --: |
   | Change from base [Build 13938](https://coveralls.io/builds/32883999): |  0.009% |
   | Covered Lines: | 13734 |
   | Relevant Lines: | 22775 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #6954: using SPI to instantiate MasterSlaveRouteDecorator

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #6954:
URL: https://github.com/apache/shardingsphere/pull/6954#discussion_r474057761



##########
File path: shardingsphere-features/shardingsphere-master-slave/shardingsphere-master-slave-route/src/test/java/org/apache/shardingsphere/masterslave/route/engine/MasterSlaveRouteDecoratorTest.java
##########
@@ -148,7 +158,17 @@ public void assertDecorateToMasterWithoutRouteUnitsAndWithParameters() {
         assertThat(routedDataSourceNames.next(), is(MASTER_DATASOURCE));
         assertThat(actual.getParameters().get(0), is("true"));
     }
-    
+
+    @Test
+    public void assertTypeClass() {

Review comment:
       It is the static code, so the test case is unnecessary.

##########
File path: shardingsphere-features/shardingsphere-master-slave/shardingsphere-master-slave-route/src/test/java/org/apache/shardingsphere/masterslave/route/engine/MasterSlaveRouteDecoratorTest.java
##########
@@ -148,7 +158,17 @@ public void assertDecorateToMasterWithoutRouteUnitsAndWithParameters() {
         assertThat(routedDataSourceNames.next(), is(MASTER_DATASOURCE));
         assertThat(actual.getParameters().get(0), is("true"));
     }
-    
+
+    @Test
+    public void assertTypeClass() {
+        assertThat(routeDecorator.getTypeClass(), org.hamcrest.core.Is.<Class<?>>is(MasterSlaveRule.class));
+    }
+
+    @Test
+    public void assertOrder() {

Review comment:
       It is the static code, so the test case is unnecessary. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] WEIZIBIN commented on a change in pull request #6954: using SPI to instantiate MasterSlaveRouteDecorator

Posted by GitBox <gi...@apache.org>.
WEIZIBIN commented on a change in pull request #6954:
URL: https://github.com/apache/shardingsphere/pull/6954#discussion_r474366463



##########
File path: shardingsphere-features/shardingsphere-master-slave/shardingsphere-master-slave-route/src/test/java/org/apache/shardingsphere/masterslave/route/engine/MasterSlaveRouteDecoratorTest.java
##########
@@ -148,7 +158,17 @@ public void assertDecorateToMasterWithoutRouteUnitsAndWithParameters() {
         assertThat(routedDataSourceNames.next(), is(MASTER_DATASOURCE));
         assertThat(actual.getParameters().get(0), is("true"));
     }
-    
+
+    @Test
+    public void assertTypeClass() {

Review comment:
       I misunderstood.
   delete it already. thx!

##########
File path: shardingsphere-features/shardingsphere-master-slave/shardingsphere-master-slave-route/src/test/java/org/apache/shardingsphere/masterslave/route/engine/MasterSlaveRouteDecoratorTest.java
##########
@@ -148,7 +158,17 @@ public void assertDecorateToMasterWithoutRouteUnitsAndWithParameters() {
         assertThat(routedDataSourceNames.next(), is(MASTER_DATASOURCE));
         assertThat(actual.getParameters().get(0), is("true"));
     }
-    
+
+    @Test
+    public void assertTypeClass() {
+        assertThat(routeDecorator.getTypeClass(), org.hamcrest.core.Is.<Class<?>>is(MasterSlaveRule.class));
+    }
+
+    @Test
+    public void assertOrder() {

Review comment:
       I misunderstood.
   delete it already. thx!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #6954: using SPI to instantiate MasterSlaveRouteDecorator

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #6954:
URL: https://github.com/apache/shardingsphere/pull/6954


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org