You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/08 14:26:05 UTC
[GitHub] [airflow] VladaZakharova opened a new pull request, #25608: Add new Compute Engine Operators and fix system tests
VladaZakharova opened a new pull request, #25608:
URL: https://github.com/apache/airflow/pull/25608
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Add new Compute Engine Operators. Added new and updated existing system tests Compute Engine operators.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lwyszomi commented on pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
lwyszomi commented on PR #25608:
URL: https://github.com/apache/airflow/pull/25608#issuecomment-1301868487
@potiuk These changes are open for a long time because we had some problems with build, maybe now when build passed is possibility to review and merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25608:
URL: https://github.com/apache/airflow/pull/25608#issuecomment-1250380514
confilcts to be resolved - likely after __future__.annotation change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lwyszomi commented on pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
lwyszomi commented on PR #25608:
URL: https://github.com/apache/airflow/pull/25608#issuecomment-1291562594
https://github.com/apache/airflow/issues/9941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25608:
URL: https://github.com/apache/airflow/pull/25608#issuecomment-1229251622
conflicts + errors to fix :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25608:
URL: https://github.com/apache/airflow/pull/25608#issuecomment-1252833716
Docs failing :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25608:
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25608:
URL: https://github.com/apache/airflow/pull/25608#issuecomment-1296550149
I think configure aws credentials update was not intentional. Please use "git submodule update" to update your version to the latest we have :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
o-nikolas commented on PR #25608:
URL: https://github.com/apache/airflow/pull/25608#issuecomment-1278131584
> > Some tests are failing.
>
> Yes, but the problem is that all these tests, that are failing in the CI, I can run locally without any errors for all Python versions.
How are you running the postgres CI tests?
> Can you please check what could be the reason of the errors? Thanks!
The errors can be seen [here](https://github.com/apache/airflow/actions/runs/3111337410/jobs/5045988834):
```
==== Providers postgres: 9 failures ====
tests/providers/google/cloud/hooks/test_compute.py::TestGcpComputeHookApiCall::test_delete_instance_group_manager_should_not_throw_ex_when_project_id_none: google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the application. For more information, please see https://cloud.google.com/docs/authentication/getting-started
tests/providers/google/cloud/hooks/test_compute.py::TestGcpComputeHookApiCall::test_delete_instance_should_not_throw_ex_when_project_id_none: google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the application. For more information, please see https://cloud.google.com/docs/authentication/getting-started
tests/providers/google/cloud/hooks/test_compute.py::TestGcpComputeHookApiCall::test_delete_template_should_not_throw_ex_when_project_id_none: google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the application. For more information, please see https://cloud.google.com/docs/authentication/getting-started
tests/providers/google/cloud/hooks/test_compute.py::TestGcpComputeHookApiCall::test_get_instance_group_manager_should_not_throw_ex_when_project_id_none: google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the application. For more information, please see https://cloud.google.com/docs/authentication/getting-started
tests/providers/google/cloud/hooks/test_compute.py::TestGcpComputeHookApiCall::test_get_instance_should_not_throw_ex_when_project_id_none: google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the application. For more information, please see https://cloud.google.com/docs/authentication/getting-started
tests/providers/google/cloud/hooks/test_compute.py::TestGcpComputeHookApiCall::test_get_template_should_not_throw_ex_when_project_id_none: google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the application. For more information, please see https://cloud.google.com/docs/authentication/getting-started
tests/providers/google/cloud/hooks/test_compute.py::TestGcpComputeHookApiCall::test_insert_instance_group_manager_should_not_throw_ex_when_project_id_none: google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the application. For more information, please see https://cloud.google.com/docs/authentication/getting-started
tests/providers/google/cloud/hooks/test_compute.py::TestGcpComputeHookApiCall::test_insert_instance_should_not_throw_ex_when_project_id_none: google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the application. For more information, please see https://cloud.google.com/docs/authentication/getting-started
tests/providers/google/cloud/hooks/test_compute.py::TestGcpComputeHookApiCall::test_insert_template_should_not_throw_ex_when_project_id_none: google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the application. For more information, please see https://cloud.google.com/docs/authentication/getting-started
Error: Process completed with exit code 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova commented on pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova commented on PR #25608:
URL: https://github.com/apache/airflow/pull/25608#issuecomment-1283518250
Hi Team,
I have resolved all the conflicts and errors in the tests but continue getting errors in Helm(https://github.com/apache/airflow/actions/runs/3263824766/jobs/5368266070#logs) and MSSQL(https://github.com/apache/airflow/actions/runs/3263824766/jobs/5366146241). Rebasing from main brach didn't work for me. Also i was trying to restart the build several times but it also didn't work for me. May be someone already faced this kind of problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25608:
URL: https://github.com/apache/airflow/pull/25608#issuecomment-1208609753
Some conflicts :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova commented on pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova commented on PR #25608:
URL: https://github.com/apache/airflow/pull/25608#issuecomment-1277272140
> Some tests are failing.
Yes, but the problem is that all these tests, that are failing in the CI, I can run locally without any errors for all Python versions. Can you please check what could be the reason of the errors? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
VladaZakharova closed pull request #25608: Add new Compute Engine Operators and fix system tests
URL: https://github.com/apache/airflow/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25608: Add new Compute Engine Operators and fix system tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25608:
URL: https://github.com/apache/airflow/pull/25608#issuecomment-1258118915
Some tests are failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org