You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/30 04:11:22 UTC
[GitHub] [druid] vogievetsky opened a new pull request, #13159: Web console: fix DQT import
vogievetsky opened a new pull request, #13159:
URL: https://github.com/apache/druid/pull/13159
Proof that IDEs sometimes party too hard
<img width="790" alt="image" src="https://user-images.githubusercontent.com/177816/193188627-63f8e294-0365-4003-b80a-ab14074aa966.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on a diff in pull request #13159: Web console: fix DQT import
Posted by GitBox <gi...@apache.org>.
kfaraz commented on code in PR #13159:
URL: https://github.com/apache/druid/pull/13159#discussion_r984400843
##########
web-console/src/views/query-view/__snapshots__/query-view.spec.tsx.snap:
##########
@@ -160,79 +88,7 @@ exports[`QueryView matches snapshot with query 1`] = `
<ColumnTree
columnMetadataLoading={true}
defaultSchema="druid"
- defaultWhere={
- SqlComparison {
- "decorator": undefined,
- "keywords": Object {
- "op": ">=",
- },
- "lhs": SqlRef {
- "columnRefName": RefName {
- "name": "__time",
- "quotes": false,
- },
- "keywords": Object {},
- "namespaceRefName": undefined,
- "spacing": Object {},
- "tableRefName": undefined,
- "type": "ref",
- },
- "negated": false,
- "op": ">=",
- "rhs": SqlMulti {
- "args": SeparatedArray {
- "separators": Array [
- Separator {
- "left": " ",
- "right": " ",
- "separator": "-",
- },
- ],
- "values": Array [
- SqlFunction {
- "args": undefined,
- "decorator": undefined,
- "functionName": "CURRENT_TIMESTAMP",
- "keywords": Object {
- "functionName": "CURRENT_TIMESTAMP",
- },
- "spacing": Object {},
- "specialParen": "none",
- "type": "function",
- "whereClause": undefined,
- },
- SqlInterval {
- "intervalValue": SqlLiteral {
- "keywords": Object {},
- "spacing": Object {},
- "stringValue": "'1'",
- "type": "literal",
- "value": "1",
- },
- "keywords": Object {
- "interval": "INTERVAL",
- },
- "spacing": Object {
- "postInterval": " ",
- "postIntervalValue": " ",
- },
- "type": "interval",
- "unit": "DAY",
- },
- ],
- },
- "keywords": Object {},
- "op": "-",
- "spacing": Object {},
- "type": "multi",
- },
- "spacing": Object {
- "postOp": " ",
- "preOp": " ",
- },
- "type": "comparison",
- }
- }
+ defaultWhere={"__time >= CURRENT_TIMESTAMP - INTERVAL '1' DAY"}
Review Comment:
Neat! 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky merged pull request #13159: Web console: fix DQT import
Posted by GitBox <gi...@apache.org>.
vogievetsky merged PR #13159:
URL: https://github.com/apache/druid/pull/13159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org