You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/18 06:47:51 UTC
[GitHub] [flink-table-store] JingsongLi opened a new pull request, #223: [FLINK-28579] Supports predicate testing for new columns
JingsongLi opened a new pull request, #223:
URL: https://github.com/apache/flink-table-store/pull/223
The currently added column, if there is a filter on it, will cause an error in the RowDataToObjectArrayConverter because the number of columns is not correct
We can make BinaryTableStats supports evolution from shorter rowData.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #223: [FLINK-28579] Supports predicate testing for new columns
Posted by GitBox <gi...@apache.org>.
LadyForest commented on code in PR #223:
URL: https://github.com/apache/flink-table-store/pull/223#discussion_r924013592
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/stats/BinaryTableStats.java:
##########
@@ -59,8 +59,12 @@ public BinaryTableStats(
}
public FieldStats[] fields(FieldStatsArraySerializer converter) {
+ return fields(converter, null);
Review Comment:
L#54, annotate parameter`cacheArray` as `@Nullable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #223: [FLINK-28579] Supports predicate testing for new columns
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #223:
URL: https://github.com/apache/flink-table-store/pull/223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org