You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/27 16:01:41 UTC

[GitHub] [spark] MrDLontheway opened a new pull request #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks

MrDLontheway opened a new pull request #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks
URL: https://github.com/apache/spark/pull/27026
 
 
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   Changed the source of web ui duration information
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   Task duration not updating for running tasks
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   no
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   cat web ui

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang commented on issue #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on issue #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks
URL: https://github.com/apache/spark/pull/27026#issuecomment-570422581
 
 
   @MrDLontheway could you provide more details and screenshot for the issue?
   Also, PR should be created against the master branch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks
URL: https://github.com/apache/spark/pull/27026#issuecomment-569298446
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks
URL: https://github.com/apache/spark/pull/27026#issuecomment-569297076
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MrDLontheway commented on issue #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks

Posted by GitBox <gi...@apache.org>.
MrDLontheway commented on issue #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks
URL: https://github.com/apache/spark/pull/27026#issuecomment-569424173
 
 
   > Would you please explain more about why task duration doesn't update in UI?
   > 
   > Besides, does this problem only exists in branch-2.4? Because I also see the same code in master branch.
   
   Thank you for your reminder, during the task running process, because the executive run time is not updated, the duration will not be updated. I will seek other solutions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MrDLontheway commented on issue #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks

Posted by GitBox <gi...@apache.org>.
MrDLontheway commented on issue #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks
URL: https://github.com/apache/spark/pull/27026#issuecomment-570427368
 
 
   ![ui](https://raw.githubusercontent.com/MrDLontheway/mrdlontheway.github.io/master/images/sparkuitask.png)
   when task in RUNNING status , duration not update.
   3.0.0 Removed the detail list and changed the duration calculation method, I don't know if it should be submitted to the master branch

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on a change in pull request #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks
URL: https://github.com/apache/spark/pull/27026#discussion_r361794970
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
 ##########
 @@ -848,7 +848,7 @@ private[ui] class TaskPagedTable(
         </div>
       </td>
       <td>{UIUtils.formatDate(task.launchTime)}</td>
-      <td>{formatDuration(task.taskMetrics.map(_.executorRunTime))}</td>
 
 Review comment:
   Hi @MrDLontheway , please note that this change is intentionally introduced in #23081.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] planga82 commented on a change in pull request #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks

Posted by GitBox <gi...@apache.org>.
planga82 commented on a change in pull request #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks
URL: https://github.com/apache/spark/pull/27026#discussion_r379890163
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/status/LiveEntity.scala
 ##########
 @@ -175,10 +175,15 @@ private class LiveTask(
   }
 
   override protected def doUpdate(): Any = {
-    val duration = if (info.finished) {
-      info.duration
+    var duration: Long = 0
+    var executorRunTime: Long = 0
+
+    if (info.finished) {
 
 Review comment:
   vars are not very cool in scala... how about something like this?
   
   ```
   val (duration, executorRunTime) = if (info.finished) {
         (info.duration, metrics.executorRunTime)
       } else {
         val timeRunning = info.timeRunning(lastUpdateTime.getOrElse(System.currentTimeMillis()))
         (timeRunning, timeRunning)
       }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on issue #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks
URL: https://github.com/apache/spark/pull/27026#issuecomment-569431946
 
 
   > because the executive run time is not updated, the duration will not be updated.
   
   I know that executor run time doesn't update according to your description, but I also want to know the root cause why it doesn't change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27026: [SPARK-29596][Web UI] Task duration not updating for running tasks
URL: https://github.com/apache/spark/pull/27026#issuecomment-569297076
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org