You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datafu.apache.org by "Philip (flip) Kromer" <fl...@infochimps.com> on 2014/05/19 04:08:26 UTC
Review Request 21618: DATAFU-47 UDF for Murmur3 (and other) Hash functions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21618/
-----------------------------------------------------------
Review request for DataFu.
Repository: datafu
Description
-------
Accompanies DATAFU-47 https://issues.apache.org/jira/browse/DATAFU-47 -- make sure to apply the patch from DATAFU-46 too first
Diffs
-----
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java PRE-CREATION
datafu-pig/src/test/java/datafu/test/pig/hash/HashTests.java f422e39
Diff: https://reviews.apache.org/r/21618/diff/
Testing
-------
./gradlew :datafu-pig:test -Dtest.single=HashTests
Thanks,
Philip (flip) Kromer
Re: Review Request 21618: DATAFU-47 UDF for Murmur3 (and other) Hash
functions
Posted by "Philip (flip) Kromer" <fl...@infochimps.com>.
> On May 19, 2014, 11:56 p.m., Matthew Hayes wrote:
> > datafu-pig/src/main/java/datafu/pig/hash/Hasher.java, line 77
> > <https://reviews.apache.org/r/21618/diff/2/?file=584769#file584769line77>
> >
> > Maybe a cleaner way to do this is to create a protected getRandom() method that you derive from and override. You can create this test UDF under the test directory and it should be usable within the pig script. This would actually be a good pattern for us to follow elsewhere too. We have a JIRA to improve testing of UDFs that rely on randomness.
I added a trivial subclass in a separate file in that directory.
> On May 19, 2014, 11:56 p.m., Matthew Hayes wrote:
> > datafu-pig/src/main/java/datafu/pig/hash/Hasher.java, line 119
> > <https://reviews.apache.org/r/21618/diff/2/?file=584769#file584769line119>
> >
> > I think it's important that each backend task uses the same seed when the 'rand' option is used. Otherwise the same data will hash to different values. You can ensure this by setting the seed in the front end in the UDF context. We have a ContextualEvalFunc that makes this easier. You can derive from this, then in getOutputSchema you can call getInstanceProperties() and put the seed value into the map. To get the seed, within the exec method you can call getInstanceProperties() and lazy load the seed from it. See EmptyBagToNullFields for an example using this pattern.
>
> Philip (flip) Kromer wrote:
> Awesome, I was wondering how to do this. One of the best things about submitting patches back to open-source projects is getting to learn stuff...
>
> Will make the fixes and re-submit.
ended up having SimpleEvalFunc extend ContextualEvalFunc as per DATAFU-50
- Philip (flip)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21618/#review43444
-----------------------------------------------------------
On May 20, 2014, 9:19 a.m., Philip (flip) Kromer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21618/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 9:19 a.m.)
>
>
> Review request for DataFu and Matthew Hayes.
>
>
> Bugs: DATAFU-47
> https://issues.apache.org/jira/browse/DATAFU-47
>
>
> Repository: datafu
>
>
> Description
> -------
>
> Accompanies DATAFU-47 https://issues.apache.org/jira/browse/DATAFU-47 -- make sure to apply the patch from DATAFU-46 too first
>
> Questions for reviewers:
>
> * If we upgrade Guava, we'd get sip24 (a fast cryptographically secure hash), crc32 and adler32 (occasionally useful checksums). I can put the update in as another patch. Should we upgrade?
> * This UDF provides the same hashes as MD5 and SHA udfs. Should those be deprecated in favor of this? I can add the binhex functionality so that nothing is lost.
> * If there's a standard way to do the dependency injection of a fixed random number generator for the tests please advise.
>
>
> Diffs
> -----
>
> datafu-pig/src/main/java/datafu/pig/hash/Hasher.java PRE-CREATION
> datafu-pig/src/main/java/datafu/pig/hash/HasherRand.java PRE-CREATION
> datafu-pig/src/test/java/datafu/test/pig/hash/HashTests.java 7ff8fb9
> datafu-pig/src/test/java/datafu/test/pig/hash/HasherRandForTesting.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21618/diff/
>
>
> Testing
> -------
>
> ./gradlew :datafu-pig:test -Dtest.single=HashTests
>
>
> Thanks,
>
> Philip (flip) Kromer
>
>
Re: Review Request 21618: DATAFU-47 UDF for Murmur3 (and other) Hash
functions
Posted by "Philip (flip) Kromer" <fl...@infochimps.com>.
> On May 19, 2014, 11:56 p.m., Matthew Hayes wrote:
> > datafu-pig/src/main/java/datafu/pig/hash/Hasher.java, line 119
> > <https://reviews.apache.org/r/21618/diff/2/?file=584769#file584769line119>
> >
> > I think it's important that each backend task uses the same seed when the 'rand' option is used. Otherwise the same data will hash to different values. You can ensure this by setting the seed in the front end in the UDF context. We have a ContextualEvalFunc that makes this easier. You can derive from this, then in getOutputSchema you can call getInstanceProperties() and put the seed value into the map. To get the seed, within the exec method you can call getInstanceProperties() and lazy load the seed from it. See EmptyBagToNullFields for an example using this pattern.
Awesome, I was wondering how to do this. One of the best things about submitting patches back to open-source projects is getting to learn stuff...
Will make the fixes and re-submit.
- Philip (flip)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21618/#review43444
-----------------------------------------------------------
On May 19, 2014, 11:12 p.m., Philip (flip) Kromer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21618/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 11:12 p.m.)
>
>
> Review request for DataFu and Matthew Hayes.
>
>
> Bugs: DATAFU-47
> https://issues.apache.org/jira/browse/DATAFU-47
>
>
> Repository: datafu
>
>
> Description
> -------
>
> Accompanies DATAFU-47 https://issues.apache.org/jira/browse/DATAFU-47 -- make sure to apply the patch from DATAFU-46 too first
>
> Questions for reviewers:
>
> * If we upgrade Guava, we'd get sip24 (a fast cryptographically secure hash), crc32 and adler32 (occasionally useful checksums). I can put the update in as another patch. Should we upgrade?
> * This UDF provides the same hashes as MD5 and SHA udfs. Should those be deprecated in favor of this? I can add the binhex functionality so that nothing is lost.
> * If there's a standard way to do the dependency injection of a fixed random number generator for the tests please advise.
>
>
> Diffs
> -----
>
> datafu-pig/src/main/java/datafu/pig/hash/Hasher.java PRE-CREATION
> datafu-pig/src/test/java/datafu/test/pig/hash/HashTests.java 7ff8fb9
>
> Diff: https://reviews.apache.org/r/21618/diff/
>
>
> Testing
> -------
>
> ./gradlew :datafu-pig:test -Dtest.single=HashTests
>
>
> Thanks,
>
> Philip (flip) Kromer
>
>
Re: Review Request 21618: DATAFU-47 UDF for Murmur3 (and other) Hash
functions
Posted by Matthew Hayes <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21618/#review43444
-----------------------------------------------------------
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java
<https://reviews.apache.org/r/21618/#comment77597>
I think something like below would be clearer. Rewrite as you see fit :) The current string implies it only supports non-cryptographic hashes.
-------
Computes a hash value of a string and outputs it in hex. The default constructor produces a general purpose, non-cryptographic strength hash of at least 32-bits. Additional constructors are available to choose alternative hash functions. The default constructor is equivalent to choosing 'good-32'.
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java
<https://reviews.apache.org/r/21618/#comment77608>
Maybe a cleaner way to do this is to create a protected getRandom() method that you derive from and override. You can create this test UDF under the test directory and it should be usable within the pig script. This would actually be a good pattern for us to follow elsewhere too. We have a JIRA to improve testing of UDFs that rely on randomness.
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java
<https://reviews.apache.org/r/21618/#comment77606>
Add a javadoc for this method. Also document which algorithms support a random seed.
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java
<https://reviews.apache.org/r/21618/#comment77607>
I think it's important that each backend task uses the same seed when the 'rand' option is used. Otherwise the same data will hash to different values. You can ensure this by setting the seed in the front end in the UDF context. We have a ContextualEvalFunc that makes this easier. You can derive from this, then in getOutputSchema you can call getInstanceProperties() and put the seed value into the map. To get the seed, within the exec method you can call getInstanceProperties() and lazy load the seed from it. See EmptyBagToNullFields for an example using this pattern.
- Matthew Hayes
On May 19, 2014, 11:12 p.m., Philip (flip) Kromer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21618/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 11:12 p.m.)
>
>
> Review request for DataFu and Matthew Hayes.
>
>
> Bugs: DATAFU-47
> https://issues.apache.org/jira/browse/DATAFU-47
>
>
> Repository: datafu
>
>
> Description
> -------
>
> Accompanies DATAFU-47 https://issues.apache.org/jira/browse/DATAFU-47 -- make sure to apply the patch from DATAFU-46 too first
>
> Questions for reviewers:
>
> * If we upgrade Guava, we'd get sip24 (a fast cryptographically secure hash), crc32 and adler32 (occasionally useful checksums). I can put the update in as another patch. Should we upgrade?
> * This UDF provides the same hashes as MD5 and SHA udfs. Should those be deprecated in favor of this? I can add the binhex functionality so that nothing is lost.
> * If there's a standard way to do the dependency injection of a fixed random number generator for the tests please advise.
>
>
> Diffs
> -----
>
> datafu-pig/src/main/java/datafu/pig/hash/Hasher.java PRE-CREATION
> datafu-pig/src/test/java/datafu/test/pig/hash/HashTests.java 7ff8fb9
>
> Diff: https://reviews.apache.org/r/21618/diff/
>
>
> Testing
> -------
>
> ./gradlew :datafu-pig:test -Dtest.single=HashTests
>
>
> Thanks,
>
> Philip (flip) Kromer
>
>
Re: Review Request 21618: DATAFU-47 UDF for Murmur3 (and other) Hash
functions
Posted by Eyal Allweil via Review Board <no...@reviews.apache.org>.
> On July 14, 2014, 8:43 p.m., Matthew Hayes wrote:
> > datafu-pig/src/main/java/datafu/pig/hash/Hasher.java
> > Lines 90 (patched)
> > <https://reviews.apache.org/r/21618/diff/3/?file=584924#file584924line90>
> >
> > Shouldn't this be like below instead?
> >
> > this("murmur3-32")
Fixed - looks like the default Guava constructor uses this value anyway.
> On July 14, 2014, 8:43 p.m., Matthew Hayes wrote:
> > datafu-pig/src/main/java/datafu/pig/hash/Hasher.java
> > Lines 126 (patched)
> > <https://reviews.apache.org/r/21618/diff/3/?file=584924#file584924line126>
> >
> > Comment is wrong. There is no seed.
I removed the mention of the seed in the comment.
> On July 14, 2014, 8:43 p.m., Matthew Hayes wrote:
> > datafu-pig/src/main/java/datafu/pig/hash/Hasher.java
> > Lines 190 (patched)
> > <https://reviews.apache.org/r/21618/diff/3/?file=584924#file584924line190>
> >
> > remove extra line
Removed.
> On July 14, 2014, 8:43 p.m., Matthew Hayes wrote:
> > datafu-pig/src/main/java/datafu/pig/hash/Hasher.java
> > Lines 193 (patched)
> > <https://reviews.apache.org/r/21618/diff/3/?file=584924#file584924line193>
> >
> > Error includes all hash functions, where here it should only include those that take seeds.
Error message changed.
> On July 14, 2014, 8:43 p.m., Matthew Hayes wrote:
> > datafu-pig/src/main/java/datafu/pig/hash/HasherRand.java
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/21618/diff/3/?file=584925#file584925line30>
> >
> > Needs doc string, which should distinguish this from Hasher.
I changed the javadoc a bit, and added a reference to Hasher to make it easier to understand.
> On July 14, 2014, 8:43 p.m., Matthew Hayes wrote:
> > datafu-pig/src/main/java/datafu/pig/hash/HasherRand.java
> > Lines 46 (patched)
> > <https://reviews.apache.org/r/21618/diff/3/?file=584925#file584925line46>
> >
> > Should we have a default constructor of murmur3-32 like Hasher?
Added one. Makes sense to me.
- Eyal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21618/#review47722
-----------------------------------------------------------
On May 20, 2014, 12:19 p.m., Philip (flip) Kromer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21618/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 12:19 p.m.)
>
>
> Review request for DataFu and Matthew Hayes.
>
>
> Bugs: DATAFU-47
> https://issues.apache.org/jira/browse/DATAFU-47
>
>
> Repository: datafu
>
>
> Description
> -------
>
> Accompanies DATAFU-47 https://issues.apache.org/jira/browse/DATAFU-47 -- make sure to apply the patch from DATAFU-46 too first
>
> Questions for reviewers:
>
> * If we upgrade Guava, we'd get sip24 (a fast cryptographically secure hash), crc32 and adler32 (occasionally useful checksums). I can put the update in as another patch. Should we upgrade?
> * This UDF provides the same hashes as MD5 and SHA udfs. Should those be deprecated in favor of this? I can add the binhex functionality so that nothing is lost.
> * If there's a standard way to do the dependency injection of a fixed random number generator for the tests please advise.
>
>
> Diffs
> -----
>
> datafu-pig/src/main/java/datafu/pig/hash/Hasher.java PRE-CREATION
> datafu-pig/src/main/java/datafu/pig/hash/HasherRand.java PRE-CREATION
> datafu-pig/src/test/java/datafu/test/pig/hash/HashTests.java 7ff8fb9
> datafu-pig/src/test/java/datafu/test/pig/hash/HasherRandForTesting.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/21618/diff/3/
>
>
> Testing
> -------
>
> ./gradlew :datafu-pig:test -Dtest.single=HashTests
>
>
> Thanks,
>
> Philip (flip) Kromer
>
>
Re: Review Request 21618: DATAFU-47 UDF for Murmur3 (and other) Hash
functions
Posted by Matthew Hayes <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21618/#review47722
-----------------------------------------------------------
Sorry for the delay in reviewing this, it fell off my radar. I like how you've created a separate UDF for random hashing. Overall this is looking pretty good to me.
By the way, the HashTests doesn't apply cleanly now (according to RB at least). Can you try updating the patch? Maybe there were some other changes to this file since you submitted the change.
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java
<https://reviews.apache.org/r/21618/#comment83897>
Shouldn't this be like below instead?
this("murmur3-32")
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java
<https://reviews.apache.org/r/21618/#comment83898>
Comment is wrong. There is no seed.
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java
<https://reviews.apache.org/r/21618/#comment83899>
remove extra line
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java
<https://reviews.apache.org/r/21618/#comment83900>
Error includes all hash functions, where here it should only include those that take seeds.
datafu-pig/src/main/java/datafu/pig/hash/HasherRand.java
<https://reviews.apache.org/r/21618/#comment83901>
Needs doc string, which should distinguish this from Hasher.
datafu-pig/src/main/java/datafu/pig/hash/HasherRand.java
<https://reviews.apache.org/r/21618/#comment83902>
Should we have a default constructor of murmur3-32 like Hasher?
- Matthew Hayes
On May 20, 2014, 9:19 a.m., Philip (flip) Kromer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21618/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 9:19 a.m.)
>
>
> Review request for DataFu and Matthew Hayes.
>
>
> Bugs: DATAFU-47
> https://issues.apache.org/jira/browse/DATAFU-47
>
>
> Repository: datafu
>
>
> Description
> -------
>
> Accompanies DATAFU-47 https://issues.apache.org/jira/browse/DATAFU-47 -- make sure to apply the patch from DATAFU-46 too first
>
> Questions for reviewers:
>
> * If we upgrade Guava, we'd get sip24 (a fast cryptographically secure hash), crc32 and adler32 (occasionally useful checksums). I can put the update in as another patch. Should we upgrade?
> * This UDF provides the same hashes as MD5 and SHA udfs. Should those be deprecated in favor of this? I can add the binhex functionality so that nothing is lost.
> * If there's a standard way to do the dependency injection of a fixed random number generator for the tests please advise.
>
>
> Diffs
> -----
>
> datafu-pig/src/main/java/datafu/pig/hash/Hasher.java PRE-CREATION
> datafu-pig/src/main/java/datafu/pig/hash/HasherRand.java PRE-CREATION
> datafu-pig/src/test/java/datafu/test/pig/hash/HashTests.java 7ff8fb9
> datafu-pig/src/test/java/datafu/test/pig/hash/HasherRandForTesting.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21618/diff/
>
>
> Testing
> -------
>
> ./gradlew :datafu-pig:test -Dtest.single=HashTests
>
>
> Thanks,
>
> Philip (flip) Kromer
>
>
Re: Review Request 21618: DATAFU-47 UDF for Murmur3 (and other) Hash
functions
Posted by "Philip (flip) Kromer" <fl...@infochimps.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21618/
-----------------------------------------------------------
(Updated May 20, 2014, 9:19 a.m.)
Review request for DataFu and Matthew Hayes.
Changes
-------
* Updated to address the comments below.
* The random variants are in a separate UDF "HasherRand" -- the dominant case is that we can create the hash func in constructor, and so making everyone check that the hash function is there on every call seems silly.
** Is there a method I can hook into that happens on the backend and before any call to exec() is made?
* Uses the change in DATAFU-50
* Made the no-args default constructor return a murmur3-32 instance, rather than good-32. The "different on every run" behavior is too surprising to make it be the default; and those who don't read the docs will value speed over anorak considerations.
I'm aware that I have a strong Ruby accent when speaking Java, so if there are more natural ways of accomplishing this please advise.
Bugs: DATAFU-47
https://issues.apache.org/jira/browse/DATAFU-47
Repository: datafu
Description
-------
Accompanies DATAFU-47 https://issues.apache.org/jira/browse/DATAFU-47 -- make sure to apply the patch from DATAFU-46 too first
Questions for reviewers:
* If we upgrade Guava, we'd get sip24 (a fast cryptographically secure hash), crc32 and adler32 (occasionally useful checksums). I can put the update in as another patch. Should we upgrade?
* This UDF provides the same hashes as MD5 and SHA udfs. Should those be deprecated in favor of this? I can add the binhex functionality so that nothing is lost.
* If there's a standard way to do the dependency injection of a fixed random number generator for the tests please advise.
Diffs (updated)
-----
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java PRE-CREATION
datafu-pig/src/main/java/datafu/pig/hash/HasherRand.java PRE-CREATION
datafu-pig/src/test/java/datafu/test/pig/hash/HashTests.java 7ff8fb9
datafu-pig/src/test/java/datafu/test/pig/hash/HasherRandForTesting.java PRE-CREATION
Diff: https://reviews.apache.org/r/21618/diff/
Testing
-------
./gradlew :datafu-pig:test -Dtest.single=HashTests
Thanks,
Philip (flip) Kromer
Re: Review Request 21618: DATAFU-47 UDF for Murmur3 (and other) Hash
functions
Posted by "Philip (flip) Kromer" <fl...@infochimps.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21618/
-----------------------------------------------------------
(Updated May 19, 2014, 11:12 p.m.)
Review request for DataFu and Matthew Hayes.
Bugs: DATAFU-47
https://issues.apache.org/jira/browse/DATAFU-47
Repository: datafu
Description
-------
Accompanies DATAFU-47 https://issues.apache.org/jira/browse/DATAFU-47 -- make sure to apply the patch from DATAFU-46 too first
Questions for reviewers:
* If we upgrade Guava, we'd get sip24 (a fast cryptographically secure hash), crc32 and adler32 (occasionally useful checksums). I can put the update in as another patch. Should we upgrade?
* This UDF provides the same hashes as MD5 and SHA udfs. Should those be deprecated in favor of this? I can add the binhex functionality so that nothing is lost.
* If there's a standard way to do the dependency injection of a fixed random number generator for the tests please advise.
Diffs (updated)
-----
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java PRE-CREATION
datafu-pig/src/test/java/datafu/test/pig/hash/HashTests.java 7ff8fb9
Diff: https://reviews.apache.org/r/21618/diff/
Testing
-------
./gradlew :datafu-pig:test -Dtest.single=HashTests
Thanks,
Philip (flip) Kromer
Re: Review Request 21618: DATAFU-47 UDF for Murmur3 (and other) Hash
functions
Posted by "Philip (flip) Kromer" <fl...@infochimps.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21618/
-----------------------------------------------------------
(Updated May 19, 2014, 2:17 a.m.)
Review request for DataFu and Matthew Hayes.
Bugs: DATAFU-47
https://issues.apache.org/jira/browse/DATAFU-47
Repository: datafu
Description (updated)
-------
Accompanies DATAFU-47 https://issues.apache.org/jira/browse/DATAFU-47 -- make sure to apply the patch from DATAFU-46 too first
Questions for reviewers:
* If we upgrade Guava, we'd get sip24 (a fast cryptographically secure hash), crc32 and adler32 (occasionally useful checksums). I can put the update in as another patch. Should we upgrade?
* This UDF provides the same hashes as MD5 and SHA udfs. Should those be deprecated in favor of this? I can add the binhex functionality so that nothing is lost.
* If there's a standard way to do the dependency injection of a fixed random number generator for the tests please advise.
Diffs
-----
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java PRE-CREATION
datafu-pig/src/test/java/datafu/test/pig/hash/HashTests.java f422e39
Diff: https://reviews.apache.org/r/21618/diff/
Testing
-------
./gradlew :datafu-pig:test -Dtest.single=HashTests
Thanks,
Philip (flip) Kromer
Re: Review Request 21618: DATAFU-47 UDF for Murmur3 (and other) Hash
functions
Posted by "Philip (flip) Kromer" <fl...@infochimps.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21618/
-----------------------------------------------------------
(Updated May 19, 2014, 2:11 a.m.)
Review request for DataFu and Matthew Hayes.
Bugs: DATAFU-47
https://issues.apache.org/jira/browse/DATAFU-47
Repository: datafu
Description
-------
Accompanies DATAFU-47 https://issues.apache.org/jira/browse/DATAFU-47 -- make sure to apply the patch from DATAFU-46 too first
Diffs
-----
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java PRE-CREATION
datafu-pig/src/test/java/datafu/test/pig/hash/HashTests.java f422e39
Diff: https://reviews.apache.org/r/21618/diff/
Testing
-------
./gradlew :datafu-pig:test -Dtest.single=HashTests
Thanks,
Philip (flip) Kromer
Re: Review Request 21618: DATAFU-47 UDF for Murmur3 (and other) Hash
functions
Posted by "Philip (flip) Kromer" <fl...@infochimps.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21618/
-----------------------------------------------------------
(Updated May 19, 2014, 2:11 a.m.)
Review request for DataFu and Matthew Hayes.
Repository: datafu
Description
-------
Accompanies DATAFU-47 https://issues.apache.org/jira/browse/DATAFU-47 -- make sure to apply the patch from DATAFU-46 too first
Diffs
-----
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java PRE-CREATION
datafu-pig/src/test/java/datafu/test/pig/hash/HashTests.java f422e39
Diff: https://reviews.apache.org/r/21618/diff/
Testing
-------
./gradlew :datafu-pig:test -Dtest.single=HashTests
Thanks,
Philip (flip) Kromer