[GitHub] [trafficserver] sudheerv edited a comment on pull request #7768: Short circuit remap reload when non-existent remap file is specified

[GitBox <gi...@apache.org>]

sudheerv edited a comment on pull request #7768:
URL: https://github.com/apache/trafficserver/pull/7768#issuecomment-832144171


   > Thinking more deeply on this and after a discussion with @sudheerv, I think the approach would be
   > 
   > * Remove the check on `UrlRewrite::load` from `init_reverse_proxy`.
   > * Change `UrlRewrite::load` to generate a `Warning` and fail on any failure to load "remap.config".
   > 
   > This would change startup behavior such that a missing "remap.config" would not prevent startup. As we've wanted to move toward fewer required files, I think this is a feature, not a bug. It would be consistent with the more general rule that has been adopted to treat a missing file as if it were an empty file. This would be detected (if the missing file is actually a problem) by 404 responses and the `Warning` in "diags.log".
   
   +1 . 
   
   That sounds reasonable, I just left the check in `init_reverse_proxy()` intact and changed the `Fatal` to `Warning` to allow for some local visibility to that method (even though, `UrlRewrite::load()` also prints a warning).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org