Re: svn commit: rev 3577 - trunk/ac-helpers

[Ben Collins-Sussman <su...@collab.net>]

sussman@tigris.org writes:

> Author: sussman
> Date: 2002-10-30 07:29:41 -0600 (Wed, 30 Oct 2002)
> New Revision: 3577
> 
> * berkeley-db.m4 
> 
>   (SVN_LIB_BERKELEY_DB):  put 'std' back as the first search location.
>   This should fix all the brokenness we were seeing on Debian, Redhat, etc.
> 
>   (SVN_LIB_BERKELEY_DB_TRY):  at Brane's excellent suggestion, check
>   that the version constants in db.h actually match the values that
>   the library gives from db_version().  This catches the FreeBSD
>   weirdness perfectly.

OK, so contrary to popular belief, svn 0.14.5 is NOT yet rolled or
released, because the berkeley-db detection still wasn't working last
night, which was the whole point of tossing 0.14.4.

So I'm asking for help:  will people please update to HEAD (at least
3577) and test this change above?  I want to know that Berkeley DB is
being found correctly on many different OSes.  It should work if you
pass no arguments to ./configure.  It should also work if you pass an
explicit location (--with-berkeley-db=FOO:BAR).

FWIW, this patch works fine on my FreeBSD 4.7 system:

checking for built-in Berkeley DB... no
checking for Berkeley DB in the standard places (as db4)... no
checking for Berkeley DB in the standard places (as db)... no
checking for Berkeley DB in /usr/local/include/db4 and /usr/local/lib (as db4)... yes

If this detection is working for everyone, then I'll bump the CHANGES
file again, and roll a real 0.14.5 tarball.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] In-tree DB 4.1 support - Re: svn commit: rev 3577 - trunk/ac-helpers

[Nuutti Kotivuori <na...@iki.fi>]

Nuutti Kotivuori wrote:
> No log message, but here's the patch.

Unless you've already realized - the patch is completely bogus. I
don't know what on earth was I thinking when I made it.

Please add this to the noise side.

-- Naked

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

[PATCH] In-tree DB 4.1 support - Re: svn commit: rev 3577 - trunk/ac-helpers

[Nuutti Kotivuori <na...@iki.fi>]

Ben Collins-Sussman wrote:
> If this detection is working for everyone, then I'll bump the
> CHANGES file again, and roll a real 0.14.5 tarball.

Yes, the detection seems to be working perfectly, atleast for me.

But, the one thing that still seems awry (that was indeed mentioned
before) is that an in-tree Berkeley DB 4.1 will not work.

So I made a patch to make it work - I've tested this with both 4.0 and
4.1, with --disable-shared and without. The change is ofcourse trivial
:-)

I'm not sure if this is the correct way to do the change - but since
there's no version checks what so ever performed with an in-tree
Berkeley DB, I think it's quite OK to just try and find some library
to link against.

No log message, but here's the patch.

-- Naked

Index: ac-helpers/berkeley-db.m4
===================================================================
--- ac-helpers/berkeley-db.m4   (revision 3577)
+++ ac-helpers/berkeley-db.m4   (working copy)
@@ -105,7 +105,7 @@
     # Linking directly to the .la is broken with --disable-shared
     # because Berkeley db does not seem to generate a .la library.
     if test "$enable_shared" = "yes"; then
-        SVN_DB_LIBS="$dbdir/libdb-4.0.la"
+        SVN_DB_LIBS="$dbdir/libdb"*".la"
     else
         SVN_DB_LIBS="-L$dbdir -ldb" # ignoring $db_libname here on purpose.
     fi


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 3577 - trunk/ac-helpers

[Philip Martin <ph...@codematters.co.uk>]

Ben Collins-Sussman <su...@collab.net> writes:

> So I'm asking for help:  will people please update to HEAD (at least
> 3577) and test this change above?  I want to know that Berkeley DB is
> being found correctly on many different OSes.  It should work if you
> pass no arguments to ./configure.  It should also work if you pass an
> explicit location (--with-berkeley-db=FOO:BAR).

I have a Debian Linux box with BDB 4.1 installed from a tarball in a
"non-standard" location, namely /usr/local/db4.  Detection works if I
give a --with-berkeley-db, and without the --with-berkeley-db there is
no detection which I believe is correct.

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org