[GitHub] [spark] shivsood commented on a change in pull request #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

[GitBox <gi...@apache.org>]

shivsood commented on a change in pull request #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect
URL: https://github.com/apache/spark/pull/25344#discussion_r310790976
 
 

 ##########
 File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MsSqlServerIntegrationSuite.scala
 ##########
 @@ -202,4 +205,32 @@ class MsSqlServerIntegrationSuite extends DockerJDBCIntegrationSuite {
     df2.write.jdbc(jdbcUrl, "datescopy", new Properties)
     df3.write.jdbc(jdbcUrl, "stringscopy", new Properties)
   }
+
+  def create_df() : DataFrame = {
+    val tableSchema = StructType(Seq(
+      StructField("serialNum",ByteType,true)
+    ))
+
+    val tableData = Seq (
+      Row(10)
+    )
+
+    spark.createDataFrame(spark.sparkContext.parallelize(tableData),tableSchema)
+  }
+
+  test("SPARK-28151 Test write table with BYTETYPE") {
+    val df1 = create_df()
+    df1.write
+      .format("jdbc")
+      .mode("overwrite")
+      .option("url",jdbcUrl)
+      .option("dbtable","testTable")
 
 Review comment:
   fixed. Sorry about this. I realize dev/stylecheck should be run manually for test cases. I presumed its get run automatically when i build. Apparently not for test code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org