You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/12/07 22:33:41 UTC
Review Request 64429: Fixed skipping of completed frameworks in the
master failover benchmark.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64429/
-----------------------------------------------------------
Review request for mesos and Jiang Yan Xu.
Repository: mesos
Description
-------
This benchmark was previously accidentally skipping the completed
frameworks, due to an incorrect loop.
Diffs
-----
src/tests/master_benchmarks.cpp 6c3a8e514a452f68a0b420b98f5af0dccb01ab68
Diff: https://reviews.apache.org/r/64429/diff/1/
Testing
-------
Ran the benchmark
Thanks,
Benjamin Mahler
Re: Review Request 64429: Fixed skipping of completed frameworks in
the master failover benchmark.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64429/#review193192
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On Dec. 7, 2017, 2:33 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64429/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 2:33 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This benchmark was previously accidentally skipping the completed
> frameworks, due to an incorrect loop.
>
>
> Diffs
> -----
>
> src/tests/master_benchmarks.cpp 6c3a8e514a452f68a0b420b98f5af0dccb01ab68
>
>
> Diff: https://reviews.apache.org/r/64429/diff/1/
>
>
> Testing
> -------
>
> Ran the benchmark
>
>
> Thanks,
>
> Benjamin Mahler
>
>