You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/09/02 21:31:30 UTC
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 7:31 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8
src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37172/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/#review97524
-----------------------------------------------------------
Ship it!
LGTM.
(And I think BenH's issue is no longer present either.)
- Joseph Wu
On Sept. 2, 2015, 12:31 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37172/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 12:31 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
>
> Diff: https://reviews.apache.org/r/37172/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/#review98796
-----------------------------------------------------------
Ship it!
Still looks good to me, but let's not forget the v1 API additions too please!
- Benjamin Hindman
On Sept. 13, 2015, 8:32 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37172/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 8:32 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8
> src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
>
> Diff: https://reviews.apache.org/r/37172/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 12:25 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Changes
-------
Added comparison operators to v1 api.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8
include/mesos/v1/mesos.hpp 0d695f36558fdc390461a8767a0c9db8e321a07a
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37172/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/
-----------------------------------------------------------
(Updated Sept. 13, 2015, 8:32 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37172/diff/
Testing
-------
Thanks,
Joris Van Remoortere