You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by ja...@apache.org on 2017/05/13 00:36:02 UTC

[20/26] geode git commit: GEODE-2876: add logging and testing to diagnose test failure

GEODE-2876: add logging and testing to diagnose test failure


Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/f88141cf
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/f88141cf
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/f88141cf

Branch: refs/heads/feature/GEODE-2900
Commit: f88141cfce57adef3171380db1c13bf1e61aaa1d
Parents: 5b122c7
Author: Jinmei Liao <ji...@pivotal.io>
Authored: Tue May 9 08:28:28 2017 -0700
Committer: Jinmei Liao <ji...@pivotal.io>
Committed: Thu May 11 16:05:08 2017 -0700

----------------------------------------------------------------------
 .../org/apache/geode/management/internal/cli/GfshParser.java  | 3 +--
 .../management/internal/cli/GfshParserIntegrationTest.java    | 7 +++++++
 2 files changed, 8 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/geode/blob/f88141cf/geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java b/geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
index 27ced23..bc4db16 100755
--- a/geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
+++ b/geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
@@ -180,10 +180,9 @@ public class GfshParser extends SimpleParser {
 
   @Override
   public GfshParseResult parse(String userInput) {
-    logger.info("parser user input: <" + userInput + ">");
+    logger.debug("parser user input: <" + userInput + ">");
     String rawInput = convertToSimpleParserInput(userInput);
 
-    logger.info("parser raw input: <" + rawInput + ">");
     // User SimpleParser to parse the input
     ParseResult result = super.parse(rawInput);
 

http://git-wip-us.apache.org/repos/asf/geode/blob/f88141cf/geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserIntegrationTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserIntegrationTest.java b/geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserIntegrationTest.java
index a467b34..1685be6 100644
--- a/geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserIntegrationTest.java
+++ b/geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserIntegrationTest.java
@@ -476,6 +476,13 @@ public class GfshParserIntegrationTest {
     assertThat(memberIdValue).isNull();
   }
 
+  @Test
+  public void testDeployCommand() throws Exception {
+    String command = "deploy --jar=/tmp/junit7552412945092669041/jar1.jar";
+    GfshParseResult result = parser.parse(command);
+    assertThat(result).isNotNull();
+  }
+
   private String getCompleted(String buffer, int cursor, Completion completed) {
     return buffer.substring(0, cursor) + completed.getValue();
   }