You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/14 06:26:52 UTC

[GitHub] [incubator-doris] kangkaisen opened a new pull request #2902: bitmap_union_count support window function

kangkaisen opened a new pull request #2902: bitmap_union_count support window function
URL: https://github.com/apache/incubator-doris/pull/2902
 
 
   For https://github.com/apache/incubator-doris/issues/2901
   
   1. Make bitmap_union_count support window function
   2. Fix bitmap insert into bug

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] kangkaisen commented on issue #2902: bitmap_union_count support window function

Posted by GitBox <gi...@apache.org>.
kangkaisen commented on issue #2902: bitmap_union_count support window function
URL: https://github.com/apache/incubator-doris/pull/2902#issuecomment-586809826
 
 
   > How about adding a unit test for `bitmap_union_count()` window function?
   I will add a UT for `bitmap_get_value`, But If we want to test a window function, I think we need to test `analytic_eval_node`, but we don't have UT for `analytic_eval_node`. I think we could test window function in integration testing in the future.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman commented on a change in pull request #2902: bitmap_union_count support window function

Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #2902: bitmap_union_count support window function
URL: https://github.com/apache/incubator-doris/pull/2902#discussion_r379903105
 
 

 ##########
 File path: be/src/exprs/bitmap_function.h
 ##########
 @@ -46,6 +46,9 @@ class BitmapFunctions {
     // the input src's ptr need to point a BitmapValue, this function will release the
     // BitmapValue memory
     static BigIntVal bitmap_finalize(FunctionContext* ctx, const StringVal& src);
+    // Get the bitmap cardinality, the difference from bitmap_finalize method is
+    // bitmap_get_value method doesn't free memory
+    static BigIntVal bitmap_get_value(FunctionContext* ctx, const StringVal& src);
 
 Review comment:
   How about `bitmap_get_cardinality` ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman commented on a change in pull request #2902: bitmap_union_count support window function

Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #2902: bitmap_union_count support window function
URL: https://github.com/apache/incubator-doris/pull/2902#discussion_r380231664
 
 

 ##########
 File path: be/src/exprs/bitmap_function.h
 ##########
 @@ -46,6 +46,9 @@ class BitmapFunctions {
     // the input src's ptr need to point a BitmapValue, this function will release the
     // BitmapValue memory
     static BigIntVal bitmap_finalize(FunctionContext* ctx, const StringVal& src);
+    // Get the bitmap cardinality, the difference from bitmap_finalize method is
+    // bitmap_get_value method doesn't free memory
+    static BigIntVal bitmap_get_value(FunctionContext* ctx, const StringVal& src);
 
 Review comment:
   OK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] kangkaisen commented on issue #2902: bitmap_union_count support window function

Posted by GitBox <gi...@apache.org>.
kangkaisen commented on issue #2902: bitmap_union_count support window function
URL: https://github.com/apache/incubator-doris/pull/2902#issuecomment-587249112
 
 
   Update, only fix the conflict.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2902: bitmap_union_count support window function

Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #2902: bitmap_union_count support window function
URL: https://github.com/apache/incubator-doris/pull/2902#discussion_r379979832
 
 

 ##########
 File path: be/src/exprs/bitmap_function.h
 ##########
 @@ -46,6 +46,9 @@ class BitmapFunctions {
     // the input src's ptr need to point a BitmapValue, this function will release the
     // BitmapValue memory
     static BigIntVal bitmap_finalize(FunctionContext* ctx, const StringVal& src);
+    // Get the bitmap cardinality, the difference from bitmap_finalize method is
+    // bitmap_get_value method doesn't free memory
+    static BigIntVal bitmap_get_value(FunctionContext* ctx, const StringVal& src);
 
 Review comment:
   If fact, `bitmap_finalize` and `bitmap_get_value` both compute bitmap cardinality, like `hll_finalize` and `hll_get_value`.  Use `get_value` as function name, because I want the fucntion name keep consistent with `_get_value_fn` in BE `AggFnEvaluator` and `getValueFnSymbol` in FE `AggregateFunction`.
   
   I will update the comment to emphasize this point.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] kangkaisen merged pull request #2902: bitmap_union_count support window function

Posted by GitBox <gi...@apache.org>.
kangkaisen merged pull request #2902: bitmap_union_count support window function
URL: https://github.com/apache/incubator-doris/pull/2902
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] kangkaisen edited a comment on issue #2902: bitmap_union_count support window function

Posted by GitBox <gi...@apache.org>.
kangkaisen edited a comment on issue #2902: bitmap_union_count support window function
URL: https://github.com/apache/incubator-doris/pull/2902#issuecomment-586809826
 
 
   > How about adding a unit test for `bitmap_union_count()` window function?
   
   I will add a UT for `bitmap_get_value`, But If we want to test a window function, I think we need to test `analytic_eval_node`, but we don't have UT for `analytic_eval_node`. I think we could test window function in integration testing in the future.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org