You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Andrew Jorgensen <an...@andrewjorgensen.com> on 2015/07/21 19:00:09 UTC
Review Request 36644: Updates debian rules to use different
thermos_observer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36644/
-----------------------------------------------------------
Review request for Aurora, Benjamin Staffin, Brian Wickman, and Zameer Manji.
Bugs: AURORA-1403
https://issues.apache.org/jira/browse/AURORA-1403
Repository: aurora
Description
-------
The old thermos_observer is missing the --mesos-root flag thats needed
to tell the thermos_observer where it can find the mesos root directory.
It currently defaults to /var/lib/mesos in the old observer entry point.
Diffs
-----
build-support/packaging/debian/rules db0f14ebd0493e47b839e33ee0f408c516fab0e1
Diff: https://reviews.apache.org/r/36644/diff/
Testing
-------
Thanks,
Andrew Jorgensen
Re: Review Request 36644: Updates debian rules to use different
thermos_observer
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36644/#review92433
-----------------------------------------------------------
Ship it!
Master (838a96e) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 21, 2015, 5:02 p.m., Andrew Jorgensen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36644/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 5:02 p.m.)
>
>
> Review request for Aurora, Benjamin Staffin, Brian Wickman, and Zameer Manji.
>
>
> Bugs: AURORA-1403
> https://issues.apache.org/jira/browse/AURORA-1403
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The old thermos_observer is missing the --mesos-root flag thats needed
> to tell the thermos_observer where it can find the mesos root directory.
> It currently defaults to /var/lib/mesos in the old observer entry point.
>
>
> Diffs
> -----
>
> build-support/packaging/debian/rules db0f14ebd0493e47b839e33ee0f408c516fab0e1
>
> Diff: https://reviews.apache.org/r/36644/diff/
>
>
> Testing
> -------
>
> 1. Built aurora with dpkg-buildpackage -us -uc -d
> 2. Installed executor deb: dpkg --install aurora-executor_0.9.0-SNAPSHOT_amd64.deb
> 3. thermos_observer --long-help
> Options:
> -h, --help, --short-help
> show this help message and exit.
> --long-help show options from all registered modules, not just the
> __main__ module.
> --root=ROOT The thermos checkpoint root directory to search for
> Thermos tasks [default: /var/run/thermos]
> --mesos-root=MESOS_ROOT
> The mesos root directory to search for Thermos
> executor sandboxes [default: /var/lib/mesos]
> --port=PORT The port on which the observer should listen.
> [default: 1338]
> --polling_interval_secs=POLLING_INTERVAL_SECS
> The number of seconds between observer refresh
> attempts. [default: 5]
>
> I am in the process of building and deploying this change to production and can report back when that is complete.
>
>
> Thanks,
>
> Andrew Jorgensen
>
>
Re: Review Request 36644: Updates debian rules to use different
thermos_observer
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36644/#review92469
-----------------------------------------------------------
Ship it!
Thanks for catching and patching this!
- Bill Farner
On July 21, 2015, 5:02 p.m., Andrew Jorgensen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36644/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 5:02 p.m.)
>
>
> Review request for Aurora, Benjamin Staffin, Brian Wickman, and Zameer Manji.
>
>
> Bugs: AURORA-1403
> https://issues.apache.org/jira/browse/AURORA-1403
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The old thermos_observer is missing the --mesos-root flag thats needed
> to tell the thermos_observer where it can find the mesos root directory.
> It currently defaults to /var/lib/mesos in the old observer entry point.
>
>
> Diffs
> -----
>
> build-support/packaging/debian/rules db0f14ebd0493e47b839e33ee0f408c516fab0e1
>
> Diff: https://reviews.apache.org/r/36644/diff/
>
>
> Testing
> -------
>
> 1. Built aurora with dpkg-buildpackage -us -uc -d
> 2. Installed executor deb: dpkg --install aurora-executor_0.9.0-SNAPSHOT_amd64.deb
> 3. thermos_observer --long-help
> Options:
> -h, --help, --short-help
> show this help message and exit.
> --long-help show options from all registered modules, not just the
> __main__ module.
> --root=ROOT The thermos checkpoint root directory to search for
> Thermos tasks [default: /var/run/thermos]
> --mesos-root=MESOS_ROOT
> The mesos root directory to search for Thermos
> executor sandboxes [default: /var/lib/mesos]
> --port=PORT The port on which the observer should listen.
> [default: 1338]
> --polling_interval_secs=POLLING_INTERVAL_SECS
> The number of seconds between observer refresh
> attempts. [default: 5]
>
> I am in the process of building and deploying this change to production and can report back when that is complete.
>
>
> Thanks,
>
> Andrew Jorgensen
>
>
Re: Review Request 36644: Updates debian rules to use different
thermos_observer
Posted by Andrew Jorgensen <an...@andrewjorgensen.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36644/
-----------------------------------------------------------
(Updated July 21, 2015, 5:02 p.m.)
Review request for Aurora, Benjamin Staffin, Brian Wickman, and Zameer Manji.
Bugs: AURORA-1403
https://issues.apache.org/jira/browse/AURORA-1403
Repository: aurora
Description
-------
The old thermos_observer is missing the --mesos-root flag thats needed
to tell the thermos_observer where it can find the mesos root directory.
It currently defaults to /var/lib/mesos in the old observer entry point.
Diffs
-----
build-support/packaging/debian/rules db0f14ebd0493e47b839e33ee0f408c516fab0e1
Diff: https://reviews.apache.org/r/36644/diff/
Testing (updated)
-------
1. Built aurora with dpkg-buildpackage -us -uc -d
2. Installed executor deb: dpkg --install aurora-executor_0.9.0-SNAPSHOT_amd64.deb
3. thermos_observer --long-help
Options:
-h, --help, --short-help
show this help message and exit.
--long-help show options from all registered modules, not just the
__main__ module.
--root=ROOT The thermos checkpoint root directory to search for
Thermos tasks [default: /var/run/thermos]
--mesos-root=MESOS_ROOT
The mesos root directory to search for Thermos
executor sandboxes [default: /var/lib/mesos]
--port=PORT The port on which the observer should listen.
[default: 1338]
--polling_interval_secs=POLLING_INTERVAL_SECS
The number of seconds between observer refresh
attempts. [default: 5]
I am in the process of building and deploying this change to production and can report back when that is complete.
Thanks,
Andrew Jorgensen