You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Ulrich Stärk (JIRA)" <de...@tapestry.apache.org> on 2007/11/12 13:59:50 UTC
[jira] Created: (TAPESTRY-1906) DropdownDatePicker and
DropdownTimePicker overwrite html tag used in template
DropdownDatePicker and DropdownTimePicker overwrite html tag used in template
-----------------------------------------------------------------------------
Key: TAPESTRY-1906
URL: https://issues.apache.org/jira/browse/TAPESTRY-1906
Project: Tapestry
Issue Type: Bug
Components: Core Components, XHR/dhtml/Ajax
Affects Versions: 4.1.3
Reporter: Ulrich Stärk
Fix For: 4.1.4
The DropdownDatePicker and DropdownTimePicker components overwrite the HTML tag specified in the page template with <div>. Instead they should use the tag specified in the template.
DropdownTimePicker.java line 61:
writer.begin("div");
should be
writer.begin(getTemplateTagName());
DropdownDatePicker.java line 75:
writer.begin("div");
should be
writer.begin(getTemplateTagName());
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Resolved: (TAPESTRY-1906) DropdownDatePicker and
DropdownTimePicker overwrite html tag used in template
Posted by "Andreas Andreou (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Andreou resolved TAPESTRY-1906.
---------------------------------------
Resolution: Fixed
Done, but not for the original requested reason ( it's not difficult to fix styling in other ways... )
I just found out that using input as template tag minimizes the popup flicker when dojo creates
the true input box.
> DropdownDatePicker and DropdownTimePicker overwrite html tag used in template
> -----------------------------------------------------------------------------
>
> Key: TAPESTRY-1906
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1906
> Project: Tapestry
> Issue Type: Bug
> Components: Core Components, XHR/dhtml/Ajax
> Affects Versions: 4.1.3
> Reporter: Ulrich Stärk
> Assignee: Andreas Andreou
> Fix For: 4.1.4
>
> Attachments: TAPESTRY-1906.txt
>
>
> The DropdownDatePicker and DropdownTimePicker components overwrite the HTML tag specified in the page template with <div>. Instead they should use the tag specified in the template.
> DropdownTimePicker.java line 61:
> writer.begin("div");
> should be
> writer.begin(getTemplateTagName());
> DropdownDatePicker.java line 75:
> writer.begin("div");
> should be
> writer.begin(getTemplateTagName());
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-1906) DropdownDatePicker and
DropdownTimePicker overwrite html tag used in template
Posted by "Ulrich Stärk (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ulrich Stärk updated TAPESTRY-1906:
-----------------------------------
Attachment: TAPESTRY-1906.txt
Attached a patch for this issue
> DropdownDatePicker and DropdownTimePicker overwrite html tag used in template
> -----------------------------------------------------------------------------
>
> Key: TAPESTRY-1906
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1906
> Project: Tapestry
> Issue Type: Bug
> Components: Core Components, XHR/dhtml/Ajax
> Affects Versions: 4.1.3
> Reporter: Ulrich Stärk
> Fix For: 4.1.4
>
> Attachments: TAPESTRY-1906.txt
>
>
> The DropdownDatePicker and DropdownTimePicker components overwrite the HTML tag specified in the page template with <div>. Instead they should use the tag specified in the template.
> DropdownTimePicker.java line 61:
> writer.begin("div");
> should be
> writer.begin(getTemplateTagName());
> DropdownDatePicker.java line 75:
> writer.begin("div");
> should be
> writer.begin(getTemplateTagName());
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1906) DropdownDatePicker and
DropdownTimePicker overwrite html tag used in template
Posted by "Ulrich Stärk (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546640 ]
Ulrich Stärk commented on TAPESTRY-1906:
----------------------------------------
No, I noticed that my Dropdown*Pickers were put on a new line although I specified a <span> element to be used as the anchor. When I inspected the DOM tree in Firefox I saw, that Dojo replaces the anchor element with a span element and I was even more puzzled because there shouldn't be a line break with a <span> element. It seems that Firefox (haven't tested IE or any other browser) puts the <div> element on a new line because it's a block element and leaves it there although it gets replaced with a <span> element (non-block) later on. So I either need to force the <div> elements to be non-block (display: inline) or even better make Tapestry use the HTML element I provide which in my case is <span>.
Uli
> DropdownDatePicker and DropdownTimePicker overwrite html tag used in template
> -----------------------------------------------------------------------------
>
> Key: TAPESTRY-1906
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1906
> Project: Tapestry
> Issue Type: Bug
> Components: Core Components, XHR/dhtml/Ajax
> Affects Versions: 4.1.3
> Reporter: Ulrich Stärk
> Assignee: Andreas Andreou
> Fix For: 4.1.4
>
> Attachments: TAPESTRY-1906.txt
>
>
> The DropdownDatePicker and DropdownTimePicker components overwrite the HTML tag specified in the page template with <div>. Instead they should use the tag specified in the template.
> DropdownTimePicker.java line 61:
> writer.begin("div");
> should be
> writer.begin(getTemplateTagName());
> DropdownDatePicker.java line 75:
> writer.begin("div");
> should be
> writer.begin(getTemplateTagName());
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1906) DropdownDatePicker and
DropdownTimePicker overwrite html tag used in template
Posted by "Andreas Andreou (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546453 ]
Andreas Andreou commented on TAPESTRY-1906:
-------------------------------------------
What kind of tag do you want to use with it?
I'm wondering, are you trying to make it look good with js disabled?
> DropdownDatePicker and DropdownTimePicker overwrite html tag used in template
> -----------------------------------------------------------------------------
>
> Key: TAPESTRY-1906
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1906
> Project: Tapestry
> Issue Type: Bug
> Components: Core Components, XHR/dhtml/Ajax
> Affects Versions: 4.1.3
> Reporter: Ulrich Stärk
> Fix For: 4.1.4
>
> Attachments: TAPESTRY-1906.txt
>
>
> The DropdownDatePicker and DropdownTimePicker components overwrite the HTML tag specified in the page template with <div>. Instead they should use the tag specified in the template.
> DropdownTimePicker.java line 61:
> writer.begin("div");
> should be
> writer.begin(getTemplateTagName());
> DropdownDatePicker.java line 75:
> writer.begin("div");
> should be
> writer.begin(getTemplateTagName());
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Assigned: (TAPESTRY-1906) DropdownDatePicker and
DropdownTimePicker overwrite html tag used in template
Posted by "Andreas Andreou (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Andreou reassigned TAPESTRY-1906:
-----------------------------------------
Assignee: Andreas Andreou
> DropdownDatePicker and DropdownTimePicker overwrite html tag used in template
> -----------------------------------------------------------------------------
>
> Key: TAPESTRY-1906
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1906
> Project: Tapestry
> Issue Type: Bug
> Components: Core Components, XHR/dhtml/Ajax
> Affects Versions: 4.1.3
> Reporter: Ulrich Stärk
> Assignee: Andreas Andreou
> Fix For: 4.1.4
>
> Attachments: TAPESTRY-1906.txt
>
>
> The DropdownDatePicker and DropdownTimePicker components overwrite the HTML tag specified in the page template with <div>. Instead they should use the tag specified in the template.
> DropdownTimePicker.java line 61:
> writer.begin("div");
> should be
> writer.begin(getTemplateTagName());
> DropdownDatePicker.java line 75:
> writer.begin("div");
> should be
> writer.begin(getTemplateTagName());
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org