You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/08 22:01:17 UTC
Review Request 64469: Added unit tests for resource provider config
modification API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64469/
-----------------------------------------------------------
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Repository: mesos
Description
-------
Added unit tests for resource provider config modification API.
Diffs
-----
include/mesos/type_utils.hpp 506f667073df9c4368354d07dcc012e5e0dd36f1
include/mesos/v1/mesos.hpp f393ed5654ad6d0b3eb5e28548c972779b082425
src/Makefile.am 1620b2aeaf5c84739bd0f969be80f1767a8703eb
src/resource_provider/manager.cpp f98611c351f11b15281dd3ef673ef80db1c44f07
src/tests/agent_resource_provider_config_api_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/64469/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 64469: Added unit tests for resource provider
config modification API.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64469/
-----------------------------------------------------------
(Updated Dec. 11, 2017, 10:44 p.m.)
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Changes
-------
Addressed Jie's comments.
Repository: mesos
Description
-------
Added unit tests for resource provider config modification API.
Diffs (updated)
-----
include/mesos/type_utils.hpp 506f667073df9c4368354d07dcc012e5e0dd36f1
include/mesos/v1/mesos.hpp f393ed5654ad6d0b3eb5e28548c972779b082425
src/Makefile.am 47f45284e32677ef60eb39835d551ff22244e861
src/resource_provider/manager.cpp f98611c351f11b15281dd3ef673ef80db1c44f07
src/tests/agent_resource_provider_config_api_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/64469/diff/2/
Changes: https://reviews.apache.org/r/64469/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 64469: Added unit tests for resource provider
config modification API.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64469/#review193440
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/agent_resource_provider_config_api_tests.cpp
Lines 221 (patched)
<https://reviews.apache.org/r/64469/#comment271984>
This requires ROOT
- Jie Yu
On Dec. 8, 2017, 10:01 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64469/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 10:01 p.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests for resource provider config modification API.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 506f667073df9c4368354d07dcc012e5e0dd36f1
> include/mesos/v1/mesos.hpp f393ed5654ad6d0b3eb5e28548c972779b082425
> src/Makefile.am 1620b2aeaf5c84739bd0f969be80f1767a8703eb
> src/resource_provider/manager.cpp f98611c351f11b15281dd3ef673ef80db1c44f07
> src/tests/agent_resource_provider_config_api_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64469/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>