You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/06 07:02:36 UTC
[GitHub] [camel] ramu11 opened a new pull request #4367: "CAMEL-15616:camel-saxon - Upgrade to Saxon 10.x"
ramu11 opened a new pull request #4367:
URL: https://github.com/apache/camel/pull/4367
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ramu11 commented on a change in pull request #4367: "CAMEL-15616:camel-saxon - Upgrade to Saxon 10.x"
Posted by GitBox <gi...@apache.org>.
ramu11 commented on a change in pull request #4367:
URL: https://github.com/apache/camel/pull/4367#discussion_r500149692
##########
File path: components/camel-saxon/pom.xml
##########
@@ -33,7 +33,7 @@
<properties>
<camel.osgi.import.additional>
- net.sf.saxon.*;version="[9.9.0,10)"
+ net.sf.saxon.*;version="[9.9.0,11)"
Review comment:
[10.0,10.3) means include 10.0,10.1,10.2 and exclude 10.3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a change in pull request #4367: "CAMEL-15616:camel-saxon - Upgrade to Saxon 10.x"
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #4367:
URL: https://github.com/apache/camel/pull/4367#discussion_r500212359
##########
File path: components/camel-saxon/pom.xml
##########
@@ -33,7 +33,7 @@
<properties>
<camel.osgi.import.additional>
- net.sf.saxon.*;version="[9.9.0,10)"
+ net.sf.saxon.*;version="[9.9.0,11)"
Review comment:
It doesn't makes sense to restrict to 10.3 the range. Use 11 as upper limit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a change in pull request #4367: "CAMEL-15616:camel-saxon - Upgrade to Saxon 10.x"
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #4367:
URL: https://github.com/apache/camel/pull/4367#discussion_r500236166
##########
File path: components/camel-saxon/pom.xml
##########
@@ -33,7 +33,7 @@
<properties>
<camel.osgi.import.additional>
- net.sf.saxon.*;version="[9.9.0,10)"
+ net.sf.saxon.*;version="[9.9.0,11)"
Review comment:
+1, it needs to be strict [10,11)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ramu11 commented on a change in pull request #4367: "CAMEL-15616:camel-saxon - Upgrade to Saxon 10.x"
Posted by GitBox <gi...@apache.org>.
ramu11 commented on a change in pull request #4367:
URL: https://github.com/apache/camel/pull/4367#discussion_r500220024
##########
File path: components/camel-saxon/pom.xml
##########
@@ -33,7 +33,7 @@
<properties>
<camel.osgi.import.additional>
- net.sf.saxon.*;version="[9.9.0,10)"
+ net.sf.saxon.*;version="[9.9.0,11)"
Review comment:
Thanks oscerd. then i think there is no need to change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ramu11 commented on a change in pull request #4367: "CAMEL-15616:camel-saxon - Upgrade to Saxon 10.x"
Posted by GitBox <gi...@apache.org>.
ramu11 commented on a change in pull request #4367:
URL: https://github.com/apache/camel/pull/4367#discussion_r500222519
##########
File path: components/camel-saxon/pom.xml
##########
@@ -33,7 +33,7 @@
<properties>
<camel.osgi.import.additional>
- net.sf.saxon.*;version="[9.9.0,10)"
+ net.sf.saxon.*;version="[9.9.0,11)"
Review comment:
I have already provided upper limit 11
net.sf.saxon.*;version="[9.9.0,11)"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ramu11 commented on a change in pull request #4367: "CAMEL-15616:camel-saxon - Upgrade to Saxon 10.x"
Posted by GitBox <gi...@apache.org>.
ramu11 commented on a change in pull request #4367:
URL: https://github.com/apache/camel/pull/4367#discussion_r500145294
##########
File path: components/camel-saxon/pom.xml
##########
@@ -33,7 +33,7 @@
<properties>
<camel.osgi.import.additional>
- net.sf.saxon.*;version="[9.9.0,10)"
+ net.sf.saxon.*;version="[9.9.0,11)"
Review comment:
@davsclaus can i keep only version 10
net.sf.saxon.*;version="[10.0,10.3)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #4367: "CAMEL-15616:camel-saxon - Upgrade to Saxon 10.x"
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #4367:
URL: https://github.com/apache/camel/pull/4367#discussion_r500118300
##########
File path: components/camel-saxon/pom.xml
##########
@@ -33,7 +33,7 @@
<properties>
<camel.osgi.import.additional>
- net.sf.saxon.*;version="[9.9.0,10)"
+ net.sf.saxon.*;version="[9.9.0,11)"
Review comment:
Those API changes later would mean that we require saxon 10, 11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #4367: "CAMEL-15616:camel-saxon - Upgrade to Saxon 10.x"
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #4367:
URL: https://github.com/apache/camel/pull/4367#discussion_r500224404
##########
File path: components/camel-saxon/pom.xml
##########
@@ -33,7 +33,7 @@
<properties>
<camel.osgi.import.additional>
- net.sf.saxon.*;version="[9.9.0,10)"
+ net.sf.saxon.*;version="[9.9.0,11)"
Review comment:
No it should be [10,11)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ramu11 closed pull request #4367: "CAMEL-15616:camel-saxon - Upgrade to Saxon 10.x"
Posted by GitBox <gi...@apache.org>.
ramu11 closed pull request #4367:
URL: https://github.com/apache/camel/pull/4367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org