[GitHub] [hbase] Apache-HBase commented on issue #566: HBASE-22380 break circle replication when doing bulkload

[GitBox <gi...@apache.org>]

Apache-HBase commented on issue #566: HBASE-22380 break circle replication when doing bulkload
URL: https://github.com/apache/hbase/pull/566#issuecomment-526933608
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 40 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 1 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 37 | Maven dependency ordering for branch |
   | +1 | mvninstall | 319 | master passed |
   | +1 | compile | 130 | master passed |
   | +1 | checkstyle | 130 | master passed |
   | +1 | shadedjars | 278 | branch has no errors when building our shaded downstream artifacts. |
   | +1 | javadoc | 73 | master passed |
   | 0 | spotbugs | 244 | Used deprecated FindBugs config; considering switching to SpotBugs. |
   | +1 | findbugs | 473 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 18 | Maven dependency ordering for patch |
   | +1 | mvninstall | 298 | the patch passed |
   | +1 | compile | 121 | the patch passed |
   | +1 | cc | 121 | the patch passed |
   | +1 | javac | 121 | the patch passed |
   | -1 | checkstyle | 89 | hbase-server: The patch generated 1 new + 283 unchanged - 0 fixed = 284 total (was 283) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 270 | patch has no errors when building our shaded downstream artifacts. |
   | +1 | hadoopcheck | 931 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
   | +1 | hbaseprotoc | 115 | the patch passed |
   | -1 | javadoc | 38 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
   | -1 | findbugs | 252 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 44 | hbase-protocol-shaded in the patch passed. |
   | +1 | unit | 110 | hbase-client in the patch passed. |
   | -1 | unit | 10313 | hbase-server in the patch failed. |
   | +1 | asflicense | 87 | The patch does not generate ASF License warnings. |
   | | | 14950 | |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hbase-server |
   |  |  org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator  At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator  At ReplicationSink.java:[line 258] |
   | Failed junit tests | hadoop.hbase.tool.TestBulkLoadHFilesSplitRecovery |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFilesSplitRecovery |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-566/4/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/566 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc |
   | uname | Linux 58cada9052c8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-566/out/precommit/personality/provided.sh |
   | git revision | master / 97fbaa658e |
   | Default Java | 1.8.0_181 |
   | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-566/4/artifact/out/diff-checkstyle-hbase-server.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-566/4/artifact/out/diff-javadoc-javadoc-hbase-server.txt |
   | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-566/4/artifact/out/new-findbugs-hbase-server.html |
   | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-566/4/artifact/out/patch-unit-hbase-server.txt |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-566/4/testReport/ |
   | Max. process+thread count | 4477 (vs. ulimit of 10000) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-566/4/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services