You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by jl...@apache.org on 2019/03/14 06:28:17 UTC
[incubator-pinot] branch helix-version-dummy created (now ff68c14)
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch helix-version-dummy
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at ff68c14 Add dummy job to force update task queue
This branch includes the following new commits:
new ff68c14 Add dummy job to force update task queue
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[incubator-pinot] 01/01: Add dummy job to force update task queue
Posted by jl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch helix-version-dummy
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit ff68c140cb01534c10d703691f9588ac1905ee9e
Author: jackjlli <jl...@linkedin.com>
AuthorDate: Wed Mar 13 23:27:51 2019 -0700
Add dummy job to force update task queue
---
.../controller/helix/core/minion/PinotTaskManager.java | 15 +++++++++++++++
.../pinot/minion/taskfactory/TaskFactoryRegistry.java | 6 ++++++
2 files changed, 21 insertions(+)
diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
index 6bb5c9d..1380e1e 100644
--- a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
+++ b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
@@ -33,6 +33,7 @@ import org.apache.pinot.controller.helix.core.PinotHelixResourceManager;
import org.apache.pinot.controller.helix.core.minion.generator.PinotTaskGenerator;
import org.apache.pinot.controller.helix.core.minion.generator.TaskGeneratorRegistry;
import org.apache.pinot.controller.helix.core.periodictask.ControllerPeriodicTask;
+import org.apache.pinot.core.common.MinionConstants;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -148,6 +149,20 @@ public class PinotTaskManager extends ControllerPeriodicTask<Void> {
}
}
+ // submit a dummy empty job here.
+
+ String taskType = taskTypes.iterator().next();
+ List<PinotTaskConfig> dummyJob = new ArrayList<>();
+ Map<String, String> configs = new HashMap<>();
+ configs.put(MinionConstants.TABLE_NAME_KEY, tableNamesWithType.get(0));
+ configs.put(MinionConstants.SEGMENT_NAME_KEY, "");
+ dummyJob.add(new PinotTaskConfig(taskType, configs));
+ _helixTaskResourceManager.submitTask(dummyJob, 1);
+// List<PinotTaskConfig> dummyJob = new ArrayList<>();
+// Map<String, String> configs = new HashMap<>();
+// dummyJob.add(new PinotTaskConfig(MinionConstants.ConvertToRawIndexTask.COLUMNS_TO_CONVERT_KEY, configs));
+// _helixTaskResourceManager.submitTask(dummyJob, 1);
+
return tasksScheduled;
}
diff --git a/pinot-minion/src/main/java/org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java b/pinot-minion/src/main/java/org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java
index 86d2a15..2fa7009 100644
--- a/pinot-minion/src/main/java/org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java
+++ b/pinot-minion/src/main/java/org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java
@@ -27,6 +27,7 @@ import org.apache.helix.task.TaskConfig;
import org.apache.helix.task.TaskFactory;
import org.apache.helix.task.TaskResult;
import org.apache.pinot.common.config.PinotTaskConfig;
+import org.apache.pinot.core.common.MinionConstants;
import org.apache.pinot.minion.MinionContext;
import org.apache.pinot.minion.events.EventObserverFactoryRegistry;
import org.apache.pinot.minion.events.MinionEventObserver;
@@ -73,6 +74,11 @@ public class TaskFactoryRegistry {
MinionMetrics minionMetrics = MinionContext.getInstance().getMinionMetrics();
PinotTaskConfig pinotTaskConfig = PinotTaskConfig.fromHelixTaskConfig(_taskConfig);
+ Map<String, String> configs = pinotTaskConfig.getConfigs();
+ // Dummy task.
+ if (configs.get(MinionConstants.DOWNLOAD_URL_KEY) == null && configs.get(MinionConstants.UPLOAD_URL_KEY) == null) {
+ return new TaskResult(TaskResult.Status.COMPLETED, "Succeeded");
+ }
_eventObserver.notifyTaskStart(pinotTaskConfig);
minionMetrics.addMeteredTableValue(taskType, MinionMeter.NUMBER_TASKS_EXECUTED, 1L);
LOGGER.info("Start running {}: {} with configs: {}", pinotTaskConfig.getTaskType(), _taskConfig.getId(),
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org