You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/01/31 18:35:56 UTC
[kudu-CR] util: move ListFilesInDir to env util
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9166
Change subject: util: move ListFilesInDir to env_util
......................................................................
util: move ListFilesInDir to env_util
ListFilesInDir() is useful outside of just inspecting external mini
clusters. This patch moves it into env_util.
Change-Id: I8372c13b28c3c3058322fc96b656ef71aa18fc0a
---
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.h
M src/kudu/integration-tests/multidir_cluster-itest.cc
M src/kudu/util/env_util.cc
M src/kudu/util/env_util.h
5 files changed, 32 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/9166/1
--
To view, visit http://gerrit.cloudera.org:8080/9166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8372c13b28c3c3058322fc96b656ef71aa18fc0a
Gerrit-Change-Number: 9166
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] util: move ListFilesInDir to env util
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9166 )
Change subject: util: move ListFilesInDir to env_util
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8372c13b28c3c3058322fc96b656ef71aa18fc0a
Gerrit-Change-Number: 9166
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 31 Jan 2018 19:42:06 +0000
Gerrit-HasComments: No
[kudu-CR] util: move ListFilesInDir to env util
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9166 )
Change subject: util: move ListFilesInDir to env_util
......................................................................
util: move ListFilesInDir to env_util
ListFilesInDir() is useful outside of just inspecting external mini
clusters. This patch moves it into env_util.
Change-Id: I8372c13b28c3c3058322fc96b656ef71aa18fc0a
Reviewed-on: http://gerrit.cloudera.org:8080/9166
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
---
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.h
M src/kudu/integration-tests/multidir_cluster-itest.cc
M src/kudu/util/env_util.cc
M src/kudu/util/env_util.h
5 files changed, 32 insertions(+), 26 deletions(-)
Approvals:
Kudu Jenkins: Verified
David Ribeiro Alves: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8372c13b28c3c3058322fc96b656ef71aa18fc0a
Gerrit-Change-Number: 9166
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins