You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "lightzhao (via GitHub)" <gi...@apache.org> on 2023/03/13 06:56:00 UTC
[GitHub] [incubator-seatunnel] lightzhao opened a new pull request, #4338: [Improve][JdbcSink]Improve jdbc write performance.
lightzhao opened a new pull request, #4338:
URL: https://github.com/apache/incubator-seatunnel/pull/4338
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
There is no need to serialize when writing, an extra copy is added, and there is actually no task effect.
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lightzhao commented on pull request #4338: [Improve][JdbcSink]Improve jdbc write performance.
Posted by "lightzhao (via GitHub)" <gi...@apache.org>.
lightzhao commented on PR #4338:
URL: https://github.com/apache/incubator-seatunnel/pull/4338#issuecomment-1469079778
> I will close this pr, of course you can reopen it if you think this modification is necessary and add a complete test.
I tested it completely under the flink engine and there is no problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on pull request #4338: [Improve][JdbcSink]Improve jdbc write performance.
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4338:
URL: https://github.com/apache/incubator-seatunnel/pull/4338#issuecomment-1469290780
> > I will close this pr, of course you can reopen it if you think this modification is necessary and add a complete test.
>
> I tested it completely under the flink engine and there is no problem.
Also need to test spark and zeta engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on pull request #4338: [Improve][JdbcSink]Improve jdbc write performance.
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4338:
URL: https://github.com/apache/incubator-seatunnel/pull/4338#issuecomment-1467948727
@lightzhao I will close this pr, of course you can reopen it if you think this modification is necessary and add a complete test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on pull request #4338: [Improve][JdbcSink]Improve jdbc write performance.
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #4338:
URL: https://github.com/apache/incubator-seatunnel/pull/4338#issuecomment-1466040202
well,why SeaTunnelRow can be null？
> I don't think it's necessary to change the code. CC @ic4y
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on pull request #4338: [Improve][JdbcSink]Improve jdbc write performance.
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4338:
URL: https://github.com/apache/incubator-seatunnel/pull/4338#issuecomment-1467929367
I remember that SeaTunnelRow objects may be reused on spark or flink engines. So if we get an object and don't write it out immediately but accumulate batches, we need to make a deep copy of the object, otherwise the object may be tampered with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y closed pull request #4338: [Improve][JdbcSink]Improve jdbc write performance.
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y closed pull request #4338: [Improve][JdbcSink]Improve jdbc write performance.
URL: https://github.com/apache/incubator-seatunnel/pull/4338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on pull request #4338: [Improve][JdbcSink]Improve jdbc write performance.
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4338:
URL: https://github.com/apache/incubator-seatunnel/pull/4338#issuecomment-1467943596
I added a deep copy just because the data output by the sink was wrong. Therefore, it is not recommended to modify it, the risk is very high, and a complete test is required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TaoZex commented on pull request #4338: [Improve][JdbcSink]Improve jdbc write performance.
Posted by "TaoZex (via GitHub)" <gi...@apache.org>.
TaoZex commented on PR #4338:
URL: https://github.com/apache/incubator-seatunnel/pull/4338#issuecomment-1465774027
I don't think it's necessary to change the code. CC @ic4y
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org