You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Ian Luo <ia...@gmail.com> on 2019/01/31 09:12:59 UTC
a follow up on pull request 3274
@khanimteyaz <https://github.com/khanimteyaz> I submitted a pull request
khanimteyaz#11 <https://github.com/khanimteyaz/incubator-dubbo/pull/11> in
your repository. Would you mind to take a look?
My basic idea is: since we are now formatting date and time in single
thread, it is safe to use a singleton formatter without any risk.
Thanks,
-Ian.
Re: a follow up on pull request 3274
Posted by Imteyaz Khan <kh...@gmail.com>.
yes plz.
On Fri, Feb 1, 2019 at 2:11 PM Ian Luo <ia...@gmail.com> wrote:
> bravo, should I start reviewing on main repo?
>
> Thanks,
> -Ian.
>
> On Fri, Feb 1, 2019 at 3:44 PM Imteyaz Khan <kh...@gmail.com>
> wrote:
>
> > Thanks Ian for looking into this. Your PR looks good to me. I have
> approved
> > it to my branch.
> >
> > On Fri, Feb 1, 2019 at 8:46 AM Ian Luo <ia...@gmail.com> wrote:
> >
> > > Imteyaz,
> > >
> > > Pls. review my pull request sent to your repo. You don't need to redo
> > from
> > > the scratch if you see my change appropriated.
> > >
> > > Thanks,
> > > -Ian.
> > >
> > >
> > > On Thu, Jan 31, 2019 at 8:37 PM Imteyaz Khan <kh...@gmail.com>
> > > wrote:
> > >
> > > > Exactly this was my thoughts as well. Any way I will change to simple
> > > date
> > > > format and will remove the date util.
> > > >
> > > > On Thursday, January 31, 2019, Ian Luo <ia...@gmail.com> wrote:
> > > >
> > > > > @khanimteyaz <https://github.com/khanimteyaz> I submitted a pull
> > > request
> > > > > khanimteyaz#11 <
> > https://github.com/khanimteyaz/incubator-dubbo/pull/11
> > > >
> > > > in
> > > > > your repository. Would you mind to take a look?
> > > > >
> > > > > My basic idea is: since we are now formatting date and time in
> single
> > > > > thread, it is safe to use a singleton formatter without any risk.
> > > > >
> > > > >
> > > > > Thanks,
> > > > >
> > > > > -Ian.
> > > > >
> > > >
> > >
> >
>
Re: a follow up on pull request 3274
Posted by Ian Luo <ia...@gmail.com>.
bravo, should I start reviewing on main repo?
Thanks,
-Ian.
On Fri, Feb 1, 2019 at 3:44 PM Imteyaz Khan <kh...@gmail.com> wrote:
> Thanks Ian for looking into this. Your PR looks good to me. I have approved
> it to my branch.
>
> On Fri, Feb 1, 2019 at 8:46 AM Ian Luo <ia...@gmail.com> wrote:
>
> > Imteyaz,
> >
> > Pls. review my pull request sent to your repo. You don't need to redo
> from
> > the scratch if you see my change appropriated.
> >
> > Thanks,
> > -Ian.
> >
> >
> > On Thu, Jan 31, 2019 at 8:37 PM Imteyaz Khan <kh...@gmail.com>
> > wrote:
> >
> > > Exactly this was my thoughts as well. Any way I will change to simple
> > date
> > > format and will remove the date util.
> > >
> > > On Thursday, January 31, 2019, Ian Luo <ia...@gmail.com> wrote:
> > >
> > > > @khanimteyaz <https://github.com/khanimteyaz> I submitted a pull
> > request
> > > > khanimteyaz#11 <
> https://github.com/khanimteyaz/incubator-dubbo/pull/11
> > >
> > > in
> > > > your repository. Would you mind to take a look?
> > > >
> > > > My basic idea is: since we are now formatting date and time in single
> > > > thread, it is safe to use a singleton formatter without any risk.
> > > >
> > > >
> > > > Thanks,
> > > >
> > > > -Ian.
> > > >
> > >
> >
>
Re: a follow up on pull request 3274
Posted by Imteyaz Khan <kh...@gmail.com>.
Thanks Ian for looking into this. Your PR looks good to me. I have approved
it to my branch.
On Fri, Feb 1, 2019 at 8:46 AM Ian Luo <ia...@gmail.com> wrote:
> Imteyaz,
>
> Pls. review my pull request sent to your repo. You don't need to redo from
> the scratch if you see my change appropriated.
>
> Thanks,
> -Ian.
>
>
> On Thu, Jan 31, 2019 at 8:37 PM Imteyaz Khan <kh...@gmail.com>
> wrote:
>
> > Exactly this was my thoughts as well. Any way I will change to simple
> date
> > format and will remove the date util.
> >
> > On Thursday, January 31, 2019, Ian Luo <ia...@gmail.com> wrote:
> >
> > > @khanimteyaz <https://github.com/khanimteyaz> I submitted a pull
> request
> > > khanimteyaz#11 <https://github.com/khanimteyaz/incubator-dubbo/pull/11
> >
> > in
> > > your repository. Would you mind to take a look?
> > >
> > > My basic idea is: since we are now formatting date and time in single
> > > thread, it is safe to use a singleton formatter without any risk.
> > >
> > >
> > > Thanks,
> > >
> > > -Ian.
> > >
> >
>
Re: a follow up on pull request 3274
Posted by Ian Luo <ia...@gmail.com>.
Imteyaz,
Pls. review my pull request sent to your repo. You don't need to redo from
the scratch if you see my change appropriated.
Thanks,
-Ian.
On Thu, Jan 31, 2019 at 8:37 PM Imteyaz Khan <kh...@gmail.com> wrote:
> Exactly this was my thoughts as well. Any way I will change to simple date
> format and will remove the date util.
>
> On Thursday, January 31, 2019, Ian Luo <ia...@gmail.com> wrote:
>
> > @khanimteyaz <https://github.com/khanimteyaz> I submitted a pull request
> > khanimteyaz#11 <https://github.com/khanimteyaz/incubator-dubbo/pull/11>
> in
> > your repository. Would you mind to take a look?
> >
> > My basic idea is: since we are now formatting date and time in single
> > thread, it is safe to use a singleton formatter without any risk.
> >
> >
> > Thanks,
> >
> > -Ian.
> >
>
Re: a follow up on pull request 3274
Posted by Imteyaz Khan <kh...@gmail.com>.
Exactly this was my thoughts as well. Any way I will change to simple date
format and will remove the date util.
On Thursday, January 31, 2019, Ian Luo <ia...@gmail.com> wrote:
> @khanimteyaz <https://github.com/khanimteyaz> I submitted a pull request
> khanimteyaz#11 <https://github.com/khanimteyaz/incubator-dubbo/pull/11> in
> your repository. Would you mind to take a look?
>
> My basic idea is: since we are now formatting date and time in single
> thread, it is safe to use a singleton formatter without any risk.
>
>
> Thanks,
>
> -Ian.
>