You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/29 13:03:55 UTC
[GitHub] [flink-table-store] JingsongLi opened a new pull request, #183: [FLINK-28299] Get rid of Sink v2
JingsongLi opened a new pull request, #183:
URL: https://github.com/apache/flink-table-store/pull/183
Sink v2 makes hard to be compatible with Flink 1.14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #183: [FLINK-28299] Get rid of Sink v2
Posted by GitBox <gi...@apache.org>.
LadyForest commented on code in PR #183:
URL: https://github.com/apache/flink-table-store/pull/183#discussion_r911225310
##########
flink-table-store-kafka/src/main/java/org/apache/flink/table/store/kafka/KafkaLogStoreFactory.java:
##########
@@ -237,6 +241,14 @@ public KafkaLogSinkProvider createSinkProvider(
helper.getOptions().get(CHANGELOG_MODE));
}
+ private int[] getPrimaryKeyIndexes(ResolvedSchema schema) {
+ final List<String> columns = schema.getColumnNames();
+ return schema.getPrimaryKey()
+ .map(UniqueConstraint::getColumns)
+ .map(pkColumns -> pkColumns.stream().mapToInt(columns::indexOf).toArray())
+ .orElseGet(() -> new int[] {});
+ }
+
Review Comment:
Just curious is there any difference between `getPrimaryKeyIndexes` and `schema.getPrimaryKeyIndexes`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #183: [FLINK-28299] Get rid of Sink v2
Posted by GitBox <gi...@apache.org>.
LadyForest commented on code in PR #183:
URL: https://github.com/apache/flink-table-store/pull/183#discussion_r910999155
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/FlinkSinkBuilder.java:
##########
@@ -70,8 +68,8 @@ public FlinkSinkBuilder withOverwritePartition(Map<String, String> overwritePart
return this;
}
- public FlinkSinkBuilder withLogSinkProvider(LogSinkProvider logSinkProvider) {
- this.logSinkProvider = logSinkProvider;
+ public FlinkSinkBuilder withLogSinkFunction(LogSinkFunction logSinkFunction) {
Review Comment:
```suggestion
public FlinkSinkBuilder withLogSinkFunction(@Nullable LogSinkFunction logSinkFunction) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #183: [FLINK-28299] Get rid of Sink v2
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #183:
URL: https://github.com/apache/flink-table-store/pull/183#discussion_r911535709
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/TableStoreSink.java:
##########
@@ -196,7 +165,6 @@ public void applyOverwrite(boolean overwrite) {
this.overwrite = overwrite;
}
- @Override
public void setLockFactory(@Nullable CatalogLock.Factory lockFactory) {
Review Comment:
LockFactory should be provided by our catalog instead of incompatible Flink Catalog.
Yes, we should provide this lock in our HiveCatalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #183: [FLINK-28299] Get rid of Sink v2
Posted by GitBox <gi...@apache.org>.
LadyForest commented on code in PR #183:
URL: https://github.com/apache/flink-table-store/pull/183#discussion_r910558149
##########
flink-table-store-kafka/src/main/java/org/apache/flink/table/store/kafka/KafkaSinkFunction.java:
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.store.kafka;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducer;
+import org.apache.flink.streaming.connectors.kafka.KafkaSerializationSchema;
+import org.apache.flink.table.store.table.sink.LogSinkFunction;
+import org.apache.flink.table.store.table.sink.SinkRecord;
+
+import org.apache.kafka.clients.producer.Callback;
+import org.apache.kafka.clients.producer.ProducerRecord;
+
+import java.util.Properties;
+
+import static java.util.Objects.requireNonNull;
+
+/** */
Review Comment:
comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #183: [FLINK-28299] Get rid of Sink v2
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #183:
URL: https://github.com/apache/flink-table-store/pull/183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #183: [FLINK-28299] Get rid of Sink v2
Posted by GitBox <gi...@apache.org>.
LadyForest commented on code in PR #183:
URL: https://github.com/apache/flink-table-store/pull/183#discussion_r911005761
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/TableStoreSink.java:
##########
@@ -196,7 +165,6 @@ public void applyOverwrite(boolean overwrite) {
this.overwrite = overwrite;
}
- @Override
public void setLockFactory(@Nullable CatalogLock.Factory lockFactory) {
Review Comment:
`setLockFactory` is not referenced. Is there any ongoing work still?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #183: [FLINK-28299] Get rid of Sink v2
Posted by GitBox <gi...@apache.org>.
LadyForest commented on code in PR #183:
URL: https://github.com/apache/flink-table-store/pull/183#discussion_r910581992
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/StoreWriteOperator.java:
##########
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.store.connector.sink;
+
+import org.apache.flink.api.common.functions.util.FunctionUtils;
+import org.apache.flink.api.common.state.CheckpointListener;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.runtime.state.StateInitializationContext;
+import org.apache.flink.runtime.state.StateSnapshotContext;
+import org.apache.flink.streaming.api.functions.sink.SinkFunction;
+import org.apache.flink.streaming.api.graph.StreamConfig;
+import org.apache.flink.streaming.api.operators.InternalTimerService;
+import org.apache.flink.streaming.api.operators.Output;
+import org.apache.flink.streaming.api.watermark.Watermark;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.streaming.runtime.tasks.ProcessingTimeService;
+import org.apache.flink.streaming.runtime.tasks.StreamTask;
+import org.apache.flink.streaming.util.functions.StreamingFunctionUtils;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.log.LogWriteCallback;
+import org.apache.flink.table.store.table.FileStoreTable;
+import org.apache.flink.table.store.table.sink.FileCommittable;
+import org.apache.flink.table.store.table.sink.LogSinkFunction;
+import org.apache.flink.table.store.table.sink.SinkRecord;
+import org.apache.flink.table.store.table.sink.TableWrite;
+
+import javax.annotation.Nullable;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+/** A {@link PrepareCommitOperator} to write records. */
+public class StoreWriteOperator extends PrepareCommitOperator {
+
+ private final FileStoreTable table;
+
+ @Nullable private final Map<String, String> overwritePartition;
+
+ @Nullable private final LogSinkFunction logSinkFunction;
+
+ private transient SimpleContext sinkContext;
+
+ /** We listen to this ourselves because we don't have an {@link InternalTimerService}. */
+ private long currentWatermark = Long.MIN_VALUE;
+
+ private TableWrite write;
+
+ @Nullable private LogWriteCallback logCallback;
+
+ public StoreWriteOperator(
+ FileStoreTable table,
+ @Nullable Map<String, String> overwritePartition,
+ @Nullable LogSinkFunction logSinkFunction) {
+ this.table = table;
+ this.overwritePartition = overwritePartition;
+ this.logSinkFunction = logSinkFunction;
+ }
+
+ @Override
+ public void setup(
+ StreamTask<?, ?> containingTask,
+ StreamConfig config,
+ Output<StreamRecord<Committable>> output) {
+ super.setup(containingTask, config, output);
+ if (logSinkFunction != null) {
+ FunctionUtils.setFunctionRuntimeContext(logSinkFunction, getRuntimeContext());
+ }
+ }
+
+ @Override
+ public void initializeState(StateInitializationContext context) throws Exception {
+ super.initializeState(context);
+ if (logSinkFunction != null) {
+ StreamingFunctionUtils.restoreFunctionState(context, logSinkFunction);
+ }
+ }
+
+ @Override
+ public void open() throws Exception {
+ super.open();
+ this.write = table.newWrite().withOverwrite(overwritePartition != null);
+ this.sinkContext = new SimpleContext(getProcessingTimeService());
+ if (logSinkFunction != null) {
+ FunctionUtils.openFunction(logSinkFunction, new Configuration());
+ logCallback = new LogWriteCallback();
+ logSinkFunction.setWriteCallback(logCallback);
+ }
+ }
+
+ @Override
+ public void processWatermark(Watermark mark) throws Exception {
+ super.processWatermark(mark);
+ this.currentWatermark = mark.getTimestamp();
+ if (logSinkFunction != null) {
+ logSinkFunction.writeWatermark(
+ new org.apache.flink.api.common.eventtime.Watermark(mark.getTimestamp()));
+ }
+ }
+
+ @Override
+ public void processElement(StreamRecord<RowData> element) throws Exception {
+ sinkContext.timestamp = element.hasTimestamp() ? element.getTimestamp() : null;
+
+ SinkRecord record;
+ try {
+ record = write.write(element.getValue());
+ } catch (Exception e) {
+ throw new IOException(e);
+ }
+
+ if (logSinkFunction != null) {
+ // write to log store, need to preserve original pk (which includes partition fields)
+ SinkRecord logRecord = write.recordConverter().convertToLogSinkRecord(record);
+ logSinkFunction.invoke(logRecord, sinkContext);
+ }
+ }
+
+ @Override
+ public void snapshotState(StateSnapshotContext context) throws Exception {
+ super.snapshotState(context);
+ if (logSinkFunction != null) {
+ StreamingFunctionUtils.snapshotFunctionState(
+ context, getOperatorStateBackend(), logSinkFunction);
+ }
+ }
+
+ @Override
+ public void finish() throws Exception {
+ super.finish();
+ if (logSinkFunction != null) {
+ logSinkFunction.finish();
+ }
+ }
+
+ @Override
+ public void close() throws Exception {
+ super.close();
+ if (write != null) {
+ write.close();
+ }
+
+ if (logSinkFunction != null) {
+ FunctionUtils.closeFunction(logSinkFunction);
+ }
+ }
+
+ @Override
+ public void notifyCheckpointComplete(long checkpointId) throws Exception {
+ super.notifyCheckpointComplete(checkpointId);
+
+ if (logSinkFunction instanceof CheckpointListener) {
+ ((CheckpointListener) logSinkFunction).notifyCheckpointComplete(checkpointId);
+ }
+ }
+
+ @Override
+ public void notifyCheckpointAborted(long checkpointId) throws Exception {
+ super.notifyCheckpointAborted(checkpointId);
+
+ if (logSinkFunction instanceof CheckpointListener) {
+ ((CheckpointListener) logSinkFunction).notifyCheckpointAborted(checkpointId);
+ }
+ }
+
+ @Override
+ protected List<Committable> prepareCommit() throws IOException {
+ List<Committable> committables = new ArrayList<>();
+ try {
+ for (FileCommittable committable : write.prepareCommit()) {
+ committables.add(new Committable(Committable.Kind.FILE, committable));
+ }
+ } catch (Exception e) {
+ throw new IOException(e);
+ }
+
+ if (logCallback != null) {
+ logCallback
+ .offsets()
+ .forEach(
+ (k, v) ->
+ committables.add(
+ new Committable(
+ Committable.Kind.LOG_OFFSET,
+ new LogOffsetCommittable(k, v))));
+ }
+
+ return committables;
+ }
+
+ private class SimpleContext implements SinkFunction.Context {
+
+ private Long timestamp;
+
+ private final ProcessingTimeService processingTimeService;
+
+ public SimpleContext(ProcessingTimeService processingTimeService) {
+ this.processingTimeService = processingTimeService;
+ }
+
+ @Override
+ public long currentProcessingTime() {
+ return processingTimeService.getCurrentProcessingTime();
+ }
+
+ @Override
+ public long currentWatermark() {
+ return currentWatermark;
+ }
+
+ @Override
+ public Long timestamp() {
+ if (timestamp != null) {
Review Comment:
Nit: is there any other reason for the null check, just return `timestamp`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #183: [FLINK-28299] Get rid of Sink v2
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #183:
URL: https://github.com/apache/flink-table-store/pull/183#discussion_r911535856
##########
flink-table-store-kafka/src/main/java/org/apache/flink/table/store/kafka/KafkaLogStoreFactory.java:
##########
@@ -237,6 +241,14 @@ public KafkaLogSinkProvider createSinkProvider(
helper.getOptions().get(CHANGELOG_MODE));
}
+ private int[] getPrimaryKeyIndexes(ResolvedSchema schema) {
+ final List<String> columns = schema.getColumnNames();
+ return schema.getPrimaryKey()
+ .map(UniqueConstraint::getColumns)
+ .map(pkColumns -> pkColumns.stream().mapToInt(columns::indexOf).toArray())
+ .orElseGet(() -> new int[] {});
+ }
+
Review Comment:
1.14 dose not provide `schema.getPrimaryKeyIndexes`, just copy from 1.15.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on pull request #183: [FLINK-28299] Get rid of Sink v2
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on PR #183:
URL: https://github.com/apache/flink-table-store/pull/183#issuecomment-1171822135
Thanks @LadyForest for the review, let's move on to complete the 1.14 compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #183: [FLINK-28299] Get rid of Sink v2
Posted by GitBox <gi...@apache.org>.
LadyForest commented on code in PR #183:
URL: https://github.com/apache/flink-table-store/pull/183#discussion_r910579852
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/StoreWriteOperator.java:
##########
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.store.connector.sink;
+
+import org.apache.flink.api.common.functions.util.FunctionUtils;
+import org.apache.flink.api.common.state.CheckpointListener;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.runtime.state.StateInitializationContext;
+import org.apache.flink.runtime.state.StateSnapshotContext;
+import org.apache.flink.streaming.api.functions.sink.SinkFunction;
+import org.apache.flink.streaming.api.graph.StreamConfig;
+import org.apache.flink.streaming.api.operators.InternalTimerService;
+import org.apache.flink.streaming.api.operators.Output;
+import org.apache.flink.streaming.api.watermark.Watermark;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.streaming.runtime.tasks.ProcessingTimeService;
+import org.apache.flink.streaming.runtime.tasks.StreamTask;
+import org.apache.flink.streaming.util.functions.StreamingFunctionUtils;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.log.LogWriteCallback;
+import org.apache.flink.table.store.table.FileStoreTable;
+import org.apache.flink.table.store.table.sink.FileCommittable;
+import org.apache.flink.table.store.table.sink.LogSinkFunction;
+import org.apache.flink.table.store.table.sink.SinkRecord;
+import org.apache.flink.table.store.table.sink.TableWrite;
+
+import javax.annotation.Nullable;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+/** A {@link PrepareCommitOperator} to write records. */
+public class StoreWriteOperator extends PrepareCommitOperator {
+
+ private final FileStoreTable table;
+
+ @Nullable private final Map<String, String> overwritePartition;
+
+ @Nullable private final LogSinkFunction logSinkFunction;
+
+ private transient SimpleContext sinkContext;
+
+ /** We listen to this ourselves because we don't have an {@link InternalTimerService}. */
+ private long currentWatermark = Long.MIN_VALUE;
+
+ private TableWrite write;
+
+ @Nullable private LogWriteCallback logCallback;
+
+ public StoreWriteOperator(
+ FileStoreTable table,
+ @Nullable Map<String, String> overwritePartition,
+ @Nullable LogSinkFunction logSinkFunction) {
+ this.table = table;
+ this.overwritePartition = overwritePartition;
+ this.logSinkFunction = logSinkFunction;
+ }
+
+ @Override
+ public void setup(
+ StreamTask<?, ?> containingTask,
+ StreamConfig config,
+ Output<StreamRecord<Committable>> output) {
+ super.setup(containingTask, config, output);
+ if (logSinkFunction != null) {
+ FunctionUtils.setFunctionRuntimeContext(logSinkFunction, getRuntimeContext());
+ }
+ }
+
+ @Override
+ public void initializeState(StateInitializationContext context) throws Exception {
+ super.initializeState(context);
+ if (logSinkFunction != null) {
+ StreamingFunctionUtils.restoreFunctionState(context, logSinkFunction);
+ }
+ }
+
+ @Override
+ public void open() throws Exception {
+ super.open();
+ this.write = table.newWrite().withOverwrite(overwritePartition != null);
+ this.sinkContext = new SimpleContext(getProcessingTimeService());
+ if (logSinkFunction != null) {
+ FunctionUtils.openFunction(logSinkFunction, new Configuration());
+ logCallback = new LogWriteCallback();
+ logSinkFunction.setWriteCallback(logCallback);
+ }
+ }
+
+ @Override
+ public void processWatermark(Watermark mark) throws Exception {
+ super.processWatermark(mark);
+ this.currentWatermark = mark.getTimestamp();
+ if (logSinkFunction != null) {
+ logSinkFunction.writeWatermark(
+ new org.apache.flink.api.common.eventtime.Watermark(mark.getTimestamp()));
+ }
+ }
+
+ @Override
+ public void processElement(StreamRecord<RowData> element) throws Exception {
+ sinkContext.timestamp = element.hasTimestamp() ? element.getTimestamp() : null;
+
+ SinkRecord record;
+ try {
+ record = write.write(element.getValue());
+ } catch (Exception e) {
+ throw new IOException(e);
+ }
+
+ if (logSinkFunction != null) {
+ // write to log store, need to preserve original pk (which includes partition fields)
+ SinkRecord logRecord = write.recordConverter().convertToLogSinkRecord(record);
+ logSinkFunction.invoke(logRecord, sinkContext);
+ }
+ }
+
+ @Override
+ public void snapshotState(StateSnapshotContext context) throws Exception {
+ super.snapshotState(context);
+ if (logSinkFunction != null) {
+ StreamingFunctionUtils.snapshotFunctionState(
+ context, getOperatorStateBackend(), logSinkFunction);
+ }
+ }
+
+ @Override
+ public void finish() throws Exception {
+ super.finish();
+ if (logSinkFunction != null) {
+ logSinkFunction.finish();
+ }
+ }
+
+ @Override
+ public void close() throws Exception {
+ super.close();
+ if (write != null) {
+ write.close();
+ }
+
+ if (logSinkFunction != null) {
+ FunctionUtils.closeFunction(logSinkFunction);
+ }
+ }
+
+ @Override
+ public void notifyCheckpointComplete(long checkpointId) throws Exception {
+ super.notifyCheckpointComplete(checkpointId);
+
+ if (logSinkFunction instanceof CheckpointListener) {
+ ((CheckpointListener) logSinkFunction).notifyCheckpointComplete(checkpointId);
+ }
+ }
+
+ @Override
+ public void notifyCheckpointAborted(long checkpointId) throws Exception {
+ super.notifyCheckpointAborted(checkpointId);
+
+ if (logSinkFunction instanceof CheckpointListener) {
+ ((CheckpointListener) logSinkFunction).notifyCheckpointAborted(checkpointId);
+ }
+ }
+
+ @Override
+ protected List<Committable> prepareCommit() throws IOException {
+ List<Committable> committables = new ArrayList<>();
+ try {
+ for (FileCommittable committable : write.prepareCommit()) {
+ committables.add(new Committable(Committable.Kind.FILE, committable));
+ }
+ } catch (Exception e) {
+ throw new IOException(e);
+ }
+
+ if (logCallback != null) {
+ logCallback
+ .offsets()
+ .forEach(
+ (k, v) ->
+ committables.add(
+ new Committable(
+ Committable.Kind.LOG_OFFSET,
+ new LogOffsetCommittable(k, v))));
+ }
+
+ return committables;
+ }
+
+ private class SimpleContext implements SinkFunction.Context {
+
+ private Long timestamp;
Review Comment:
```suggestion
@Nullable private Long timestamp;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org