You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Andreas L Delmelle <a_...@pandora.be> on 2006/08/23 02:17:34 UTC
Re: svn commit: r433810 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FOText.java FObjMixed.java
On Aug 23, 2006, at 02:10, adelmelle@apache.org wrote:
> Author: adelmelle
> Date: Tue Aug 22 17:10:20 2006
> New Revision: 433810
>
> URL: http://svn.apache.org/viewvc?rev=433810&view=rev
> Log:
> Cleanup: removal of suspicious static in FOText
Finally went ahead with this one as well. Up to now, I was a bit
reluctant to remove it, since I didn't fully get its intention. Seems
to be used only during text-transform handling.
Saving lastFOTextProcessed in the ancestorBlock seemed like a much
better solution, and should AFAICT, have exactly the same net effect.
No tests broke, but I'm not sure how to test whether this change had
any unintended side-effects...
Later,
Andreas
Re: svn commit: r433810 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo:
FOText.java FObjMixed.java
Posted by Chris Bowditch <bo...@hotmail.com>.
Andreas L Delmelle wrote:
> On Aug 24, 2006, at 19:45, Andreas L Delmelle wrote:
>
>> On Aug 24, 2006, at 15:08, Chris Bowditch wrote:
>>
>> Hi Chris,
>>
>>> <snip />
>>> Well I'm not sure if its one of your recent changes thats to blame,
>>> but I've just noticed that simple tables (test file attached) appear
>>> to be issuing a SEVERE message to the log, i.e.
>>>
>>> 24-Aug-2006 14:04:41 org.apache.fop.datatypes.LengthBase getBaseLength
>>> SEVERE: getBaseLength called without context
>>
>>
>> Just checked this, and it seems that this has to do with the
>> percentage ipd. Somehow, propertyList.get().getLengthRange() tries to
>> resolve the percentage at that point, but does not have any context
>> yet to do so...
>
>
> Got it. Was introduced with checking bpd/ipd for negative values
> (r433385).
>
> Should be fixed now.
Thanks for a swift turnaround Andreas!
Chris
Re: svn commit: r433810 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FOText.java FObjMixed.java
Posted by Andreas L Delmelle <a_...@pandora.be>.
On Aug 24, 2006, at 19:45, Andreas L Delmelle wrote:
> On Aug 24, 2006, at 15:08, Chris Bowditch wrote:
>
> Hi Chris,
>
>> <snip />
>> Well I'm not sure if its one of your recent changes thats to
>> blame, but I've just noticed that simple tables (test file
>> attached) appear to be issuing a SEVERE message to the log, i.e.
>>
>> 24-Aug-2006 14:04:41 org.apache.fop.datatypes.LengthBase
>> getBaseLength
>> SEVERE: getBaseLength called without context
>
> Just checked this, and it seems that this has to do with the
> percentage ipd. Somehow, propertyList.get().getLengthRange() tries
> to resolve the percentage at that point, but does not have any
> context yet to do so...
Got it. Was introduced with checking bpd/ipd for negative values
(r433385).
Should be fixed now.
Cheers,
Andreas
Re: svn commit: r433810 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FOText.java FObjMixed.java
Posted by Andreas L Delmelle <a_...@pandora.be>.
On Aug 24, 2006, at 15:08, Chris Bowditch wrote:
Hi Chris,
> <snip />
> Well I'm not sure if its one of your recent changes thats to blame,
> but I've just noticed that simple tables (test file attached)
> appear to be issuing a SEVERE message to the log, i.e.
>
> 24-Aug-2006 14:04:41 org.apache.fop.datatypes.LengthBase getBaseLength
> SEVERE: getBaseLength called without context
Just checked this, and it seems that this has to do with the
percentage ipd. Somehow, propertyList.get().getLengthRange() tries to
resolve the percentage at that point, but does not have any context
yet to do so...
I'll look a bit deeper into it. See if we can avoid the error message
somehow.
This could have been there for quite some time. The percentage
resolution is attempted again during layout, and won't give an error
message there, because the context is available. So the tests would
pass.
Later,
Andreas
Re: svn commit: r433810 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo:
FOText.java FObjMixed.java
Posted by Chris Bowditch <bo...@hotmail.com>.
Andreas L Delmelle wrote:
> On Aug 23, 2006, at 02:10, adelmelle@apache.org wrote:
>
<snip/>
> No tests broke, but I'm not sure how to test whether this change had
> any unintended side-effects...
Well I'm not sure if its one of your recent changes thats to blame, but
I've just noticed that simple tables (test file attached) appear to be
issuing a SEVERE message to the log, i.e.
24-Aug-2006 14:04:41 org.apache.fop.datatypes.LengthBase getBaseLength
SEVERE: getBaseLength called without context
I traced the call back to LengthBase.getBaseLength to Table.bind()
The table still gets generated but the message makes you think it failed.
Chris