You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "amh1k (via GitHub)" <gi...@apache.org> on 2026/07/28 10:02:55 UTC

[PR] Fix/skill evals quote helper paths [magpie]

amh1k opened a new pull request, #992:
URL: https://github.com/apache/magpie/pull/992

   ## Summary
   
   - Quote the `skill-evals` test helper script paths so grader and judge commands work when the checkout path contains spaces.
   - Refresh the workspace lockfile so required hooks do not rewrite it during validation.
   
   ## Type of change
   
   - [ ] Skill change (`.claude/skills/<name>/`) — eval fixtures updated below
   - [ ] Tool / bridge contract (`tools/<system>/*.md`)
   - [x] Python package (`tools/*/` with `pyproject.toml`)
   - [ ] Groovy reference impl
   - [ ] Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
   - [ ] Documentation (`docs/`, `README.md`, `CONTRIBUTING.md`)
   - [ ] Project template (`projects/_template/`)
   - [x] CI / dev loop (`prek`, workflows, validators)
   - [ ] Other:
   
   ## Test plan
   
   - [ ] `prek run --all-files` passes
   - [x] Workspace `ruff check`, `ruff format`, `mypy`, and `pytest` hooks pass
   - [x] `uv run --directory tools/skill-evals pytest tests/test_runner.py -k 'batch_grade_grader_says_no or compare_with_grader_passes_when_decision_fields_match_and_prose_judged_match or compare_with_grader_handles_nested_list_of_dicts or cli_grader_mode_passes_on_wording_difference or batch_judge_yes'` — 5 passed
   - [ ] For Groovy bridges touched: command-line invocation tested end-to-end
   - [ ] For skill changes: eval suite passes for the affected skill
   - [ ] For skill *behaviour* changes: a new or updated eval fixture is included in this PR
   - [ ] Other:
   
   ## RFC-AI-0004 compliance
   
   Not applicable: this change only corrects local Python test command construction and refreshes dependency-lock metadata.
   
   ## Linked issues
   
   Closes #991 
   
   ## Notes for reviewers (optional)
   
   `run_cli` intentionally uses `shlex.split()` with `shell=False`; quoting the fixture script paths preserves that safety property while allowing paths containing spaces.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix/skill evals quote helper paths [magpie]

Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean merged PR #992:
URL: https://github.com/apache/magpie/pull/992


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org