You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Venkat Mahadevan <ve...@mitre.org> on 2011/10/20 19:27:06 UTC

Review Request: RAVE-307: RegionWidget - ModelPermissionEvaluator and Service Annotations

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2474/
-----------------------------------------------------------

Review request for rave.


Summary
-------

This patch is for RAVE-307: RegionWidget - ModelPermissionEvaluator and Service Annotations


Diffs
-----

  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/RegionWidgetService.java 1186777 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultRegionWidgetPermissionEvaluatorTest.java PRE-CREATION 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultRegionWidgetPermissionEvaluator.java PRE-CREATION 

Diff: https://reviews.apache.org/r/2474/diff


Testing
-------


Thanks,

Venkat


Re: Review Request: RAVE-307: RegionWidget - ModelPermissionEvaluator and Service Annotations

Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2474/#review2891
-----------------------------------------------------------

Ship it!


Will fix this one as well

- Anthony


On 2011-10-27 20:41:06, Venkat Mahadevan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2474/
> -----------------------------------------------------------
> 
> (Updated 2011-10-27 20:41:06)
> 
> 
> Review request for rave and Anthony Carlucci.
> 
> 
> Summary
> -------
> 
> This patch is for RAVE-307: RegionWidget - ModelPermissionEvaluator and Service Annotations
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/RegionWidgetService.java 1189948 
> 
> Diff: https://reviews.apache.org/r/2474/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkat
> 
>


Re: Review Request: RAVE-307: RegionWidget - ModelPermissionEvaluator and Service Annotations

Posted by Venkat Mahadevan <ve...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2474/
-----------------------------------------------------------

(Updated 2011-10-27 20:41:06.485250)


Review request for rave and Anthony Carlucci.


Summary
-------

This patch is for RAVE-307: RegionWidget - ModelPermissionEvaluator and Service Annotations


Diffs (updated)
-----

  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/RegionWidgetService.java 1189948 

Diff: https://reviews.apache.org/r/2474/diff


Testing
-------


Thanks,

Venkat


Re: Review Request: RAVE-307: RegionWidget - ModelPermissionEvaluator and Service Annotations

Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2474/#review2855
-----------------------------------------------------------

Ship it!


Venkat this looks good - I will work on applying it today.

- Anthony


On 2011-10-20 17:27:06, Venkat Mahadevan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2474/
> -----------------------------------------------------------
> 
> (Updated 2011-10-20 17:27:06)
> 
> 
> Review request for rave.
> 
> 
> Summary
> -------
> 
> This patch is for RAVE-307: RegionWidget - ModelPermissionEvaluator and Service Annotations
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/RegionWidgetService.java 1186777 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultRegionWidgetPermissionEvaluatorTest.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultRegionWidgetPermissionEvaluator.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/2474/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkat
> 
>