You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/07/25 15:31:34 UTC
[GitHub] [dubbo-go] gaoxinge opened a new pull request #672: Consul
gaoxinge opened a new pull request #672:
URL: https://github.com/apache/dubbo-go/pull/672
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
- update package version by following https://github.com/apache/dubbo-go/issues/656
- `github.com/hashicorp/consul` to `v1.8.0`
- `github.com/hashicorp/consul/api` to `v1.5.0`
- `k8s.io/api` to `v0.16.9`
- `k8s.io/apimachinery` to `v0.16.9`
- `k8s.io/client-go` to `v0.16.9`
- make etcd client codes more simple and clean
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes https://github.com/apache/dubbo-go/issues/656.
**Special notes for your reviewer**:
- NONE
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
NONE
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng merged pull request #672: Upd: upgrade package version
Posted by GitBox <gi...@apache.org>.
fangyincheng merged pull request #672:
URL: https://github.com/apache/dubbo-go/pull/672
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #672: Upd: upgrade package version
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #672:
URL: https://github.com/apache/dubbo-go/pull/672#issuecomment-663927657
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/672?src=pr&el=h1) Report
> Merging [#672](https://codecov.io/gh/apache/dubbo-go/pull/672?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/d3db1c2ef966b5a3092ddfbb9fa5603f1fd92aad&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `74.13%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/672?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #672 +/- ##
===========================================
- Coverage 63.80% 63.77% -0.03%
===========================================
Files 236 237 +1
Lines 12313 12298 -15
===========================================
- Hits 7856 7843 -13
- Misses 3690 3701 +11
+ Partials 767 754 -13
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/672?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/available\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/672/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYXZhaWxhYmxlX2NsdXN0ZXIuZ28=) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/broadcast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/672/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYnJvYWRjYXN0X2NsdXN0ZXIuZ28=) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/broadcast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/672/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYnJvYWRjYXN0X2NsdXN0ZXJfaW52b2tlci5nbw==) | `80.00% <ø> (ø)` | |
| [cluster/cluster\_impl/failback\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/672/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlci5nbw==) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/672/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.02% <ø> (-2.20%)` | :arrow_down: |
| [cluster/cluster\_impl/failfast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/672/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlci5nbw==) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/failfast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/672/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlcl9pbnZva2VyLmdv) | `71.42% <ø> (ø)` | |
| [cluster/cluster\_impl/failover\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/672/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbG92ZXJfY2x1c3Rlci5nbw==) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/failsafe\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/672/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbHNhZmVfY2x1c3Rlci5nbw==) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/failsafe\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/672/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbHNhZmVfY2x1c3Rlcl9pbnZva2VyLmdv) | `81.81% <ø> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/dubbo-go/pull/672/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/672?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/672?src=pr&el=footer). Last update [053aab5...cb15ad0](https://codecov.io/gh/apache/dubbo-go/pull/672?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org