[GitHub] [superset] rubypollev commented on issue #16766: Absolute value diff is incorrect

[GitBox <gi...@apache.org>]

rubypollev commented on issue #16766:
URL: https://github.com/apache/superset/issues/16766#issuecomment-929392087


   Tableau's implementation makes sense. This is a "difference." It can be negative.
   
   Superset's implementation claims this same function is an "absolute difference," though, which it's not:
   <img width="1538" alt="time_comparison_absolute_difference" src="https://user-images.githubusercontent.com/45610410/135128264-8142b9b0-a3c0-4831-8674-069c5c4325b3.png">
   
   An [absolute difference](https://en.wikipedia.org/wiki/Absolute_difference) is non-negative by definition.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org