You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/08 23:33:28 UTC
[GitHub] [kylin] etherge opened a new pull request #1048: KYLIN-4331 Fix
noncompliant method names in child class
etherge opened a new pull request #1048: KYLIN-4331 Fix noncompliant method names in child class
URL: https://github.com/apache/kylin/pull/1048
https://issues.apache.org/jira/browse/KYLIN-4331
When a method in a child class has the same signature as a method in a parent class, it is assumed to be an override. However, that's not the case when:
the parent class method is static and the child class method is not.
the arguments or return types of the child method are in different packages than those of the parent method.
the parent class method is private.
Typically, these things are done unintentionally; the private parent class method is overlooked, the static keyword in the parent declaration is overlooked, or the wrong class is imported in the child. But if the intent is truly for the child class method to be different, then the method should be renamed to prevent confusion.
https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWP9sMDe3e-qcckjAB5V&open=AWP9sMDe3e-qcckjAB5V
https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWcaThjuH5xombRgErVV&open=AWcaThjuH5xombRgErVV
https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWxmA253_Xcr_PhA6-Br&open=AWxmA253_Xcr_PhA6-Br
https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWxmA253_Xcr_PhA6-Bw&open=AWxmA253_Xcr_PhA6-Bw
https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWxmA253_Xcr_PhA6-By&open=AWxmA253_Xcr_PhA6-By
https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWxmA253_Xcr_PhA6-B1&open=AWxmA253_Xcr_PhA6-B1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi merged pull request #1048: KYLIN-4331 Fix
noncompliant method names in child class
Posted by GitBox <gi...@apache.org>.
shaofengshi merged pull request #1048: KYLIN-4331 Fix noncompliant method names in child class
URL: https://github.com/apache/kylin/pull/1048
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1048: KYLIN-4331 Fix
noncompliant method names in child class
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1048: KYLIN-4331 Fix noncompliant method names in child class
URL: https://github.com/apache/kylin/pull/1048#issuecomment-572330221
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1048?src=pr&el=h1) Report
> Merging [#1048](https://codecov.io/gh/apache/kylin/pull/1048?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/b3884a11353a1a2ebabe0b9bed600b24110fe5eb?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/1048?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1048 +/- ##
============================================
- Coverage 25% 24.99% -0.01%
- Complexity 6179 6180 +1
============================================
Files 1438 1438
Lines 87669 87673 +4
Branches 12256 12256
============================================
- Hits 21919 21917 -2
- Misses 63597 63603 +6
Partials 2153 2153
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1048?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...dk/datasource/framework/FixedCachedRowSetImpl.java](https://codecov.io/gh/apache/kylin/pull/1048/diff?src=pr&el=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2ZyYW1ld29yay9GaXhlZENhY2hlZFJvd1NldEltcGwuamF2YQ==) | `2.29% <0%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...apache/kylin/engine/spark/SparkExecutableLivy.java](https://codecov.io/gh/apache/kylin/pull/1048/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlTGl2eS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1048/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...in/cube/gridtable/CuboidToGridTableMappingExt.java](https://codecov.io/gh/apache/kylin/pull/1048/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2dyaWR0YWJsZS9DdWJvaWRUb0dyaWRUYWJsZU1hcHBpbmdFeHQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1048/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
| [...ain/java/org/apache/kylin/dict/TrieDictionary.java](https://codecov.io/gh/apache/kylin/pull/1048/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1RyaWVEaWN0aW9uYXJ5LmphdmE=) | `73.02% <0%> (+0.46%)` | `57% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1048?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1048?src=pr&el=footer). Last update [b3884a1...1510c82](https://codecov.io/gh/apache/kylin/pull/1048?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1048: KYLIN-4331 Fix
noncompliant method names in child class
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1048: KYLIN-4331 Fix noncompliant method names in child class
URL: https://github.com/apache/kylin/pull/1048#issuecomment-572330166
## Pull Request Test Coverage Report for [Build 5494](https://coveralls.io/builds/27992871)
* **0** of **68** **(0.0%)** changed or added relevant lines in **4** files are covered.
* **6** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.004%**) to **27.458%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-cube/src/main/java/org/apache/kylin/cube/gridtable/CuboidToGridTableMappingExt.java](https://coveralls.io/builds/27992871/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fgridtable%2FCuboidToGridTableMappingExt.java#L54) | 0 | 1 | 0.0%
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutableLivy.java](https://coveralls.io/builds/27992871/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutableLivy.java#L180) | 0 | 3 | 0.0%
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java](https://coveralls.io/builds/27992871/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutable.java#L282) | 0 | 12 | 0.0%
| [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/FixedCachedRowSetImpl.java](https://coveralls.io/builds/27992871/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2FFixedCachedRowSetImpl.java#L67) | 0 | 52 | 0.0%
<!-- | **Total:** | **0** | **68** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/27992871/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java](https://coveralls.io/builds/27992871/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutable.java#L83) | 2 | 0.0% |
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutableLivy.java](https://coveralls.io/builds/27992871/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutableLivy.java#L112) | 2 | 0.0% |
<!-- | **Total:** | **6** | | -->
| Totals | [](https://coveralls.io/builds/27992871) |
| :-- | --: |
| Change from base [Build 5493](https://coveralls.io/builds/27972905): | -0.004% |
| Covered Lines: | 24073 |
| Relevant Lines: | 87673 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services