You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "aprimadi (via GitHub)" <gi...@apache.org> on 2023/06/22 06:52:15 UTC
[GitHub] [arrow-datafusion] aprimadi opened a new issue, #6741: RFC: Rename OptimizerConfig to OptimizerContext
aprimadi opened a new issue, #6741:
URL: https://github.com/apache/arrow-datafusion/issues/6741
### Is your feature request related to a problem or challenge?
Following up PR #6706, I think the name `OptimizerConfig` no longer make sense because it contains per-query execution state such as query execution start time and alias generator.
### Describe the solution you'd like
I think `OptimizerConfig` trait should be renamed to `OptimizerContext` and the existing `OptimizerContext` which is a concrete class should be renamed to `OptimizerState`.
### Describe alternatives you've considered
Leave it as it is
### Additional context
cc @alamb @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] aprimadi commented on issue #6741: RFC: Rename OptimizerConfig to OptimizerContext
Posted by "aprimadi (via GitHub)" <gi...@apache.org>.
aprimadi commented on issue #6741:
URL: https://github.com/apache/arrow-datafusion/issues/6741#issuecomment-1602896533
`OptimizerProps` sounds great to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #6741: RFC: Rename OptimizerConfig to OptimizerContext
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6741:
URL: https://github.com/apache/arrow-datafusion/issues/6741#issuecomment-1602626737
`OptimizerProps`?
Or maybe we can start by renaming `OptimizerContext` to `OptimizerState` and then after a release or two we can rename `OptimizerConfig to `OptimizerContext`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #6741: RFC: Rename OptimizerConfig to OptimizerContext
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6741:
URL: https://github.com/apache/arrow-datafusion/issues/6741#issuecomment-1602383119
Makes sense to me too
The one thing I worry about is reusing the `OptimizerContext`
> existing OptimizerContext which is a concrete class should be renamed to OptimizerState.
Which could make an upgrade quite confusing as the errors won't be about a type not being present, but instead will be about it being the wrong class. Maybe we could find a different name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] aprimadi commented on issue #6741: RFC: Rename OptimizerConfig to OptimizerContext
Posted by "aprimadi (via GitHub)" <gi...@apache.org>.
aprimadi commented on issue #6741:
URL: https://github.com/apache/arrow-datafusion/issues/6741#issuecomment-1602554992
@alamb perhaps `OptimizerSession`. That's the closest thing I can think of that preserve the meaning. I'm open to suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on issue #6741: RFC: Rename OptimizerConfig to OptimizerContext
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on issue #6741:
URL: https://github.com/apache/arrow-datafusion/issues/6741#issuecomment-1602139539
> because it contains per-query execution state such as query execution start time and alias generator.
Make sense to me, thank you @aprimadi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org