[GitHub] [ofbiz-framework] PierreSmits commented on pull request #391: Improved: AccountingUiLabels clean-up (OFBIZ-9352)

[GitBox <gi...@apache.org>]

PierreSmits commented on pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391#issuecomment-987908621


   Hi Jacques,
   
   Thank you for taking the time to look back, and see why something came about to be. 
   
   These things, like so many others in the codebase, came to be in there (and this is not to lay blame, just an observation), because at the time it seemed appropriate to bring them in and intended - most probably - to be followed up by the contributor in a next ticket. Or maybe it was part of an implementation at a user's site, but the rest was not allowed to go into the project's codebase or forgotten. But you know, life gets in the way or career takes a turn. 
   
   And the good thing is, nothing is ever lost. So we can clean up when not used together with something else in OFBiz. And if in future some other contributor can make a case for an improvement and bring a past included and removed code element back, good for for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org