[GitHub] gubaojian commented on a change in pull request #1957: * [Android] Add more log for list component's column count.

[GitBox <gi...@apache.org>]

gubaojian commented on a change in pull request #1957: * [Android] Add more log for list component's column count.
URL: https://github.com/apache/incubator-weex/pull/1957#discussion_r243801140
 
 

 ##########
 File path: android/sdk/src/main/java/com/taobao/weex/ui/component/list/WXListComponent.java
 ##########
 @@ -176,6 +175,8 @@ private void updateRecyclerAttr() {
     if (mColumnCount <= 0 && mLayoutType != TYPE_LINEAR_LAYOUT) {
       Map<String, String> ext = new ArrayMap<>();
       ext.put("componentType", getComponentType());
+      ext.put("attribute", getAttrs().toString());
+      ext.put("stackTrace", Arrays.toString(Thread.currentThread().getStackTrace()));
 
 Review comment:
   add a check?  when exceptions happens, then upload the stacktrace?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services