You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/18 07:57:16 UTC

[GitHub] [superset] kgabryje opened a new pull request, #19751: Feat/datapanel redesign

kgabryje opened a new pull request, #19751:
URL: https://github.com/apache/superset/pull/19751

### SUMMARY
This PR implements the redesign of data panel in Explore (below the chart container).

1. Removed the "Data" header that expands/collapses on click
2. Moved expand/collapse functionality to tabs header. When collapsed, clicking on expand button opens tabs showing "Results" by default OR the last active tab before collapsing
3. When collapsed, user can also click on tab name to expand with that tab active
4. When expanded, user can hide the tables by clicking on collapse button OR by clicking on active tab name
5. Moved row count, copy button and search from tabs header to tab content - now they look more in context of currently displayed table
6. Now Results and Samples have separate searches - the search text is no longer shared between those 2 tables
7. Refactored ChartPanel - now we no longer manually calculate widths and heights of chart panel and tables panel. It's all based on css flex.
8. Tables functionality remains unchanged - the request is sent only when the table is activated the first time or there were changes to query

### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="1786" alt="image" src="https://user-images.githubusercontent.com/15073128/163774386-0af6c816-48bf-4362-be70-0cf36fb19054.png">
<img width="1792" alt="image" src="https://user-images.githubusercontent.com/15073128/163774419-642c9a8c-02e2-483f-b433-a6967f0b8c6f.png">

After:
<img width="1792" alt="image" src="https://user-images.githubusercontent.com/15073128/163774600-f224fb39-5de0-4a44-9b55-8f47bf58b815.png">
<img width="1792" alt="image" src="https://user-images.githubusercontent.com/15073128/163774710-9967adf7-6a0f-47a9-9d74-a24554f255f2.png">

### TESTING INSTRUCTIONS
1. Create a chart
2. Verify that collapsing/expanding works as described in PR's summary
3. Verify that copy button and row counter work as before for both results and samples
4. Verify that typing search text in 1 table doesn't affect search filter in second table
5. Verify that chart panel and data table panel don't overflow on each other and scale well when window width changes

### ADDITIONAL INFORMATION


- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API

CC @kasiazjc

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org