You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/02/22 16:28:24 UTC
[GitHub] vdiravka commented on a change in pull request #1651: DRILL-7042:
Fix deb and rpm package issues
vdiravka commented on a change in pull request #1651: DRILL-7042: Fix deb and rpm package issues
URL: https://github.com/apache/drill/pull/1651#discussion_r259411224
##########
File path: distribution/pom.xml
##########
@@ -433,34 +473,67 @@
<plugin>
<artifactId>jdeb</artifactId>
<groupId>org.vafer</groupId>
- <version>1.0</version>
+ <version>1.7</version>
<executions>
<execution>
<phase>package</phase>
<goals>
<goal>jdeb</goal>
</goals>
- <configuration>
+ <configuration>
+ <skipPOMs>false</skipPOMs>
<deb>target/drill-${project.version}.deb</deb>
Review comment:
It will be better to keep all archives in one place. Since tarball archive is already in this directory, please use it for `rpm` and `deb` archives too.
```suggestion
<deb>distribution/target/apache-drill-${project.version}/apache-drill-${project.version}.deb</deb>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services