You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/02 05:44:52 UTC

[GitHub] [spark] pingsutw opened a new pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

pingsutw opened a new pull request #32738:
URL: https://github.com/apache/spark/pull/32738


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error message, please read the guideline first:
        https://spark.apache.org/error-message-guidelines.html
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   Adds more type annotations in the file:
   `python/pyspark/pandas/spark/indexing.py`
   and fixes the mypy check failures.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   We should enable more disallow_untyped_defs mypy checks.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   Yes.
   This PR adds more type annotations in pandas APIs on Spark module, which can impact interaction with development tools for users.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   The mypy check with a new configuration and existing tests should pass.
   `./dev/lint-python`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] pingsutw commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r644495912



##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1246,7 +1255,8 @@ def _select_cols_by_iterable(
                     % (len(cast(Sized, cols_sel)), len(self._internal.column_labels))
                 )
             if isinstance(cols_sel, pd.Series):
-                if not cols_sel.index.sort_values().equals(self._psdf.columns.sort_values()):
+                if not cols_sel.index.sort_values().equals(
+                        self._psdf.columns.sort_values()):  # type: ignore

Review comment:
       Updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853502018






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-855196701


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43887/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853719508


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139282/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853716218


   **[Test build #139282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139282/testReport)** for PR 32738 at commit [`526b3a0`](https://github.com/apache/spark/commit/526b3a02072a76fd12769f9b0157ecdd8f6c6968).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] pingsutw commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r644481542



##########
File path: python/pyspark/pandas/generic.py
##########
@@ -3064,25 +3064,25 @@ def ffill(self, axis=None, inplace=False, limit=None) -> Union["DataFrame", "Ser
 
     @property
     def at(self) -> AtIndexer:
-        return AtIndexer(self)
+        return AtIndexer(self)  # type: ignore

Review comment:
       error: Argument 1 to "AtIndexer" has incompatible type "Frame"; expected "Union[Series[Any], DataFrame[Any]]"

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -514,7 +514,7 @@ def __getitem__(self, key) -> Union["Series", "DataFrame"]:
         except AnalysisException:
             raise KeyError(
                 "[{}] don't exist in columns".format(
-                    [col._jc.toString() for col in data_spark_columns]
+                    [col._jc.toString() for col in data_spark_columns]  # type: ignore

Review comment:
       `error: "Column" not callable`, since we tried to access variable `_jc`

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -608,7 +608,9 @@ def __setitem__(self, key, value):
             if cond is None:
                 cond = F.lit(True)
             if limit is not None:
-                cond = cond & (self._internal.spark_frame[self._sequence_col] < F.lit(limit))
+                cond = cond & (
+                    self._internal.
+                    spark_frame[self._sequence_col] < F.lit(limit))  # type: ignore

Review comment:
       Same here

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1138,7 +1146,8 @@ def _select_rows_else(
         )
 
     def _get_from_multiindex_column(
-        self, key, missing_keys, labels=None, recursed=0
+        self, key: Optional[Tuple], missing_keys: Optional[List[Tuple]],
+            labels: Optional[List[Tuple]] = None, recursed: int = 0

Review comment:
       Updated

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1246,7 +1255,8 @@ def _select_cols_by_iterable(
                     % (len(cast(Sized, cols_sel)), len(self._internal.column_labels))
                 )
             if isinstance(cols_sel, pd.Series):
-                if not cols_sel.index.sort_values().equals(self._psdf.columns.sort_values()):
+                if not cols_sel.index.sort_values().equals(
+                        self._psdf.columns.sort_values()):  # type: ignore

Review comment:
       Updated

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -608,7 +608,9 @@ def __setitem__(self, key, value):
             if cond is None:
                 cond = F.lit(True)
             if limit is not None:
-                cond = cond & (self._internal.spark_frame[self._sequence_col] < F.lit(limit))
+                cond = cond & (
+                    self._internal.
+                    spark_frame[self._sequence_col] < F.lit(limit))  # type: ignore

Review comment:
       `error: "LocIndexerLike" has no attribute "_sequence_col"`

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1146,9 +1146,13 @@ def _select_rows_else(
         )
 
     def _get_from_multiindex_column(
-        self, key: Optional[Tuple], missing_keys: Optional[List[Tuple]],
-            labels: Optional[List[Tuple]] = None, recursed: int = 0
-    ) -> Tuple[List[Tuple], Optional[List[spark.Column]], Any, bool, Optional[Tuple]]:
+        self,
+        key: Optional[Tuple],
+        missing_keys: Optional[List[Tuple]],
+        labels: Optional[List[Tuple]] = None,
+        recursed: int = 0
+    ) -> Tuple[List[Tuple], Optional[List[spark.Column]], Any, bool,
+               Optional[Tuple]]:

Review comment:
       Sure. Thanks for pointing that out.
   I will pay more attention on coding style next time




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857417822


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139539/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-856680859


   **[Test build #139476 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139476/testReport)** for PR 32738 at commit [`db3e0f2`](https://github.com/apache/spark/commit/db3e0f2e872a2b1d907545379f87848225474e24).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] xinrong-databricks commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r644451445



##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1246,7 +1255,8 @@ def _select_cols_by_iterable(
                     % (len(cast(Sized, cols_sel)), len(self._internal.column_labels))
                 )
             if isinstance(cols_sel, pd.Series):
-                if not cols_sel.index.sort_values().equals(self._psdf.columns.sort_values()):
+                if not cols_sel.index.sort_values().equals(
+                        self._psdf.columns.sort_values()):  # type: ignore

Review comment:
       Shall we adjust the indent of this line?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-856699119


   **[Test build #139476 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139476/testReport)** for PR 32738 at commit [`db3e0f2`](https://github.com/apache/spark/commit/db3e0f2e872a2b1d907545379f87848225474e24).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] xinrong-databricks commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-856073322


   You might want to get the latest master changes and retrigger the tests.
   
   Otherwise, LGTM. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ueshin commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
ueshin commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853466259






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857361730


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139526/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853716218


   **[Test build #139282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139282/testReport)** for PR 32738 at commit [`526b3a0`](https://github.com/apache/spark/commit/526b3a02072a76fd12769f9b0157ecdd8f6c6968).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853668789


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43797/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857361730


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139526/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-858191472


   **[Test build #139602 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139602/testReport)** for PR 32738 at commit [`3a79d06`](https://github.com/apache/spark/commit/3a79d0697f6f181e1364108fcae7e327953ad19d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] xinrong-databricks commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r645117776



##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1146,9 +1146,13 @@ def _select_rows_else(
         )
 
     def _get_from_multiindex_column(
-        self, key: Optional[Tuple], missing_keys: Optional[List[Tuple]],
-            labels: Optional[List[Tuple]] = None, recursed: int = 0
-    ) -> Tuple[List[Tuple], Optional[List[spark.Column]], Any, bool, Optional[Tuple]]:
+        self,
+        key: Optional[Tuple],
+        missing_keys: Optional[List[Tuple]],
+        labels: Optional[List[Tuple]] = None,
+        recursed: int = 0
+    ) -> Tuple[List[Tuple], Optional[List[spark.Column]], Any, bool,
+               Optional[Tuple]]:

Review comment:
       nit: Would it be better to put `Optional[Tuple]]` to its previous line?
   `Tuple[List[Tuple], Optional[List[spark.Column]], Any, bool, Optional[Tuple]]:`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853530504


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43773/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857342430


   **[Test build #139526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139526/testReport)** for PR 32738 at commit [`c1747ec`](https://github.com/apache/spark/commit/c1747ec1ede23f3e68f3a1625e0c4ce2fef98f46).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-855195607


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43887/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] xinrong-databricks commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r644451445



##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1246,7 +1255,8 @@ def _select_cols_by_iterable(
                     % (len(cast(Sized, cols_sel)), len(self._internal.column_labels))
                 )
             if isinstance(cols_sel, pd.Series):
-                if not cols_sel.index.sort_values().equals(self._psdf.columns.sort_values()):
+                if not cols_sel.index.sort_values().equals(
+                        self._psdf.columns.sort_values()):  # type: ignore

Review comment:
       Shall we adjust the indent of this line?

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1146,9 +1146,13 @@ def _select_rows_else(
         )
 
     def _get_from_multiindex_column(
-        self, key: Optional[Tuple], missing_keys: Optional[List[Tuple]],
-            labels: Optional[List[Tuple]] = None, recursed: int = 0
-    ) -> Tuple[List[Tuple], Optional[List[spark.Column]], Any, bool, Optional[Tuple]]:
+        self,
+        key: Optional[Tuple],
+        missing_keys: Optional[List[Tuple]],
+        labels: Optional[List[Tuple]] = None,
+        recursed: int = 0
+    ) -> Tuple[List[Tuple], Optional[List[spark.Column]], Any, bool,
+               Optional[Tuple]]:

Review comment:
       nit: Would it be better to put `Optional[Tuple]]` to its previous line?
   `Tuple[List[Tuple], Optional[List[spark.Column]], Any, bool, Optional[Tuple]]:`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-855185233


   **[Test build #139365 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139365/testReport)** for PR 32738 at commit [`b616321`](https://github.com/apache/spark/commit/b61632121f958d1de19da8dd9cacda038eb93600).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-856717754


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139476/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853740669


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43806/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853719459


   **[Test build #139282 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139282/testReport)** for PR 32738 at commit [`526b3a0`](https://github.com/apache/spark/commit/526b3a02072a76fd12769f9b0157ecdd8f6c6968).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853481934


   **[Test build #139249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139249/testReport)** for PR 32738 at commit [`71ebbd8`](https://github.com/apache/spark/commit/71ebbd8ea253e81f6f79ecf1c447cde478fcfd7c).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-855190665


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139365/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857385130


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44051/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853593200


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139272/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853791865


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43806/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857474049


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44063/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] pingsutw commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r645211426



##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1146,9 +1146,13 @@ def _select_rows_else(
         )
 
     def _get_from_multiindex_column(
-        self, key: Optional[Tuple], missing_keys: Optional[List[Tuple]],
-            labels: Optional[List[Tuple]] = None, recursed: int = 0
-    ) -> Tuple[List[Tuple], Optional[List[spark.Column]], Any, bool, Optional[Tuple]]:
+        self,
+        key: Optional[Tuple],
+        missing_keys: Optional[List[Tuple]],
+        labels: Optional[List[Tuple]] = None,
+        recursed: int = 0
+    ) -> Tuple[List[Tuple], Optional[List[spark.Column]], Any, bool,
+               Optional[Tuple]]:

Review comment:
       Sure. Thanks for pointing that out.
   I will pay more attention on coding style next time




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853791865


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43806/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853590541


   **[Test build #139272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139272/testReport)** for PR 32738 at commit [`6d1a050`](https://github.com/apache/spark/commit/6d1a050df5de9ead748ec5de6b1f00b57945106e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ueshin commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r644396086



##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -71,27 +71,27 @@ def __init__(self, psdf_or_psser):
         self._psdf_or_psser = psdf_or_psser
 
     @property
-    def _is_df(self):
+    def _is_df(self) -> bool:
         from pyspark.pandas.frame import DataFrame
 
         return isinstance(self._psdf_or_psser, DataFrame)
 
     @property
-    def _is_series(self):
+    def _is_series(self) -> bool:
         from pyspark.pandas.series import Series
 
         return isinstance(self._psdf_or_psser, Series)
 
     @property
-    def _psdf(self):
+    def _psdf(self) -> "DataFrame":
         if self._is_df:
-            return self._psdf_or_psser
+            return self._psdf_or_psser  # type: ignore

Review comment:
       Could you use `cast` instead of `ignore`?

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -514,7 +514,7 @@ def __getitem__(self, key) -> Union["Series", "DataFrame"]:
         except AnalysisException:
             raise KeyError(
                 "[{}] don't exist in columns".format(
-                    [col._jc.toString() for col in data_spark_columns]
+                    [col._jc.toString() for col in data_spark_columns]  # type: ignore

Review comment:
       ditto.

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -608,7 +608,9 @@ def __setitem__(self, key, value):
             if cond is None:
                 cond = F.lit(True)
             if limit is not None:
-                cond = cond & (self._internal.spark_frame[self._sequence_col] < F.lit(limit))
+                cond = cond & (
+                    self._internal.
+                    spark_frame[self._sequence_col] < F.lit(limit))  # type: ignore

Review comment:
       ditto.

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -174,7 +174,7 @@ def __getitem__(self, key) -> Union["Series", "DataFrame", Scalar]:
         if len(pdf) < 1:
             raise KeyError(name_like_string(row_sel))
 
-        values = pdf.iloc[:, 0].values
+        values = pdf.iloc[:, 0].values  # type: ignore

Review comment:
       I guess `values = cast(pd.DataFrame, pdf).iloc[:, 0].values`?
   or we should cast right after `toPandas()` above?

##########
File path: python/pyspark/pandas/generic.py
##########
@@ -3064,25 +3064,25 @@ def ffill(self, axis=None, inplace=False, limit=None) -> Union["DataFrame", "Ser
 
     @property
     def at(self) -> AtIndexer:
-        return AtIndexer(self)
+        return AtIndexer(self)  # type: ignore

Review comment:
       Do we need the `ignore`? What happens without it?

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -445,7 +445,7 @@ def __getitem__(self, key) -> Union["Series", "DataFrame"]:
 
             if isinstance(rows_sel, Series) and not same_anchor(rows_sel, self._psdf_or_psser):
                 psdf = self._psdf_or_psser.copy()
-                temp_col = verify_temp_column_name(psdf, "__temp_col__")
+                temp_col = verify_temp_column_name(psdf, "__temp_col__")  # type: ignore

Review comment:
       What happens without `ignore?

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -685,13 +691,15 @@ def __setitem__(self, key, value):
                 return
 
             cond, limit, remaining_index = self._select_rows(rows_sel)
-            missing_keys = []
+            missing_keys: Optional[List[Tuple]] = []

Review comment:
       Shall we use a comment style annotation for now?
   ```py
   ... = []  # type: Optional[List[Tuple]]
   ```

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1138,7 +1146,8 @@ def _select_rows_else(
         )
 
     def _get_from_multiindex_column(
-        self, key, missing_keys, labels=None, recursed=0
+        self, key: Optional[Tuple], missing_keys: Optional[List[Tuple]],
+            labels: Optional[List[Tuple]] = None, recursed: int = 0

Review comment:
       The style seems weird?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ueshin commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
ueshin commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853466259


   ok to test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-855190665


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139365/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857452732


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44063/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857417822


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139539/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ueshin commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r646862666



##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -685,13 +691,15 @@ def __setitem__(self, key, value):
                 return
 
             cond, limit, remaining_index = self._select_rows(rows_sel)
-            missing_keys = []
+            missing_keys = []  # type: Optional[List[Tuple]]
             _, data_spark_columns, _, _, _ = self._select_cols(cols_sel, missing_keys=missing_keys)
 
             if cond is None:
                 cond = F.lit(True)
             if limit is not None:
-                cond = cond & (self._internal.spark_frame[self._sequence_col] < F.lit(limit))
+                cond = cond & (
+                    self._internal.
+                    spark_frame[self._sequence_col] < F.lit(limit))  # type: ignore

Review comment:
       ditto.

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -656,16 +658,20 @@ def __setitem__(self, key, value):
                 and (isinstance(self, iLocIndexer) or not same_anchor(value, self._psdf_or_psser))
             ):
                 psdf = self._psdf_or_psser.copy()

Review comment:
       We can use `cast` for `psdf`, then we can remove `ignore` in the following lines.

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -61,7 +61,7 @@
 
 
 class IndexerLike(object):
-    def __init__(self, psdf_or_psser):
+    def __init__(self, psdf_or_psser: Union["Series", "DataFrame"]) -> None:

Review comment:
       nit: we don't need `-> None` for `__init__`.

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -608,7 +608,9 @@ def __setitem__(self, key, value):
             if cond is None:
                 cond = F.lit(True)
             if limit is not None:
-                cond = cond & (self._internal.spark_frame[self._sequence_col] < F.lit(limit))
+                cond = cond & (
+                    self._internal.
+                    spark_frame[self._sequence_col] < F.lit(limit))  # type: ignore

Review comment:
       Here `self` must always be `iLocIndexer` so you can use `cast`.
   `cast(iLocIndexer, self)._sequence_col`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-858191472


   **[Test build #139602 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139602/testReport)** for PR 32738 at commit [`3a79d06`](https://github.com/apache/spark/commit/3a79d0697f6f181e1364108fcae7e327953ad19d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] pingsutw commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857444741


   @ueshin, @xinrong-databricks Thanks for the review. I've updated the PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853593200


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139272/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853791837


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43806/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-856680859


   **[Test build #139476 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139476/testReport)** for PR 32738 at commit [`db3e0f2`](https://github.com/apache/spark/commit/db3e0f2e872a2b1d907545379f87848225474e24).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-858210415


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139602/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ueshin removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
ueshin removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853467375


   add to whitelist


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857385130


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44051/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853593163


   **[Test build #139272 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139272/testReport)** for PR 32738 at commit [`6d1a050`](https://github.com/apache/spark/commit/6d1a050df5de9ead748ec5de6b1f00b57945106e).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-856717754


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139476/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-856762111


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43999/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853491404


   **[Test build #139249 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139249/testReport)** for PR 32738 at commit [`71ebbd8`](https://github.com/apache/spark/commit/71ebbd8ea253e81f6f79ecf1c447cde478fcfd7c).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-856736790


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43999/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853506877


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43772/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] pingsutw commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r644493906



##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1138,7 +1146,8 @@ def _select_rows_else(
         )
 
     def _get_from_multiindex_column(
-        self, key, missing_keys, labels=None, recursed=0
+        self, key: Optional[Tuple], missing_keys: Optional[List[Tuple]],
+            labels: Optional[List[Tuple]] = None, recursed: int = 0

Review comment:
       Updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857405381


   **[Test build #139539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139539/testReport)** for PR 32738 at commit [`054660e`](https://github.com/apache/spark/commit/054660ec8c03d1ada5161ec7ce0d0a72eecb8e8f).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857366829


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44051/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-852757735


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-855196701


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43887/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] xinrong-databricks commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r645705950



##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1146,9 +1146,13 @@ def _select_rows_else(
         )
 
     def _get_from_multiindex_column(
-        self, key: Optional[Tuple], missing_keys: Optional[List[Tuple]],
-            labels: Optional[List[Tuple]] = None, recursed: int = 0
-    ) -> Tuple[List[Tuple], Optional[List[spark.Column]], Any, bool, Optional[Tuple]]:
+        self,
+        key: Optional[Tuple],
+        missing_keys: Optional[List[Tuple]],
+        labels: Optional[List[Tuple]] = None,
+        recursed: int = 0
+    ) -> Tuple[List[Tuple], Optional[List[spark.Column]], Any, bool,
+               Optional[Tuple]]:

Review comment:
       Thank you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-855191839


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43887/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853590541


   **[Test build #139272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139272/testReport)** for PR 32738 at commit [`6d1a050`](https://github.com/apache/spark/commit/6d1a050df5de9ead748ec5de6b1f00b57945106e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857354554


   **[Test build #139526 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139526/testReport)** for PR 32738 at commit [`c1747ec`](https://github.com/apache/spark/commit/c1747ec1ede23f3e68f3a1625e0c4ce2fef98f46).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857387251


   **[Test build #139539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139539/testReport)** for PR 32738 at commit [`054660e`](https://github.com/apache/spark/commit/054660ec8c03d1ada5161ec7ce0d0a72eecb8e8f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857381187


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44051/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-856762111


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43999/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ueshin commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
ueshin commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-858317725


   Thanks! merging to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853506892


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43772/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-858216087


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44129/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853719508


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139282/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-852757735






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853481934






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ueshin commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
ueshin commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853467375


   add to whitelist


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853502018


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139249/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853495334


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43772/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-858216107


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44129/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857387251


   **[Test build #139539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139539/testReport)** for PR 32738 at commit [`054660e`](https://github.com/apache/spark/commit/054660ec8c03d1ada5161ec7ce0d0a72eecb8e8f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853668789


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43797/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853619841


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43797/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ueshin commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r648666568



##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -685,7 +687,7 @@ def __setitem__(self, key, value):
                     psdf[temp_key_col] = rows_sel
                 if isinstance(value, Series):
                     psdf[temp_value_col] = value
-                psdf = psdf.sort_values(temp_natural_order).drop(temp_natural_order)
+                psdf = psdf.sort_values(temp_natural_order).drop(temp_natural_order)  # type: ignore

Review comment:
       nit: seems like we don't need `ignore` here.

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1802,7 +1810,7 @@ def __setitem__(self, key, value):
                         )
         super().__setitem__(key, value)
         # Update again with resolved_copy to drop extra columns.
-        self._psdf._update_internal_frame(
+        self._psdf._update_internal_frame(  # type: ignore

Review comment:
       nit: seems like we don't need `ignore` here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857342430


   **[Test build #139526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139526/testReport)** for PR 32738 at commit [`c1747ec`](https://github.com/apache/spark/commit/c1747ec1ede23f3e68f3a1625e0c4ce2fef98f46).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-856713621


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43999/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ueshin commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r644396086



##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -71,27 +71,27 @@ def __init__(self, psdf_or_psser):
         self._psdf_or_psser = psdf_or_psser
 
     @property
-    def _is_df(self):
+    def _is_df(self) -> bool:
         from pyspark.pandas.frame import DataFrame
 
         return isinstance(self._psdf_or_psser, DataFrame)
 
     @property
-    def _is_series(self):
+    def _is_series(self) -> bool:
         from pyspark.pandas.series import Series
 
         return isinstance(self._psdf_or_psser, Series)
 
     @property
-    def _psdf(self):
+    def _psdf(self) -> "DataFrame":
         if self._is_df:
-            return self._psdf_or_psser
+            return self._psdf_or_psser  # type: ignore

Review comment:
       Could you use `cast` instead of `ignore`?

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -514,7 +514,7 @@ def __getitem__(self, key) -> Union["Series", "DataFrame"]:
         except AnalysisException:
             raise KeyError(
                 "[{}] don't exist in columns".format(
-                    [col._jc.toString() for col in data_spark_columns]
+                    [col._jc.toString() for col in data_spark_columns]  # type: ignore

Review comment:
       ditto.

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -608,7 +608,9 @@ def __setitem__(self, key, value):
             if cond is None:
                 cond = F.lit(True)
             if limit is not None:
-                cond = cond & (self._internal.spark_frame[self._sequence_col] < F.lit(limit))
+                cond = cond & (
+                    self._internal.
+                    spark_frame[self._sequence_col] < F.lit(limit))  # type: ignore

Review comment:
       ditto.

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -174,7 +174,7 @@ def __getitem__(self, key) -> Union["Series", "DataFrame", Scalar]:
         if len(pdf) < 1:
             raise KeyError(name_like_string(row_sel))
 
-        values = pdf.iloc[:, 0].values
+        values = pdf.iloc[:, 0].values  # type: ignore

Review comment:
       I guess `values = cast(pd.DataFrame, pdf).iloc[:, 0].values`?
   or we should cast right after `toPandas()` above?

##########
File path: python/pyspark/pandas/generic.py
##########
@@ -3064,25 +3064,25 @@ def ffill(self, axis=None, inplace=False, limit=None) -> Union["DataFrame", "Ser
 
     @property
     def at(self) -> AtIndexer:
-        return AtIndexer(self)
+        return AtIndexer(self)  # type: ignore

Review comment:
       Do we need the `ignore`? What happens without it?

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -445,7 +445,7 @@ def __getitem__(self, key) -> Union["Series", "DataFrame"]:
 
             if isinstance(rows_sel, Series) and not same_anchor(rows_sel, self._psdf_or_psser):
                 psdf = self._psdf_or_psser.copy()
-                temp_col = verify_temp_column_name(psdf, "__temp_col__")
+                temp_col = verify_temp_column_name(psdf, "__temp_col__")  # type: ignore

Review comment:
       What happens without `ignore?

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -685,13 +691,15 @@ def __setitem__(self, key, value):
                 return
 
             cond, limit, remaining_index = self._select_rows(rows_sel)
-            missing_keys = []
+            missing_keys: Optional[List[Tuple]] = []

Review comment:
       Shall we use a comment style annotation for now?
   ```py
   ... = []  # type: Optional[List[Tuple]]
   ```

##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1138,7 +1146,8 @@ def _select_rows_else(
         )
 
     def _get_from_multiindex_column(
-        self, key, missing_keys, labels=None, recursed=0
+        self, key: Optional[Tuple], missing_keys: Optional[List[Tuple]],
+            labels: Optional[List[Tuple]] = None, recursed: int = 0

Review comment:
       The style seems weird?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853530526


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43773/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853502018


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139249/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853642984


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43797/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-858216107


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44129/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853497285


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43773/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] pingsutw commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r644490173



##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -608,7 +608,9 @@ def __setitem__(self, key, value):
             if cond is None:
                 cond = F.lit(True)
             if limit is not None:
-                cond = cond & (self._internal.spark_frame[self._sequence_col] < F.lit(limit))
+                cond = cond & (
+                    self._internal.
+                    spark_frame[self._sequence_col] < F.lit(limit))  # type: ignore

Review comment:
       `error: "LocIndexerLike" has no attribute "_sequence_col"`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-858204750


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44129/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ueshin closed pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
ueshin closed pull request #32738:
URL: https://github.com/apache/spark/pull/32738


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-858210415


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139602/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853481934






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-855185233


   **[Test build #139365 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139365/testReport)** for PR 32738 at commit [`b616321`](https://github.com/apache/spark/commit/b61632121f958d1de19da8dd9cacda038eb93600).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-858199814


   **[Test build #139602 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139602/testReport)** for PR 32738 at commit [`3a79d06`](https://github.com/apache/spark/commit/3a79d0697f6f181e1364108fcae7e327953ad19d).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ueshin removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
ueshin removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853467375


   add to whitelist


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853506892


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43772/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-855187712


   **[Test build #139365 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139365/testReport)** for PR 32738 at commit [`b616321`](https://github.com/apache/spark/commit/b61632121f958d1de19da8dd9cacda038eb93600).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] pingsutw commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r644490173



##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -608,7 +608,9 @@ def __setitem__(self, key, value):
             if cond is None:
                 cond = F.lit(True)
             if limit is not None:
-                cond = cond & (self._internal.spark_frame[self._sequence_col] < F.lit(limit))
+                cond = cond & (
+                    self._internal.
+                    spark_frame[self._sequence_col] < F.lit(limit))  # type: ignore

Review comment:
       Same here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] pingsutw commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r644481542



##########
File path: python/pyspark/pandas/generic.py
##########
@@ -3064,25 +3064,25 @@ def ffill(self, axis=None, inplace=False, limit=None) -> Union["DataFrame", "Ser
 
     @property
     def at(self) -> AtIndexer:
-        return AtIndexer(self)
+        return AtIndexer(self)  # type: ignore

Review comment:
       error: Argument 1 to "AtIndexer" has incompatible type "Frame"; expected "Union[Series[Any], DataFrame[Any]]"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] pingsutw commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r644489741



##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -514,7 +514,7 @@ def __getitem__(self, key) -> Union["Series", "DataFrame"]:
         except AnalysisException:
             raise KeyError(
                 "[{}] don't exist in columns".format(
-                    [col._jc.toString() for col in data_spark_columns]
+                    [col._jc.toString() for col in data_spark_columns]  # type: ignore

Review comment:
       `error: "Column" not callable`, since we tried to access variable `_jc`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-852757735


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853481934


   **[Test build #139249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139249/testReport)** for PR 32738 at commit [`71ebbd8`](https://github.com/apache/spark/commit/71ebbd8ea253e81f6f79ecf1c447cde478fcfd7c).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-853530526


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43773/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857494778


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44063/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32738:
URL: https://github.com/apache/spark/pull/32738#issuecomment-857494778


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44063/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org