[jira] [Work logged] (HIVE-27198) Delete directly aborted transactions instead of select and loading ids

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-27198?focusedWorklogId=853948&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-853948 ]

ASF GitHub Bot logged work on HIVE-27198:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Mar/23 14:39
            Start Date: 30/Mar/23 14:39
    Worklog Time Spent: 10m 
      Work Description: maheshrajus opened a new pull request, #4174:
URL: https://github.com/apache/hive/pull/4174

   
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   Delete directly aborted transactions instead of select and loading ids into memory.
   ### Why are the changes needed?
   select needs to be eliminated and the delete should work with the where clause instead of the built in clause.
   we can see no reason for loading the ids into memory and then generate a huge sql.
   
   ### Does this PR introduce _any_ user-facing change?
   NO
   
   
   
   ### How was this patch tested?
   CI run/UT tests
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 853948)
    Remaining Estimate: 0h
            Time Spent: 10m

> Delete directly aborted transactions instead of select and loading ids
> ----------------------------------------------------------------------
>
>                 Key: HIVE-27198
>                 URL: https://issues.apache.org/jira/browse/HIVE-27198
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Mahesh Raju Somalaraju
>            Assignee: Mahesh Raju Somalaraju
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> in cleaning the aborted transaction , we can directly deletes the txns instead of selecting and process.
> method name: 
> cleanEmptyAbortedAndCommittedTxns
> Code:
> String s = "SELECT \"TXN_ID\" FROM \"TXNS\" WHERE " +
> "\"TXN_ID\" NOT IN (SELECT \"TC_TXNID\" FROM \"TXN_COMPONENTS\") AND " +
> " (\"TXN_STATE\" = " + TxnStatus.ABORTED + " OR \"TXN_STATE\" = " + TxnStatus.COMMITTED + ") AND "
> + " \"TXN_ID\" < " + lowWaterMark;
>  
> proposed code:
> String s = "DELETE \"TXN_ID\" FROM \"TXNS\" WHERE " +
> "\"TXN_ID\" NOT IN (SELECT \"TC_TXNID\" FROM \"TXN_COMPONENTS\") AND " +
> " (\"TXN_STATE\" = " + TxnStatus.ABORTED + " OR \"TXN_STATE\" = " + TxnStatus.COMMITTED + ") AND "
> + " \"TXN_ID\" < " + lowWaterMark;
>  
> the select needs to be eliminated and the delete should work with the where clause instead of the built in clause
> we can see no reason for loading the ids into memory and then generate a huge sql
>  
> Bathcing is also not necessary here, we can deletes the records directly



--
This message was sent by Atlassian Jira
(v8.20.10#820010)