You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey A. Ivanov (JIRA)" <ji...@apache.org> on 2007/03/16 09:48:09 UTC

[jira] Created: (HARMONY-3408) [classlib][swing] CSS parser are not to be internationalized

[classlib][swing] CSS parser are not to be internationalized
------------------------------------------------------------

                 Key: HARMONY-3408
                 URL: https://issues.apache.org/jira/browse/HARMONY-3408
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Alexey A. Ivanov
            Priority: Minor


Do not internationalize source files in org.apache.harmony.x.swing.text.html.cssparser package, as specified in the first line of the files. They are auto-generated from CSSGrammar.jj. In case the grammar is changed, all the modifications will be lost.

A user should never see any of the exceptions which may be thrown by the parser: they are intended for developers only. Since CSS must be parsed with ignoring of all the errors, there's special error-handling code in the parser which handles parsing errors and restores the parser state so that it can parse the rest of the file. Currently all CSS parsing errors are logged through CSSLogger to System.err. Logging can be disabled in CSSLogger file. After everything works fine, logging can be removed at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3408) [classlib][swing] CSS parser is not to be internationalized

Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481525 ] 

Alexey A. Ivanov commented on HARMONY-3408:
-------------------------------------------

CSSLogger can be kept internationalized since it's not auto-generated.

> [classlib][swing] CSS parser is not to be internationalized
> -----------------------------------------------------------
>
>                 Key: HARMONY-3408
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3408
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey A. Ivanov
>            Priority: Minor
>
> Do not internationalize source files in org.apache.harmony.x.swing.text.html.cssparser package, as specified in the first line of the files. They are auto-generated from CSSGrammar.jj. In case the grammar is changed, all the modifications will be lost.
> A user should never see any of the exceptions which may be thrown by the parser: they are intended for developers only. Since CSS must be parsed with ignoring of all the errors, there's special error-handling code in the parser which handles parsing errors and restores the parser state so that it can parse the rest of the file. Currently all CSS parsing errors are logged through CSSLogger to System.err. Logging can be disabled in CSSLogger file. After everything works fine, logging can be removed at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3408) [classlib][swing] CSS parser is not to be internationalized

Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey A. Ivanov updated HARMONY-3408:
--------------------------------------

    Summary: [classlib][swing] CSS parser is not to be internationalized  (was: [classlib][swing] CSS parser are not to be internationalized)

> [classlib][swing] CSS parser is not to be internationalized
> -----------------------------------------------------------
>
>                 Key: HARMONY-3408
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3408
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey A. Ivanov
>            Priority: Minor
>
> Do not internationalize source files in org.apache.harmony.x.swing.text.html.cssparser package, as specified in the first line of the files. They are auto-generated from CSSGrammar.jj. In case the grammar is changed, all the modifications will be lost.
> A user should never see any of the exceptions which may be thrown by the parser: they are intended for developers only. Since CSS must be parsed with ignoring of all the errors, there's special error-handling code in the parser which handles parsing errors and restores the parser state so that it can parse the rest of the file. Currently all CSS parsing errors are logged through CSSLogger to System.err. Logging can be disabled in CSSLogger file. After everything works fine, logging can be removed at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.