[jira] [Commented] (GIRAPH-996) Large requests degrade performance. Print out warnings.

["Maja Kabiljo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345567#comment-14345567 ] 

Maja Kabiljo commented on GIRAPH-996:
-------------------------------------

Thanks for working on this, Dionysios.
This is most often the problem with aggregators, and I think it makes the most sense to put checks in NettyClient.sendWritableRequest to cover all, and print the type of request in the error message. Now that I'm looking I'm not sure why values of CLIENT_SEND_BUFFER_SIZE and CLIENT_RECEIVE_BUFFER_SIZE are different (and increasing receive buffer size might help with this issue and performance overall - we should run an experiment), but that could be the value to use. 
Reading values from the conf is an expensive operation, so we always pull out what we need in constructor/setConf so we don't need to read it on every method call.

> Large requests degrade performance. Print out warnings.
> -------------------------------------------------------
>
>                 Key: GIRAPH-996
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-996
>             Project: Giraph
>          Issue Type: Task
>            Reporter: Dionysios Logothetis
>            Assignee: Dionysios Logothetis
>            Priority: Minor
>         Attachments: GIRAPH-996.patch
>
>
> Sometimes performance degrades significantly or a job starts using too much off heap memory when requests larger than expected are being sent through netty. We should print warnings when large requests are sent, and also send warnings to command line to make sure users notice them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)