You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/06/28 12:25:52 UTC
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
lipenglin@sensorsdata.cn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18675
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
In the FOR SYSTEM_TIME AS OF clause we expect timestamps in the local
timezone, while the error message shows the timestamp in UTC timezone.
The error message should show timestamp in local timezone.
Testing:
- Add e2e test
Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
---
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
2 files changed, 28 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/18675/1
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
Patch Set 1:
(2 comments)
Thanks for working on this!
http://gerrit.cloudera.org:8080/#/c/18675/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:
http://gerrit.cloudera.org:8080/#/c/18675/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@100
PS1, Line 100: "
Can we include the timezone as well? As this will output the timestamp in the local timezone of the impala server. But users might be in a different timezone, and set their local timezone in the query option TIMEZONE. Which means that the timestamp in the FOR SYSTEM_TIME AS OF <ts> is in the local timezone of the user.
We can also keep the timezone in the error message in UTC if we include the timezone information. If we do this, then we must set the query option TIMEZONE (to an arbitrary timezone other than UTC) in the test, otherwise the behavior will depend on where the test is being executed.
http://gerrit.cloudera.org:8080/#/c/18675/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@572
PS1, Line 572: IllegalArgumentException
This has the assumption that the IllegalArgumentException is always because of this type of error. Maybe it's not too bad because the SQL11 standard says that time travel queries referring to future dates should return the current state. I.e. the only problem with the parameter is that if it is older than the first snapshot.
But still, maybe it would make sense to also try to fix the error message in the Iceberg repo? If the Iceberg community is not open to fix the error message we can still fix in Impala.
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Jun 2022 09:06:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
Patch Set 5:
(1 comment)
Nice CodereView！
http://gerrit.cloudera.org:8080/#/c/18675/4/fe/src/main/java/org/apache/impala/analysis/TimeTravelSpec.java
File fe/src/main/java/org/apache/impala/analysis/TimeTravelSpec.java:
http://gerrit.cloudera.org:8080/#/c/18675/4/fe/src/main/java/org/apache/impala/analysis/TimeTravelSpec.java@120
PS4, Line 120: }
> https://gerrit.cloudera.org/#/c/9986/ added support for custom timezone dat
That`s great! Thank you very much for your idea.
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 08:06:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18675/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:
http://gerrit.cloudera.org:8080/#/c/18675/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@100
PS1, Line 100:
> Can we include the timezone as well? As this will output the timestamp in t
Done
http://gerrit.cloudera.org:8080/#/c/18675/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@572
PS1, Line 572:
> This has the assumption that the IllegalArgumentException is always because
I will try to open an issue in Iceberg community.
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Jun 2022 12:45:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
Patch Set 5:
Nice CodereView!
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 08:06:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10895/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Jun 2022 12:43:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
In the FOR SYSTEM_TIME AS OF clause we expect timestamps in the local
timezone, while the error message shows the timestamp in UTC timezone.
The error message should show timestamp in local timezone.
Testing:
- Add e2e test
Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Reviewed-on: http://gerrit.cloudera.org:8080/18675
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/TimeTravelSpec.java
M fe/src/main/java/org/apache/impala/util/ExprUtil.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
4 files changed, 88 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 18:31:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10902/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 07:46:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
Patch Set 5: Code-Review+2
Nice work! Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 13:48:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18675/4/fe/src/main/java/org/apache/impala/analysis/TimeTravelSpec.java
File fe/src/main/java/org/apache/impala/analysis/TimeTravelSpec.java:
http://gerrit.cloudera.org:8080/#/c/18675/4/fe/src/main/java/org/apache/impala/analysis/TimeTravelSpec.java@120
PS4, Line 120: timeZoneId_ = ZoneId.of(analyzer.getQueryCtx().getLocal_time_zone());
https://gerrit.cloudera.org/#/c/9986/ added support for custom timezone databases and timezone aliases, but it is only for the C++ backend, Java uses its own timezone database.
One problem could be if the specified timezone is not known by the Java timezone database. Maybe we can just catch the exception and fallback to UTC. I'm OK with that solution.
Other problem can be, which is probably unlikely is that there's inconsistency between the Java timezone database and Impala backend's database.
Probably the best solution to these problems is that if we let the backend do the conversions. An example to that can be seen here: https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/util/ExprUtil.java#L42-L47
So we need to construct something like the following:
from_utc_timestamp(cast('<UTC timestamp literal>' as timestamp), '<user's local timezone>');
E.g.:
from_utc_timestamp(cast('2022-06-29 18:12:31.829776000' as timestamp), 'Asia/Shanghai');
Might need to add a cast expression to STRING on top of it, so it will be easy to output the resulting TColumnValue.
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Jun 2022 16:30:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8281/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 13:49:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 13:49:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10890/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jun 2022 12:45:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
In the FOR SYSTEM_TIME AS OF clause we expect timestamps in the local
timezone, while the error message shows the timestamp in UTC timezone.
The error message should show timestamp in local timezone.
Testing:
- Add e2e test
Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
---
M fe/src/main/java/org/apache/impala/analysis/TimeTravelSpec.java
M fe/src/main/java/org/apache/impala/util/ExprUtil.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
4 files changed, 88 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/18675/5
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18675 )
Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
......................................................................
IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone
In the FOR SYSTEM_TIME AS OF clause we expect timestamps in the local
timezone, while the error message shows the timestamp in UTC timezone.
The error message should show timestamp in local timezone.
Testing:
- Add e2e test
Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
---
M fe/src/main/java/org/apache/impala/analysis/TimeTravelSpec.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
3 files changed, 49 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/18675/4
--
To view, visit http://gerrit.cloudera.org:8080/18675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba5d5eb65133f11cc4eb2fc15a19f7b25c14cc46
Gerrit-Change-Number: 18675
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>