You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/10/09 12:47:16 UTC

[GitHub] [lucene] rmuir commented on pull request #360: LUCENE-10155: Refactor TestMultiMMap into a BaseChunkedDirectoryTestCase

rmuir commented on pull request #360:
URL: https://github.com/apache/lucene/pull/360#issuecomment-939291709


   I removed the custom pkg-private ctor for testing. Added constants for min/max values. Added some javadocs for the ctors and some tests for the illegal values. `expectThrows` was mysteriously missing, it was because the test didnt extend LuceneTestCase, I addressed that too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org