You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by tz...@apache.org on 2022/03/16 03:25:53 UTC
[apisix-java-plugin-runner] branch main updated: refactor: rename the name of the function that gets all the headers to 'getHeaders'. (#132)
This is an automated email from the ASF dual-hosted git repository.
tzssangglass pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/apisix-java-plugin-runner.git
The following commit(s) were added to refs/heads/main by this push:
new 35159bb refactor: rename the name of the function that gets all the headers to 'getHeaders'. (#132)
35159bb is described below
commit 35159bb2661e54bf984625ac94b49d7fd06da46f
Author: 123liubao <87...@users.noreply.github.com>
AuthorDate: Wed Mar 16 11:25:16 2022 +0800
refactor: rename the name of the function that gets all the headers to 'getHeaders'. (#132)
---
.../org/apache/apisix/plugin/runner/handler/HTTPReqCallHandler.java | 2 +-
.../apache/apisix/plugin/runner/handler/A6HttpCallHandlerTest.java | 4 ++--
.../src/main/java/org/apache/apisix/plugin/runner/HttpRequest.java | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/HTTPReqCallHandler.java b/runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/HTTPReqCallHandler.java
index 2152703..f28d3fa 100644
--- a/runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/HTTPReqCallHandler.java
+++ b/runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/HTTPReqCallHandler.java
@@ -199,7 +199,7 @@ public class HTTPReqCallHandler extends SimpleChannelInboundHandler<A6Request> {
}
private void preReadReq() {
- currReq.getHeader();
+ currReq.getHeaders();
currReq.getPath();
currReq.getMethod();
currReq.getArgs();
diff --git a/runner-core/src/test/java/org/apache/apisix/plugin/runner/handler/A6HttpCallHandlerTest.java b/runner-core/src/test/java/org/apache/apisix/plugin/runner/handler/A6HttpCallHandlerTest.java
index 114942c..7967059 100644
--- a/runner-core/src/test/java/org/apache/apisix/plugin/runner/handler/A6HttpCallHandlerTest.java
+++ b/runner-core/src/test/java/org/apache/apisix/plugin/runner/handler/A6HttpCallHandlerTest.java
@@ -99,8 +99,8 @@ class A6HttpCallHandlerTest {
}
}
- if (!Objects.isNull(request.getHeader())) {
- for (Map.Entry<String, String> header : request.getHeader().entrySet()) {
+ if (!Objects.isNull(request.getHeaders())) {
+ for (Map.Entry<String, String> header : request.getHeaders().entrySet()) {
System.out.println("do filter: header key: " + header.getKey());
System.out.println("do filter: header value: " + header.getValue());
}
diff --git a/runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/HttpRequest.java b/runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/HttpRequest.java
index d4f75b4..896a911 100644
--- a/runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/HttpRequest.java
+++ b/runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/HttpRequest.java
@@ -138,7 +138,7 @@ public class HttpRequest implements A6Request {
*
* @return the all headers
*/
- public Map<String, String> getHeader() {
+ public Map<String, String> getHeaders() {
if (Objects.isNull(headers)) {
headers = new HashMap<>();
for (int i = 0; i < req.headersLength(); i++) {
@@ -164,7 +164,7 @@ public class HttpRequest implements A6Request {
* @return the header value or null
*/
public String getHeader(String headerName) {
- Map<String, String> headers = getHeader();
+ Map<String, String> headers = getHeaders();
if (!CollectionUtils.isEmpty(headers)) {
for (Map.Entry<String, String> header : headers.entrySet()) {
if (header.getKey().equals(headerName)) {