You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "howardjohn (via GitHub)" <gi...@apache.org> on 2023/04/26 20:40:17 UTC
[GitHub] [dubbo] howardjohn opened a new issue, #12201: dubbo-xds: remove Istio first-party-jwt dependency
howardjohn opened a new issue, #12201:
URL: https://github.com/apache/dubbo/issues/12201
This is considered legacy in Istio and upstream is looking into removal: https://github.com/istio/istio/issues/44585.
Can you help give some insight on the requirement for this in dubbo and if it can be dropped?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #12201: dubbo-xds: remove Istio first-party-jwt dependency
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #12201:
URL: https://github.com/apache/dubbo/issues/12201#issuecomment-1529034818
> Istio already has a mechanism to inject arbitrary things, including the token into the app container. Similar example: https://github.com/istio/istio/blob/6e6dd6424d16331678ba11615a678a0c12f3508f/manifests/charts/istio-control/istio-discovery/files/grpc-simple.yaml#L49
This configuration is great and can solve most problems. However, I still have a question that the parameters injected by this template currently seem to be a bit "framework bound". This template looks like it has a one-to-one correspondence with the gRPC configuration. Or is it possible to provide a more general injection template in istio?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] howardjohn commented on issue #12201: dubbo-xds: remove Istio first-party-jwt dependency
Posted by "howardjohn (via GitHub)" <gi...@apache.org>.
howardjohn commented on issue #12201:
URL: https://github.com/apache/dubbo/issues/12201#issuecomment-1529802131
Sorry for the confusion. The template is just an example one for gRPC (note this one is problematic, as it disables auth entirely, which is being worked on. But just an example of how injection can be used even without a sidecar)
https://istio.io/latest/docs/setup/additional-setup/sidecar-injection/#custom-templates-experimental shows how you can add completely arbitrary templates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #12201: dubbo-xds: remove Istio first-party-jwt dependency
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #12201:
URL: https://github.com/apache/dubbo/issues/12201#issuecomment-1531178455
The template configuration seems meet our needs. @aamingaa @CrazyHZM What do you think?
BTW, is it possible to provide dubbo's templates by default in istio. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #12201: dubbo-xds: remove Istio first-party-jwt dependency
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #12201:
URL: https://github.com/apache/dubbo/issues/12201#issuecomment-1525236842
The reason Dubbo needs first-party-jwt is that right now istio doesn't support injecting these configurations into Dubbo deployments. I think we can remove it after we have a nice way to inject templates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] howardjohn commented on issue #12201: dubbo-xds: remove Istio first-party-jwt dependency
Posted by "howardjohn (via GitHub)" <gi...@apache.org>.
howardjohn commented on issue #12201:
URL: https://github.com/apache/dubbo/issues/12201#issuecomment-1525827321
Istio already has a mechanism to inject arbitrary things, including the token into the app container. Similar example: https://github.com/istio/istio/blob/6e6dd6424d16331678ba11615a678a0c12f3508f/manifests/charts/istio-control/istio-discovery/files/grpc-simple.yaml#L49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org