You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/11 11:37:46 UTC

[GitHub] [apisix-ingress-controller] Chever-John opened a new pull request, #959: feat: fix the e2e test case of the server-info plugin for APISIX v2.13

Chever-John opened a new pull request, #959:
URL: https://github.com/apache/apisix-ingress-controller/pull/959

   <!-- Please answer these questions before submitting a pull request -->
   
   fix the e2e test case of the server-info plugin for APISIX v2.13 
   
   ### Type of change:
   
   <!-- Please delete options that are not relevant. -->
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   <!--
   Please follow the requirements:
   1. Use Draft if the PR is not ready to be reviewed
   2. Test is required for the feat/fix PR, unless you have a good reason
   3. Doc is required for the feat PR
   4. Use a new commit to resolve review instead of `push -f`
   5. Use "request review" to notify the reviewer once you have resolved the review
   -->
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #959: feat: fix the e2e test case of the server-info plugin for APISIX v2.13

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #959:
URL: https://github.com/apache/apisix-ingress-controller/pull/959#issuecomment-1094951806

   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/959?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#959](https://codecov.io/gh/apache/apisix-ingress-controller/pull/959?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d43ec24) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/22cfb5ec7482e1bca6d293091ce8c7aa5342260b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (22cfb5e) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head d43ec24 differs from pull request most recent head e20bee0. Consider uploading reports for the commit e20bee0 to get more accurate results
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #959   +/-   ##
   =======================================
     Coverage   31.75%   31.75%           
   =======================================
     Files          72       72           
     Lines        7935     7935           
   =======================================
     Hits         2520     2520           
     Misses       5139     5139           
     Partials      276      276           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/959?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/959?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [22cfb5e...e20bee0](https://codecov.io/gh/apache/apisix-ingress-controller/pull/959?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #959: feat: fix the e2e test case of the server-info plugin for APISIX v2.13

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #959:
URL: https://github.com/apache/apisix-ingress-controller/pull/959#issuecomment-1095069381

   please check the CI jobs error 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #959: feat: fix the e2e test case of the server-info plugin for APISIX v2.13

Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #959:
URL: https://github.com/apache/apisix-ingress-controller/pull/959


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #959: feat: fix the e2e test case of the server-info plugin for APISIX v2.13

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #959:
URL: https://github.com/apache/apisix-ingress-controller/pull/959#issuecomment-1095765697

   re-run CI jobs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org