You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Shazron <sh...@gmail.com> on 2013/09/17 02:03:33 UTC
core plugins mistake
I forgot that they are supposed to go into dev, not master.
Affected:
cordova-plugin-media
cordova-plugin-media-capture
cordova-plugin-splashscreen
Will cherry-pick into dev and revert in master.
Re: core plugins mistake
Posted by Jesse <pu...@gmail.com>.
Perfect! Thanks Anis.
@purplecabbage
risingj.com
On Tue, Sep 17, 2013 at 1:10 PM, Anis KADRI <an...@gmail.com> wrote:
> That will change in 3.1 and I am in the process of updating the docs for
> it.
>
> On Tue, Sep 17, 2013 at 12:20 PM, Shazron <sh...@gmail.com> wrote:
> > This might have been decided in another thread I believe...(not sure). As
> > it is, relying on master is a legacy concern for 3.0.0 since by default I
> > believe "cordova plugin add" in 3.0.0 pulls from master (I think)
> >
> >
> > On Tue, Sep 17, 2013 at 9:29 AM, purplecabbage <purplecabbage@gmail.com
> >wrote:
> >
> >> I mean fix the process, plugins should always match a version to a tag
> or
> >> a branch and master should always be bleeding.
> >> One bad commit to master should not break the plugin, as it is now.
> >>
> >> Sent from my iPhone
> >>
> >> > On Sep 17, 2013, at 5:14 AM, Shazron <sh...@gmail.com> wrote:
> >> >
> >> > Already fixed not 15 mins after I posted the email
> >> >
> >> >
> >> > On Mon, Sep 16, 2013 at 5:48 PM, purplecabbage <
> purplecabbage@gmail.com
> >> >wrote:
> >> >
> >> >> When is this gonna be fixed? I guarantee there are other master
> commits
> >> >> that should be in this release.
> >> >>
> >> >> Sent from my iPhone
> >> >>
> >> >>> On Sep 16, 2013, at 5:03 PM, Shazron <sh...@gmail.com> wrote:
> >> >>>
> >> >>> I forgot that they are supposed to go into dev, not master.
> >> >>>
> >> >>> Affected:
> >> >>> cordova-plugin-media
> >> >>> cordova-plugin-media-capture
> >> >>> cordova-plugin-splashscreen
> >> >>>
> >> >>> Will cherry-pick into dev and revert in master.
> >> >>
> >>
>
Re: core plugins mistake
Posted by Anis KADRI <an...@gmail.com>.
That will change in 3.1 and I am in the process of updating the docs for it.
On Tue, Sep 17, 2013 at 12:20 PM, Shazron <sh...@gmail.com> wrote:
> This might have been decided in another thread I believe...(not sure). As
> it is, relying on master is a legacy concern for 3.0.0 since by default I
> believe "cordova plugin add" in 3.0.0 pulls from master (I think)
>
>
> On Tue, Sep 17, 2013 at 9:29 AM, purplecabbage <pu...@gmail.com>wrote:
>
>> I mean fix the process, plugins should always match a version to a tag or
>> a branch and master should always be bleeding.
>> One bad commit to master should not break the plugin, as it is now.
>>
>> Sent from my iPhone
>>
>> > On Sep 17, 2013, at 5:14 AM, Shazron <sh...@gmail.com> wrote:
>> >
>> > Already fixed not 15 mins after I posted the email
>> >
>> >
>> > On Mon, Sep 16, 2013 at 5:48 PM, purplecabbage <purplecabbage@gmail.com
>> >wrote:
>> >
>> >> When is this gonna be fixed? I guarantee there are other master commits
>> >> that should be in this release.
>> >>
>> >> Sent from my iPhone
>> >>
>> >>> On Sep 16, 2013, at 5:03 PM, Shazron <sh...@gmail.com> wrote:
>> >>>
>> >>> I forgot that they are supposed to go into dev, not master.
>> >>>
>> >>> Affected:
>> >>> cordova-plugin-media
>> >>> cordova-plugin-media-capture
>> >>> cordova-plugin-splashscreen
>> >>>
>> >>> Will cherry-pick into dev and revert in master.
>> >>
>>
Re: core plugins mistake
Posted by Shazron <sh...@gmail.com>.
This might have been decided in another thread I believe...(not sure). As
it is, relying on master is a legacy concern for 3.0.0 since by default I
believe "cordova plugin add" in 3.0.0 pulls from master (I think)
On Tue, Sep 17, 2013 at 9:29 AM, purplecabbage <pu...@gmail.com>wrote:
> I mean fix the process, plugins should always match a version to a tag or
> a branch and master should always be bleeding.
> One bad commit to master should not break the plugin, as it is now.
>
> Sent from my iPhone
>
> > On Sep 17, 2013, at 5:14 AM, Shazron <sh...@gmail.com> wrote:
> >
> > Already fixed not 15 mins after I posted the email
> >
> >
> > On Mon, Sep 16, 2013 at 5:48 PM, purplecabbage <purplecabbage@gmail.com
> >wrote:
> >
> >> When is this gonna be fixed? I guarantee there are other master commits
> >> that should be in this release.
> >>
> >> Sent from my iPhone
> >>
> >>> On Sep 16, 2013, at 5:03 PM, Shazron <sh...@gmail.com> wrote:
> >>>
> >>> I forgot that they are supposed to go into dev, not master.
> >>>
> >>> Affected:
> >>> cordova-plugin-media
> >>> cordova-plugin-media-capture
> >>> cordova-plugin-splashscreen
> >>>
> >>> Will cherry-pick into dev and revert in master.
> >>
>
Re: core plugins mistake
Posted by purplecabbage <pu...@gmail.com>.
I mean fix the process, plugins should always match a version to a tag or a branch and master should always be bleeding.
One bad commit to master should not break the plugin, as it is now.
Sent from my iPhone
> On Sep 17, 2013, at 5:14 AM, Shazron <sh...@gmail.com> wrote:
>
> Already fixed not 15 mins after I posted the email
>
>
> On Mon, Sep 16, 2013 at 5:48 PM, purplecabbage <pu...@gmail.com>wrote:
>
>> When is this gonna be fixed? I guarantee there are other master commits
>> that should be in this release.
>>
>> Sent from my iPhone
>>
>>> On Sep 16, 2013, at 5:03 PM, Shazron <sh...@gmail.com> wrote:
>>>
>>> I forgot that they are supposed to go into dev, not master.
>>>
>>> Affected:
>>> cordova-plugin-media
>>> cordova-plugin-media-capture
>>> cordova-plugin-splashscreen
>>>
>>> Will cherry-pick into dev and revert in master.
>>
Re: core plugins mistake
Posted by Shazron <sh...@gmail.com>.
Already fixed not 15 mins after I posted the email
On Mon, Sep 16, 2013 at 5:48 PM, purplecabbage <pu...@gmail.com>wrote:
> When is this gonna be fixed? I guarantee there are other master commits
> that should be in this release.
>
> Sent from my iPhone
>
> > On Sep 16, 2013, at 5:03 PM, Shazron <sh...@gmail.com> wrote:
> >
> > I forgot that they are supposed to go into dev, not master.
> >
> > Affected:
> > cordova-plugin-media
> > cordova-plugin-media-capture
> > cordova-plugin-splashscreen
> >
> > Will cherry-pick into dev and revert in master.
>
Re: core plugins mistake
Posted by purplecabbage <pu...@gmail.com>.
When is this gonna be fixed? I guarantee there are other master commits that should be in this release.
Sent from my iPhone
> On Sep 16, 2013, at 5:03 PM, Shazron <sh...@gmail.com> wrote:
>
> I forgot that they are supposed to go into dev, not master.
>
> Affected:
> cordova-plugin-media
> cordova-plugin-media-capture
> cordova-plugin-splashscreen
>
> Will cherry-pick into dev and revert in master.