[GitHub] [ignite-3] sk0x50 commented on a change in pull request #748: IGNITE-16727 Add an option to turn off metadata synchronization

[GitBox <gi...@apache.org>]

sk0x50 commented on a change in pull request #748:
URL: https://github.com/apache/ignite-3/pull/748#discussion_r839283283



##########
File path: modules/configuration/src/main/java/org/apache/ignite/internal/configuration/util/ConfigurationUtil.java
##########
@@ -1127,6 +1128,12 @@ public static boolean containsNameAnnotation(Field schemaField) {
 
         assert property instanceof ConfigurationNode;
 
+        // If the property is set as {@code true} the attempt to get configuration property direct from Metastorage will be skipped, and
+        // the local one local will be returned. Otherwise, when the property is set as {@code false}, the direct property will be returned.
+        if (IgniteSystemProperties.getBoolean("IGNITE_GET_METADATA_LOCALLY_ONLY")) {

Review comment:
       We should not read this system property through `IgniteSystemProperties` because this call ends up with `Hashtable.get()` which is `synchronized`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org