You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/20 14:53:32 UTC
[GitHub] [dubbo-go-hessian2] aliiohs commented on a change in pull request #190: Decode Non-Exist field in Go
aliiohs commented on a change in pull request #190:
URL: https://github.com/apache/dubbo-go-hessian2/pull/190#discussion_r427332556
##########
File path: date_test.go
##########
@@ -20,9 +20,7 @@ package hessian
import (
"testing"
"time"
-)
-import (
"github.com/stretchr/testify/assert"
Review comment:
can move to third party package
##########
File path: object.go
##########
@@ -19,12 +19,11 @@ package hessian
import (
"io"
+ "log"
"reflect"
"strings"
"sync"
-)
-import (
perrors "github.com/pkg/errors"
Review comment:
move to third party package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org