You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/08 11:17:26 UTC
[GitHub] [skywalking-satellite] EvanLjp opened a new pull request #6: add satellite main structure
EvanLjp opened a new pull request #6:
URL: https://github.com/apache/skywalking-satellite/pull/6
add satellite main structure, would add some unit later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp closed pull request #6: add satellite main structure
Posted by GitBox <gi...@apache.org>.
EvanLjp closed pull request #6:
URL: https://github.com/apache/skywalking-satellite/pull/6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] surlymo commented on a change in pull request #6: add satellite main structure
Posted by GitBox <gi...@apache.org>.
surlymo commented on a change in pull request #6:
URL: https://github.com/apache/skywalking-satellite/pull/6#discussion_r539237827
##########
File path: internal/satellite/boot/boot.go
##########
@@ -0,0 +1,105 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package boot
+
+import (
+ "context"
+ "os"
+ "sync"
+ "syscall"
+
+ "os/signal"
+
+ "github.com/apache/skywalking-satellite/internal/pkg/log"
+ "github.com/apache/skywalking-satellite/internal/satellite/config"
+ "github.com/apache/skywalking-satellite/internal/satellite/module"
+)
+
+// Start Satellite.
+func Start(cfg *config.SatelliteConfig) error {
Review comment:
it seems simpler if merging defaultplugin & service design. plugin only have four layers:
plugin basic init -> lifecycle management -> specific plugin interface -> specific plugin implements
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on pull request #6: add satellite main structure
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #6:
URL: https://github.com/apache/skywalking-satellite/pull/6#issuecomment-740649769
@nic-chen already create a new PR. And please don't delete the current branch before the small PRs are approved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on pull request #6: add satellite main structure
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #6:
URL: https://github.com/apache/skywalking-satellite/pull/6#issuecomment-740657426
> What is the relationship between this and #8 ?
@nic-chen thinks the pr is too huge, suggest me to split it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on pull request #6: add satellite main structure
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #6:
URL: https://github.com/apache/skywalking-satellite/pull/6#issuecomment-740627858
> Maybe we could split it into several small PRs and merge them one by one?
no problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp edited a comment on pull request #6: add satellite main structure
Posted by GitBox <gi...@apache.org>.
EvanLjp edited a comment on pull request #6:
URL: https://github.com/apache/skywalking-satellite/pull/6#issuecomment-740657426
> What is the relationship between this and #8 ?
@nic-chen thinks the pr is too huge, suggest me to split it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on pull request #6: add satellite main structure
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #6:
URL: https://github.com/apache/skywalking-satellite/pull/6#issuecomment-740597628
@wu-sheng some core design doc is pushed and each specific module has comments. If anything is not clear, please let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #6: add satellite main structure
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6:
URL: https://github.com/apache/skywalking-satellite/pull/6#issuecomment-740588725
I will wait for the doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] gxthrj commented on pull request #6: add satellite main structure
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #6:
URL: https://github.com/apache/skywalking-satellite/pull/6#issuecomment-740560837
Huge PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on pull request #6: add satellite main structure
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #6:
URL: https://github.com/apache/skywalking-satellite/pull/6#issuecomment-740561483
> Huge PR
would add some doc later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #6: add satellite main structure
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6:
URL: https://github.com/apache/skywalking-satellite/pull/6#issuecomment-740650667
I just asked @kezhenxu94 to open required CIs and auto-update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #6: add satellite main structure
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6:
URL: https://github.com/apache/skywalking-satellite/pull/6#issuecomment-740656086
What is the relationship between this and #8 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] nic-chen commented on pull request #6: add satellite main structure
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #6:
URL: https://github.com/apache/skywalking-satellite/pull/6#issuecomment-740610476
Maybe we could split it into several small PRs and merge them one by one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org