You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/01/22 16:31:45 UTC
[GitHub] [solr] dsmiley opened a new pull request #556: SOLR-15949: Docker, use Java 17
dsmiley opened a new pull request #556:
URL: https://github.com/apache/solr/pull/556
azul/zulu-openjdk-alpine:17-jre-headless
Also switched OS from Debian to Alpine. WIP
https://issues.apache.org/jira/browseSOLR-15949
It wasn't easy to find a Java 17 *JRE* in Docker hub but I ultimately did with Azul. I trust them.
In my attempt to do this, I wound up choosing Alpine, which is another, perhaps bigger change. I'd be happy to move this off to another issue; I really should but I'm pushing this now to show what I have since I put time into it. I think most edits and possible further TODO in this PR are due to Alpine.
* I added `su-exec` instead of `gosu` which I found easier to install, and I hear it's smaller. I removed to gosu test; honestly I'm not sure where it's used -- if nowhere then maybe we don't need a test.
* init-var-solr was using `cp -a ...` but I saw warnings because the owner couldn't be preserved, which makes sense. This could be done independently of this PR; it may not be related but it was a warning I saw.
* I tested `gradlew testDocker` and it passes.
* I suspect the official image building might not work because I didn't find all of the unix add-ons when converting to `apk`. I didn't try it yet; this is a TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #556: SOLR-15949: Docker, use Java 17
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #556:
URL: https://github.com/apache/solr/pull/556#issuecomment-1020258657
As for the change from debian to alpine, I don't think we can use that image as our default base image: https://github.com/docker-library/official-images#repeatability
Official images can't be built on top of non-official images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #556: SOLR-15949: Docker, use Java 17
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #556:
URL: https://github.com/apache/solr/pull/556#discussion_r800688885
##########
File path: solr/docker/build.gradle
##########
@@ -27,7 +27,7 @@ apply plugin: 'base'
def dockerImageRepo = propertyOrEnvOrDefault("solr.docker.imageRepo", "SOLR_DOCKER_IMAGE_REPO", "apache/solr")
def dockerImageTag = propertyOrEnvOrDefault("solr.docker.imageTag", "SOLR_DOCKER_IMAGE_TAG", "${version}")
def dockerImageName = propertyOrEnvOrDefault("solr.docker.imageName", "SOLR_DOCKER_IMAGE_NAME", "${dockerImageRepo}:${dockerImageTag}")
-def baseDockerImage = propertyOrEnvOrDefault("solr.docker.baseImage", "SOLR_DOCKER_BASE_IMAGE", 'openjdk:11-jre-slim')
+def baseDockerImage = propertyOrEnvOrDefault("solr.docker.baseImage", "SOLR_DOCKER_BASE_IMAGE", 'openjdk:17-slim')
Review comment:
```suggestion
def baseDockerImage = propertyOrEnvOrDefault("solr.docker.baseImage", "SOLR_DOCKER_BASE_IMAGE", 'eclipse-temurin:17-jre')
```
##########
File path: solr/docker/gradle-help.txt
##########
@@ -17,7 +17,7 @@ gradlew dockerBuild
The docker build task accepts the following inputs, all accepted via both Environment Variables and Gradle Properties.
Base Docker Image: (The docker image used for the "FROM" in the Solr Dockerfile)
- Default: "openjdk:11-jre-slim"
+ Default: "openjdk:17-slim"
Review comment:
```suggestion
Default: "eclipse-temurin:17-jre"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #556: SOLR-15949: Docker, use Java 17
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #556:
URL: https://github.com/apache/solr/pull/556#issuecomment-1019305303
FYI https://hub.docker.com/r/azul/zulu-openjdk-alpine/tags
JRE vs JDK saves almost 80MB which is a ton. Interestingly the "-headless" seems to change nothing for the image sizes. Note that the numbers there are compressed numbers. When it gets to your machine, these expand significantly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #556: SOLR-15949: Docker, use Java 17
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #556:
URL: https://github.com/apache/solr/pull/556#issuecomment-1019304014
I saw this JIRA issue about `lsof` https://issues.apache.org/jira/browse/SOLR-13089 that was closed because we moved away from Alpine once but may be relevant again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #556: SOLR-15949: Docker, use Java 17
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #556:
URL: https://github.com/apache/solr/pull/556#issuecomment-1032522206
Tested `SOLR_DOCKER_BASE_IMAGE=eclipse-temurin:17-jre ./gradlew dockerBuild` and started the resulting image. Worked great. Just add CHANGES and possibly major-changes entries and we shuold be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley merged pull request #556: SOLR-15949: Docker, use Java 17
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #556:
URL: https://github.com/apache/solr/pull/556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org