[GitHub] [arrow] pitrou commented on a change in pull request #7284: ARROW-7409: [C++][Python] Windows link error LNK1104: cannot open file 'python37_d.lib'

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #7284:
URL: https://github.com/apache/arrow/pull/7284#discussion_r433810778



##########
File path: cpp/src/arrow/python/CMakeLists.txt
##########
@@ -60,7 +60,14 @@ endif()
 
 set(ARROW_PYTHON_SHARED_LINK_LIBS arrow_shared)
 if(WIN32)
-  list(APPEND ARROW_PYTHON_SHARED_LINK_LIBS ${PYTHON_LIBRARIES} ${PYTHON_OTHER_LIBS})
+  if(ARROW_USE_DEPRECATED_FIND_PYTHONLIBS)
+    list(APPEND ARROW_PYTHON_SHARED_LINK_LIBS 
+         $<$<CONFIG:Debug>:${PYTHON_DEBUG_LIBRARIES}> 
+         $<$<CONFIG:Release>:${PYTHON_LIBRARIES}> 

Review comment:
       Can't you factor out the debug/release library switch?

##########
File path: cpp/src/arrow/python/CMakeLists.txt
##########
@@ -87,6 +94,10 @@ add_arrow_lib(arrow_python
               EXTRA_INCLUDES
               "${ARROW_PYTHON_INCLUDES}")
 
+if(WIN32 AND TARGET arrow_python_shared AND NOT ARROW_USE_DEPRECATED_FIND_PYTHONLIBS)

Review comment:
       Why is this complication needed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org