You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "xdkxlk (via GitHub)" <gi...@apache.org> on 2023/05/22 06:52:56 UTC
[GitHub] [rocketmq] xdkxlk opened a new pull request, #6786: [ISSUE #6785] Isolate the remoteChannel by group
xdkxlk opened a new pull request, #6786:
URL: https://github.com/apache/rocketmq/pull/6786
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #6785
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xdkxlk merged pull request #6786: [ISSUE #6785] Isolate the remoteChannel by group
Posted by "xdkxlk (via GitHub)" <gi...@apache.org>.
xdkxlk merged PR #6786:
URL: https://github.com/apache/rocketmq/pull/6786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] chenzlalvin commented on a diff in pull request #6786: [ISSUE #6785] Isolate the remoteChannel by group
Posted by "chenzlalvin (via GitHub)" <gi...@apache.org>.
chenzlalvin commented on code in PR #6786:
URL: https://github.com/apache/rocketmq/pull/6786#discussion_r1201348073
##########
proxy/src/main/java/org/apache/rocketmq/proxy/service/sysmessage/HeartbeatSyncer.java:
##########
@@ -49,7 +49,7 @@ public class HeartbeatSyncer extends AbstractSystemMessageSyncer {
protected ThreadPoolExecutor threadPoolExecutor;
protected ConsumerManager consumerManager;
- protected final Map<String /* channelId as longText */, RemoteChannel> remoteChannelMap = new ConcurrentHashMap<>();
+ protected final Map<String /* group @ channelId as longText */, RemoteChannel> remoteChannelMap = new ConcurrentHashMap<>();
Review Comment:
Will the "@" symbol conflict with the Group character?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xdkxlk commented on a diff in pull request #6786: [ISSUE #6785] Isolate the remoteChannel by group
Posted by "xdkxlk (via GitHub)" <gi...@apache.org>.
xdkxlk commented on code in PR #6786:
URL: https://github.com/apache/rocketmq/pull/6786#discussion_r1201607056
##########
proxy/src/main/java/org/apache/rocketmq/proxy/service/sysmessage/HeartbeatSyncer.java:
##########
@@ -49,7 +49,7 @@ public class HeartbeatSyncer extends AbstractSystemMessageSyncer {
protected ThreadPoolExecutor threadPoolExecutor;
protected ConsumerManager consumerManager;
- protected final Map<String /* channelId as longText */, RemoteChannel> remoteChannelMap = new ConcurrentHashMap<>();
+ protected final Map<String /* group @ channelId as longText */, RemoteChannel> remoteChannelMap = new ConcurrentHashMap<>();
Review Comment:
This is not a problem, as long as clients from different groups can be distinguished here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6786: [ISSUE #6785] Isolate the remoteChannel by group
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6786:
URL: https://github.com/apache/rocketmq/pull/6786#issuecomment-1556667464
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/6786?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#6786](https://app.codecov.io/gh/apache/rocketmq/pull/6786?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bde54e3) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/9dfd4a95997bfe0aa0ab6d812f6b4dd01509d8d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9dfd4a9) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## develop #6786 +/- ##
=============================================
+ Coverage 42.84% 42.89% +0.05%
- Complexity 8976 8987 +11
=============================================
Files 1108 1104 -4
Lines 78444 78376 -68
Branches 10212 10203 -9
=============================================
+ Hits 33607 33620 +13
+ Misses 40617 40542 -75
+ Partials 4220 4214 -6
```
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq/pull/6786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...client/consumer/store/RemoteBrokerOffsetStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/6786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvc3RvcmUvUmVtb3RlQnJva2VyT2Zmc2V0U3RvcmUuamF2YQ==) | `68.75% <100.00%> (-0.28%)` | :arrow_down: |
| [...etmq/proxy/service/sysmessage/HeartbeatSyncer.java](https://app.codecov.io/gh/apache/rocketmq/pull/6786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3NlcnZpY2Uvc3lzbWVzc2FnZS9IZWFydGJlYXRTeW5jZXIuamF2YQ==) | `68.04% <100.00%> (ø)` | |
... and [23 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/6786/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org